From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B342C4361B for ; Tue, 8 Dec 2020 17:03:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3650423B02 for ; Tue, 8 Dec 2020 17:03:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730295AbgLHRD6 (ORCPT ); Tue, 8 Dec 2020 12:03:58 -0500 Received: from mail.kernel.org ([198.145.29.99]:47042 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729585AbgLHRD6 (ORCPT ); Tue, 8 Dec 2020 12:03:58 -0500 Date: Tue, 8 Dec 2020 09:03:15 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607446998; bh=hOxuE1yQii1MZ5uR5LWDKoL24MnmLt2SEUCCB265/ow=; h=From:To:Cc:Subject:In-Reply-To:References:From; b=Zy2Icuu6Tc/wAPCjg+hlXbwqWtI/np7rvQJKtMOPYjyv4FEfAqW+1AVNsxKCcRl7t TW4Ejn07tpvAdxiHNRWpAZCA8IVmpUG1Pf7MwYnoSL1KKIBqTuzZzPOQnQflPxmNyT cb+fskkE89kZaYau5mk5U/nJCUyr8D/8v2rN9nkxolTXENRB7dTUwVXN6fZxReOjb0 yEB5HcrgrNcDF7x5yw4LoxLOEhc2f9KekGiUmWQH3gAwNsf2bDCkK/X9l2WdaZvw9X bcEreRZSpa5G+uVEqztFXnQ0zPN80WapmHRiK7z06NTfWp7bxyCzyAqvFA3Csk8nek ehgqZ3I8dbXfw== From: Jakub Kicinski To: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= Cc: "David S. Miller" , Daniel Borkmann , Alexei Starovoitov , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Jesper Dangaard Brouer , "Michael S. Tsirkin" , Romain Perier , Allen Pais , Grygorii Strashko , Simon Horman , "Gustavo A. R. Silva" , Lorenzo Bianconi , Wei Yongjun , Jiri Benc , oss-drivers@netronome.com, linux-omap@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH bpf v2 0/7] selftests/bpf: Restore test_offload.py to working order Message-ID: <20201208090315.5106c049@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com> In-Reply-To: <87360gidoo.fsf@toke.dk> References: <160708272217.192754.14019805999368221369.stgit@toke.dk> <87360gidoo.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Tue, 08 Dec 2020 15:18:31 +0100 Toke H=C3=B8iland-J=C3=B8rgensen wrote: > Toke H=C3=B8iland-J=C3=B8rgensen writes: >=20 > > This series restores the test_offload.py selftest to working order. It = seems a > > number of subtle behavioural changes have crept into various subsystems= which > > broke test_offload.py in a number of ways. Most of these are fairly ben= ign > > changes where small adjustments to the test script seems to be the best= fix, but > > one is an actual kernel bug that I've observed in the wild caused by a = bad > > interaction between xdp_attachment_flags_ok() and the rework of XDP pro= gram > > handling in the core netdev code. > > > > Patch 1 fixes the bug by removing xdp_attachment_flags_ok(), and the re= minder of > > the patches are adjustments to test_offload.py, including a new feature= for > > netdevsim to force a BPF verification fail. Please see the individual p= atches > > for details. > > > > Changelog: > > > > v2: > > - Replace xdp_attachment_flags_ok() with a check in dev_xdp_attach() > > - Better packing of struct nsim_dev =20 >=20 > Any feedback on v2? Would be great to get it merged before the final > 5.10 release :) LGTM but if my opinion mattered this could would not have been changed in the first place :)