From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0346CC4361B for ; Tue, 8 Dec 2020 09:50:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B5148233FA for ; Tue, 8 Dec 2020 09:50:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728558AbgLHJtx (ORCPT ); Tue, 8 Dec 2020 04:49:53 -0500 Received: from mail.skyhub.de ([5.9.137.197]:60852 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727612AbgLHJtw (ORCPT ); Tue, 8 Dec 2020 04:49:52 -0500 Received: from zn.tnic (p200300ec2f0f0800de4a64cb7778f3c5.dip0.t-ipconnect.de [IPv6:2003:ec:2f0f:800:de4a:64cb:7778:f3c5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 206B41EC026D; Tue, 8 Dec 2020 10:49:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1607420951; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=nHwrzM8sBYNzv3ZS/BVe63dW+mG8m9RUPLrJK5+MKCc=; b=V4UeYHj/eosomKIA9BRFUbVJfw6zHLgZzMrF7YI5efUMT6fFPsA7WJ+GaTTxd1v5FuWVM8 anEiGoNi/O3FPInZWnkmxzB2yeYwXYuH7SI7HamwIaCZSfvEW7OnwEP5P9x9J7ISuanBCM HKJFqjKTLP/83HQIS9uvXCiHr2NkjSc= Date: Tue, 8 Dec 2020 10:49:07 +0100 From: Borislav Petkov To: Reinette Chatre Cc: tglx@linutronix.de, fenghua.yu@intel.com, tony.luck@intel.com, kuo-lang.tseng@intel.com, shakeelb@google.com, valentin.schneider@arm.com, mingo@redhat.com, babu.moger@amd.com, james.morse@arm.com, hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/3] x86/resctrl: Move setting task's active CPU in a mask into helpers Message-ID: <20201208094907.GB27920@zn.tnic> References: <77973e75a10bf7ef9b33c664544667deee9e1a8e.1607036601.git.reinette.chatre@intel.com> <20201207182912.GF20489@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 07, 2020 at 01:24:51PM -0800, Reinette Chatre wrote: > How about: > "Move the setting of the CPU on which a task is running in a CPU mask into a > couple of helpers. > > There is no functional change. This is a preparatory change for the fix in > the following patch from where the Fixes tag is copied." Almost. Just not call it a "following patch" because once this is applied, the following one might be a different one depending on the ordering a git command has requested. So a "later patch" would be probably better. > Correct. I will add it. The addition to the commit message above aims to > explain a Fixes tag to a patch with no functional changes. Yes but you need to tell the stable people somehow that this one is a prerequisite and that they should pick it up too. Unless you can reorg your code this way that you don't need patch 1... Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette