From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAFDEC4167B for ; Tue, 8 Dec 2020 10:01:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 667D123A84 for ; Tue, 8 Dec 2020 10:01:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728416AbgLHKBd (ORCPT ); Tue, 8 Dec 2020 05:01:33 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:30523 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726218AbgLHKBc (ORCPT ); Tue, 8 Dec 2020 05:01:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607421606; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0iZqkZAphNZf99PJFIaYexFrQFdjyflH/vT614+uZb8=; b=iAsDN+N3RksdiwtUTN9EXLZv4qhEadoGSKo9wWFBODFs3GrgV5VvieXAf/LTkIW7cRCtyS u50n+7/AC5rrihCn9UGEB7ZudWRlsJsUoSP0HihyLbgG2aB+Bjf8YpeR7YECm1DDGa9WoO vZuh6lWaWpItqbla4pQbED0phmiO++c= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-519-k_m0i4LmMCqeNxMYW764Fg-1; Tue, 08 Dec 2020 05:00:04 -0500 X-MC-Unique: k_m0i4LmMCqeNxMYW764Fg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9573F10054FF; Tue, 8 Dec 2020 09:59:59 +0000 (UTC) Received: from T590 (ovpn-12-237.pek2.redhat.com [10.72.12.237]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8F1AF2B394; Tue, 8 Dec 2020 09:59:40 +0000 (UTC) Date: Tue, 8 Dec 2020 17:59:35 +0800 From: Ming Lei To: Christoph Hellwig Cc: Jens Axboe , "Martin K . Petersen" , Oleksii Kurochko , Sagi Grimberg , Mike Snitzer , Ilya Dryomov , Dongsheng Yang , ceph-devel@vger.kernel.org, dm-devel@redhat.com, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, Hannes Reinecke Subject: Re: [PATCH 1/6] dm: use bdev_read_only to check if a device is read-only Message-ID: <20201208095935.GA1202995@T590> References: <20201207131918.2252553-1-hch@lst.de> <20201207131918.2252553-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201207131918.2252553-2-hch@lst.de> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Mon, Dec 07, 2020 at 02:19:13PM +0100, Christoph Hellwig wrote: > dm-thin and dm-cache also work on partitions, so use the proper > interface to check if the device is read-only. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Hannes Reinecke > --- > drivers/md/dm-cache-metadata.c | 2 +- > drivers/md/dm-thin-metadata.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/md/dm-cache-metadata.c b/drivers/md/dm-cache-metadata.c > index af6d4f898e4c1d..89a73204dbf47f 100644 > --- a/drivers/md/dm-cache-metadata.c > +++ b/drivers/md/dm-cache-metadata.c > @@ -449,7 +449,7 @@ static int __check_incompat_features(struct cache_disk_superblock *disk_super, > /* > * Check for read-only metadata to skip the following RDWR checks. > */ > - if (get_disk_ro(cmd->bdev->bd_disk)) > + if (bdev_read_only(cmd->bdev)) > return 0; > > features = le32_to_cpu(disk_super->compat_ro_flags) & ~DM_CACHE_FEATURE_COMPAT_RO_SUPP; > diff --git a/drivers/md/dm-thin-metadata.c b/drivers/md/dm-thin-metadata.c > index 6ebb2127f3e2e0..e75b20480e460e 100644 > --- a/drivers/md/dm-thin-metadata.c > +++ b/drivers/md/dm-thin-metadata.c > @@ -636,7 +636,7 @@ static int __check_incompat_features(struct thin_disk_superblock *disk_super, > /* > * Check for read-only metadata to skip the following RDWR checks. > */ > - if (get_disk_ro(pmd->bdev->bd_disk)) > + if (bdev_read_only(pmd->bdev)) > return 0; > > features = le32_to_cpu(disk_super->compat_ro_flags) & ~THIN_FEATURE_COMPAT_RO_SUPP; > -- > 2.29.2 > Reviewed-by: Ming Lei -- Ming From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B763CC433FE for ; Tue, 8 Dec 2020 10:00:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A80E217A0 for ; Tue, 8 Dec 2020 10:00:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A80E217A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0G4AJ6gYafQ2D/fgg63glZFF+fDciWSP1R5wXli9f6M=; b=KEFZHX1uT2jPeHIufDy20j+vQ BlYasDdPDquAxtfbOpDNcbYaQuPemdQfbASCgAi7Xqr0p2kZ1xiDqUKfI4+D+wU9fPDaMnlVkAHhg 86lEwjt7BLE2xJ7cNbehwq1nap75xpjdIBoJm8huojIra4g4T0WYxJdQPIP+sZ+NeHu676vZ7dohz KJY8ymczxn0twmhhuuBdO+86N4+7UZU4sMLxoFrX0TacYR8bB/Nj4lxASDtyLlV0XXZKeKof/Bnie 2yB50KFyxmz3h6aD/2kYKDyXcoyLsboqmSqxq2jBC6ZQVu187jjrF1opJ5g4jmjjWNJxZ0IFfWtk3 8/q/XnoBg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmZn2-00060L-Q7; Tue, 08 Dec 2020 10:00:12 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmZn0-0005zq-LE for linux-nvme@lists.infradead.org; Tue, 08 Dec 2020 10:00:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607421608; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0iZqkZAphNZf99PJFIaYexFrQFdjyflH/vT614+uZb8=; b=ZJt2GBq8EDxiQZO3MnAP7b51S8dpvPO4IniN1G18ZzMPbHv7YDDvPYMZxCZdeDvvbsoD99 o2r/Szb5p2uAIC5XvjeMaN655bAdzlKCiynO03oJf9CPZF6El61n6fe7ZLy7utsCVGKCke j8oQtAQ1QZPb7k+lbaElne5zhPyc8gU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-519-k_m0i4LmMCqeNxMYW764Fg-1; Tue, 08 Dec 2020 05:00:04 -0500 X-MC-Unique: k_m0i4LmMCqeNxMYW764Fg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9573F10054FF; Tue, 8 Dec 2020 09:59:59 +0000 (UTC) Received: from T590 (ovpn-12-237.pek2.redhat.com [10.72.12.237]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8F1AF2B394; Tue, 8 Dec 2020 09:59:40 +0000 (UTC) Date: Tue, 8 Dec 2020 17:59:35 +0800 From: Ming Lei To: Christoph Hellwig Subject: Re: [PATCH 1/6] dm: use bdev_read_only to check if a device is read-only Message-ID: <20201208095935.GA1202995@T590> References: <20201207131918.2252553-1-hch@lst.de> <20201207131918.2252553-2-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201207131918.2252553-2-hch@lst.de> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201208_050010_744248_A605CFAE X-CRM114-Status: GOOD ( 19.90 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , Sagi Grimberg , Mike Snitzer , Oleksii Kurochko , Dongsheng Yang , linux-block@vger.kernel.org, dm-devel@redhat.com, linux-nvme@lists.infradead.org, "Martin K . Petersen" , Ilya Dryomov , ceph-devel@vger.kernel.org, Hannes Reinecke Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Mon, Dec 07, 2020 at 02:19:13PM +0100, Christoph Hellwig wrote: > dm-thin and dm-cache also work on partitions, so use the proper > interface to check if the device is read-only. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Hannes Reinecke > --- > drivers/md/dm-cache-metadata.c | 2 +- > drivers/md/dm-thin-metadata.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/md/dm-cache-metadata.c b/drivers/md/dm-cache-metadata.c > index af6d4f898e4c1d..89a73204dbf47f 100644 > --- a/drivers/md/dm-cache-metadata.c > +++ b/drivers/md/dm-cache-metadata.c > @@ -449,7 +449,7 @@ static int __check_incompat_features(struct cache_disk_superblock *disk_super, > /* > * Check for read-only metadata to skip the following RDWR checks. > */ > - if (get_disk_ro(cmd->bdev->bd_disk)) > + if (bdev_read_only(cmd->bdev)) > return 0; > > features = le32_to_cpu(disk_super->compat_ro_flags) & ~DM_CACHE_FEATURE_COMPAT_RO_SUPP; > diff --git a/drivers/md/dm-thin-metadata.c b/drivers/md/dm-thin-metadata.c > index 6ebb2127f3e2e0..e75b20480e460e 100644 > --- a/drivers/md/dm-thin-metadata.c > +++ b/drivers/md/dm-thin-metadata.c > @@ -636,7 +636,7 @@ static int __check_incompat_features(struct thin_disk_superblock *disk_super, > /* > * Check for read-only metadata to skip the following RDWR checks. > */ > - if (get_disk_ro(pmd->bdev->bd_disk)) > + if (bdev_read_only(pmd->bdev)) > return 0; > > features = le32_to_cpu(disk_super->compat_ro_flags) & ~THIN_FEATURE_COMPAT_RO_SUPP; > -- > 2.29.2 > Reviewed-by: Ming Lei -- Ming _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 097D7C4361B for ; Tue, 8 Dec 2020 10:00:19 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7942F217A0 for ; Tue, 8 Dec 2020 10:00:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7942F217A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=dm-devel-bounces@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607421616; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=/M6+CkOAmzT4JFpXVG/L28+I7cGfmGwfJ+vkWobVAFQ=; b=Yp0jyPr9nNxLf9DZELM8cBkgPZWjK7zD21JAC78JeslqAVkCsXFbinlbBB3YABHJWJRCXE aIFgtNLGrojqkKOoIJ0M5xNUpSxjPQXdhKCFki4KcQaO/Ea8cU1r8N1BLDbkcXL0IK87aq GNGhJCSCKu57t6jl/rsHYQD4AQ/N0y4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-160-aO8Q7oWeMEqIF3D4GrLhgA-1; Tue, 08 Dec 2020 05:00:14 -0500 X-MC-Unique: aO8Q7oWeMEqIF3D4GrLhgA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3DCEE57001; Tue, 8 Dec 2020 10:00:10 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 12E3D19D80; Tue, 8 Dec 2020 10:00:09 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2C6AB180954D; Tue, 8 Dec 2020 10:00:05 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0B89xxn7030543 for ; Tue, 8 Dec 2020 04:59:59 -0500 Received: by smtp.corp.redhat.com (Postfix) id 943E46E51D; Tue, 8 Dec 2020 09:59:59 +0000 (UTC) Received: from T590 (ovpn-12-237.pek2.redhat.com [10.72.12.237]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8F1AF2B394; Tue, 8 Dec 2020 09:59:40 +0000 (UTC) Date: Tue, 8 Dec 2020 17:59:35 +0800 From: Ming Lei To: Christoph Hellwig Message-ID: <20201208095935.GA1202995@T590> References: <20201207131918.2252553-1-hch@lst.de> <20201207131918.2252553-2-hch@lst.de> MIME-Version: 1.0 In-Reply-To: <20201207131918.2252553-2-hch@lst.de> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: dm-devel@redhat.com Cc: Jens Axboe , Sagi Grimberg , Mike Snitzer , Oleksii Kurochko , Dongsheng Yang , linux-block@vger.kernel.org, dm-devel@redhat.com, linux-nvme@lists.infradead.org, "Martin K . Petersen" , Ilya Dryomov , ceph-devel@vger.kernel.org Subject: Re: [dm-devel] [PATCH 1/6] dm: use bdev_read_only to check if a device is read-only X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Dec 07, 2020 at 02:19:13PM +0100, Christoph Hellwig wrote: > dm-thin and dm-cache also work on partitions, so use the proper > interface to check if the device is read-only. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Hannes Reinecke > --- > drivers/md/dm-cache-metadata.c | 2 +- > drivers/md/dm-thin-metadata.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/md/dm-cache-metadata.c b/drivers/md/dm-cache-metadata.c > index af6d4f898e4c1d..89a73204dbf47f 100644 > --- a/drivers/md/dm-cache-metadata.c > +++ b/drivers/md/dm-cache-metadata.c > @@ -449,7 +449,7 @@ static int __check_incompat_features(struct cache_disk_superblock *disk_super, > /* > * Check for read-only metadata to skip the following RDWR checks. > */ > - if (get_disk_ro(cmd->bdev->bd_disk)) > + if (bdev_read_only(cmd->bdev)) > return 0; > > features = le32_to_cpu(disk_super->compat_ro_flags) & ~DM_CACHE_FEATURE_COMPAT_RO_SUPP; > diff --git a/drivers/md/dm-thin-metadata.c b/drivers/md/dm-thin-metadata.c > index 6ebb2127f3e2e0..e75b20480e460e 100644 > --- a/drivers/md/dm-thin-metadata.c > +++ b/drivers/md/dm-thin-metadata.c > @@ -636,7 +636,7 @@ static int __check_incompat_features(struct thin_disk_superblock *disk_super, > /* > * Check for read-only metadata to skip the following RDWR checks. > */ > - if (get_disk_ro(pmd->bdev->bd_disk)) > + if (bdev_read_only(pmd->bdev)) > return 0; > > features = le32_to_cpu(disk_super->compat_ro_flags) & ~THIN_FEATURE_COMPAT_RO_SUPP; > -- > 2.29.2 > Reviewed-by: Ming Lei -- Ming -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel