All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gao Xiang <hsiangkao@redhat.com>
To: Karel Zak <kzak@redhat.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH] libblkid: add erofs filesystem support
Date: Tue, 8 Dec 2020 18:19:50 +0800	[thread overview]
Message-ID: <20201208101950.GA3067897@xiangao.remote.csb> (raw)
In-Reply-To: <20201208100910.dqqh5cqihewkyetc@ws.net.home>

Hi Karel,

On Tue, Dec 08, 2020 at 11:09:10AM +0100, Karel Zak wrote:
> On Sat, Dec 05, 2020 at 03:44:10PM +0800, Gao Xiang wrote:
> > This patch adds support for detecting EROFS filesystem to libblkid.
> 
> Applied, thanks!

Thanks for taking time on this and the image/testcase!

> 
> I have also added simple regression test to tests/ts/blkid/images-fs/erofs.img.xz. 
> 
> Note that it seems the current mkfs.erofs cannot set volume_name (aka LABEL)
> although the filesystem superblock support it.

Yeah, since it has little use-case for now (but leave such field for later use),
I will add this feature if needed later :) Thanks for kind reminder!

>  
> 
> A small nitpick to mkfs.erofs, see https://github.com/hsiangkao/erofs-utils/blob/dev/mkfs/main.c#L27
> 
> The subdirectory in 
> 
>     #include <uuid/uuid.h> 
> 
> is unnecessary (or wrong), if you use 
> 
>     PKG_CHECK_MODULES([libuuid], [uuid])
> 
> than it returns the subdirectory as -I, see
> 
>     $ pkg-config --cflags uuid
>     -I/usr/include/uuid 
> 
> so the correct way is
> 
>      #include <uuid.h>
> 
> with the proper PKG_CHECK_MODULES(), btw you have it without
> subdirectory in configure.ac test.
> 
> The problem is that your code reads the default include file from
> /usr/include/uuid/ rather the one specified by your build system.

Yay, many thanks for catching this! will fix it soon!

Thanks,
Gao Xiang

> 
> 
>     Karel
> 
> -- 
>  Karel Zak  <kzak@redhat.com>
>  http://karelzak.blogspot.com
> 


      reply	other threads:[~2020-12-08 10:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-05  7:44 [PATCH] libblkid: add erofs filesystem support Gao Xiang
2020-12-08 10:09 ` Karel Zak
2020-12-08 10:19   ` Gao Xiang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201208101950.GA3067897@xiangao.remote.csb \
    --to=hsiangkao@redhat.com \
    --cc=kzak@redhat.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.