From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E2BEC1B0E3 for ; Tue, 8 Dec 2020 10:58:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1EB6223ABA for ; Tue, 8 Dec 2020 10:58:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729159AbgLHK6c (ORCPT ); Tue, 8 Dec 2020 05:58:32 -0500 Received: from verein.lst.de ([213.95.11.211]:45771 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728974AbgLHK6c (ORCPT ); Tue, 8 Dec 2020 05:58:32 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 637ED6736F; Tue, 8 Dec 2020 11:57:47 +0100 (CET) Date: Tue, 8 Dec 2020 11:57:47 +0100 From: Christoph Hellwig To: Ming Lei Cc: Christoph Hellwig , Jens Axboe , "Martin K . Petersen" , Oleksii Kurochko , Sagi Grimberg , Mike Snitzer , Ilya Dryomov , Dongsheng Yang , ceph-devel@vger.kernel.org, dm-devel@redhat.com, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, Hannes Reinecke Subject: Re: [PATCH 3/6] block: add a hard-readonly flag to struct gendisk Message-ID: <20201208105747.GA21762@lst.de> References: <20201207131918.2252553-1-hch@lst.de> <20201207131918.2252553-4-hch@lst.de> <20201208102211.GC1202995@T590> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201208102211.GC1202995@T590> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Dec 08, 2020 at 06:22:11PM +0800, Ming Lei wrote: > > int bdev_read_only(struct block_device *bdev) > > { > > - return bdev->bd_read_only; > > + return bdev->bd_read_only || > > + test_bit(GD_READ_ONLY, &bdev->bd_disk->state); > > } > > EXPORT_SYMBOL(bdev_read_only); > > Maybe one inline version can be added for fast path(bio_check_ro()), and the approach > is good: I thought of that, but our header mess means it would have to be a macro. I have a plan to reorganize the headers in the not too far future, at which point this should become an inline. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EC90C4167B for ; Tue, 8 Dec 2020 10:58:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0440C23AA7 for ; Tue, 8 Dec 2020 10:58:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0440C23AA7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wcdvSPFROV//bynGG1ISLwzZnFYUGLSR6j2oOTGjdqM=; b=uzKrlhQfqxKpNfd9EsNlCYef+ kNlDFD2rf6OTRy6GUZHC2PEBaCvAv+mdITbHzy4jJcngRe45en5yq4TL/2I6jnY6biaxIvghQCrhg CjeKHx0Z6/BasHq/Zgp2aUixG3e22HwLNlaDGHLMKP9bovP5luQvTVDxLyNca5Z60EDOCbT95X9sz josEGubc+2U36/Qtzy3oBB3nmuIexlsybYGjm2zdaq97kAwETmfmtydxIcR924aQ156u6p0bX64sX P61/NlCk7htZZGVR5sXARqBxizaux0a9StouTSH1AhpXHX4zLfq+7uLs2TLUuyGiyZb0bxsNdkvz9 3iPSqK6dw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmagt-0004au-CX; Tue, 08 Dec 2020 10:57:55 +0000 Received: from verein.lst.de ([213.95.11.211]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmagr-0004a8-7V for linux-nvme@lists.infradead.org; Tue, 08 Dec 2020 10:57:54 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 637ED6736F; Tue, 8 Dec 2020 11:57:47 +0100 (CET) Date: Tue, 8 Dec 2020 11:57:47 +0100 From: Christoph Hellwig To: Ming Lei Subject: Re: [PATCH 3/6] block: add a hard-readonly flag to struct gendisk Message-ID: <20201208105747.GA21762@lst.de> References: <20201207131918.2252553-1-hch@lst.de> <20201207131918.2252553-4-hch@lst.de> <20201208102211.GC1202995@T590> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201208102211.GC1202995@T590> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201208_055753_390140_3D348D31 X-CRM114-Status: GOOD ( 10.88 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , Sagi Grimberg , Mike Snitzer , Oleksii Kurochko , ceph-devel@vger.kernel.org, Dongsheng Yang , linux-block@vger.kernel.org, dm-devel@redhat.com, linux-nvme@lists.infradead.org, "Martin K . Petersen" , Ilya Dryomov , Christoph Hellwig , Hannes Reinecke Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Tue, Dec 08, 2020 at 06:22:11PM +0800, Ming Lei wrote: > > int bdev_read_only(struct block_device *bdev) > > { > > - return bdev->bd_read_only; > > + return bdev->bd_read_only || > > + test_bit(GD_READ_ONLY, &bdev->bd_disk->state); > > } > > EXPORT_SYMBOL(bdev_read_only); > > Maybe one inline version can be added for fast path(bio_check_ro()), and the approach > is good: I thought of that, but our header mess means it would have to be a macro. I have a plan to reorganize the headers in the not too far future, at which point this should become an inline. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1491C4361B for ; Tue, 8 Dec 2020 10:58:13 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 58E4123AA7 for ; Tue, 8 Dec 2020 10:58:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 58E4123AA7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=dm-devel-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-456-j_HXCmImMka4DJRxGHaHZQ-1; Tue, 08 Dec 2020 05:58:10 -0500 X-MC-Unique: j_HXCmImMka4DJRxGHaHZQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C24D080EF82; Tue, 8 Dec 2020 10:58:05 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 20FB46E51B; Tue, 8 Dec 2020 10:58:05 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 61931180954D; Tue, 8 Dec 2020 10:58:02 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0B8AvwUN004442 for ; Tue, 8 Dec 2020 05:57:58 -0500 Received: by smtp.corp.redhat.com (Postfix) id A3EF42166B2A; Tue, 8 Dec 2020 10:57:58 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9F03F2166B27 for ; Tue, 8 Dec 2020 10:57:56 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 43F3280088F for ; Tue, 8 Dec 2020 10:57:56 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-98-EJ8AFppUNbe2TMJtPUJmgQ-1; Tue, 08 Dec 2020 05:57:51 -0500 X-MC-Unique: EJ8AFppUNbe2TMJtPUJmgQ-1 Received: by verein.lst.de (Postfix, from userid 2407) id 637ED6736F; Tue, 8 Dec 2020 11:57:47 +0100 (CET) Date: Tue, 8 Dec 2020 11:57:47 +0100 From: Christoph Hellwig To: Ming Lei Message-ID: <20201208105747.GA21762@lst.de> References: <20201207131918.2252553-1-hch@lst.de> <20201207131918.2252553-4-hch@lst.de> <20201208102211.GC1202995@T590> MIME-Version: 1.0 In-Reply-To: <20201208102211.GC1202995@T590> User-Agent: Mutt/1.5.17 (2007-11-01) X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: dm-devel@redhat.com Cc: Jens Axboe , Sagi Grimberg , Mike Snitzer , Oleksii Kurochko , ceph-devel@vger.kernel.org, Dongsheng Yang , linux-block@vger.kernel.org, dm-devel@redhat.com, linux-nvme@lists.infradead.org, "Martin K . Petersen" , Ilya Dryomov , Christoph Hellwig Subject: Re: [dm-devel] [PATCH 3/6] block: add a hard-readonly flag to struct gendisk X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Dec 08, 2020 at 06:22:11PM +0800, Ming Lei wrote: > > int bdev_read_only(struct block_device *bdev) > > { > > - return bdev->bd_read_only; > > + return bdev->bd_read_only || > > + test_bit(GD_READ_ONLY, &bdev->bd_disk->state); > > } > > EXPORT_SYMBOL(bdev_read_only); > > Maybe one inline version can be added for fast path(bio_check_ro()), and the approach > is good: I thought of that, but our header mess means it would have to be a macro. I have a plan to reorganize the headers in the not too far future, at which point this should become an inline. -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel