From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kmh3b-0001AR-03 for mharc-grub-devel@gnu.org; Tue, 08 Dec 2020 12:45:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53176) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmh3Y-0001A6-V7 for grub-devel@gnu.org; Tue, 08 Dec 2020 12:45:45 -0500 Received: from mail-oi1-x243.google.com ([2607:f8b0:4864:20::243]:41754) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kmh3W-0004BV-1S for grub-devel@gnu.org; Tue, 08 Dec 2020 12:45:44 -0500 Received: by mail-oi1-x243.google.com with SMTP id 15so9070438oix.8 for ; Tue, 08 Dec 2020 09:45:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficientek-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; bh=3WvxxsVN1NgkH149um5LPgho3BvLcG/IEg5cZ1AqILM=; b=C+68CI+j2AKuIfKIk5w/BT52/2iH/6B27h2R6P8yLGcZSs+pPEH345gbGUIohDtltS 4wyP0l/kQBa++o1iZP8Xbvp4kVFW6Wjxuot1nnNqHqLj664f7jBdE4Ans6niL1XGpYr1 UH6w1Fo10VAwMS+UAA2HMAtyQMr3+Uaa9KiqaIwAa0k1cPm1ld17OvKElx0AY+xySiFa B/ZFuWnG6V0yAxvxUKKeP/6Zv3UiRJUBmXeyp6u2/nYe18fDg707RjkYdVT6nNLbwAZg 0N6CuMt+51sD9+ZGqGuk0aDAC0fQpNbXplzenYw1ySP2m2KQmyvH6CNNdffg3Vnu/sNg +w1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:reply-to:mime-version:content-transfer-encoding; bh=3WvxxsVN1NgkH149um5LPgho3BvLcG/IEg5cZ1AqILM=; b=YtgunNDtmUnalwviIM3kmnX8U9v+S8CLtcRjVcPgNmf1WnCdGBMcLN6mnIR1jY8Obm hzVBZc+IbqLlv+V7tbOK4209/n1AMk/Po8uimC9gnaZn/pgH9BOML0YodX1vdDqoVdy5 lwbYMhlKzGQkahZuYUYHIkme1E9vgxpknXJwoM6/qDPE8rvBEoua8BR61WwsbTiSGqW9 baJJREg0ncJIPKX6nxvSXXEC1Owmeob34CmztssNSPaW7g/6I6/6+wpz14FN6+X9mW7P ge45iIOVuNPBKzfVOWf5aUGTPKCX9xXI9uhMB8sF48A8ukoU/0GYjjwOL0/pts8hzkfR 4TrQ== X-Gm-Message-State: AOAM533RRX+E6b6879bdLkAYU/bjxL9CbGQvpsDmxut78y6zSwFvySvx 8/T2R14e9dnp601Q3i8z4JGKOw== X-Google-Smtp-Source: ABdhPJyZvg4i2C8ydknGR+v7hV8a7e4mnRbrW4Il3sm1ZeGyRhlgHTlXoxtS4wT3/IlJykB+/EubnQ== X-Received: by 2002:aca:38c2:: with SMTP id f185mr3573189oia.28.1607449540475; Tue, 08 Dec 2020 09:45:40 -0800 (PST) Received: from crass-HP-ZBook-15-G2 ([136.49.211.192]) by smtp.gmail.com with ESMTPSA id n22sm337143oig.32.2020.12.08.09.45.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Dec 2020 09:45:40 -0800 (PST) Date: Tue, 8 Dec 2020 11:45:37 -0600 From: Glenn Washburn To: Daniel Kiper Cc: grub-devel@gnu.org, Patrick Steinhardt , Daniel Kiper Subject: Re: [PATCH v7 03/17] luks2: Remove unused argument in grub_error Message-ID: <20201208114537.661d692b@crass-HP-ZBook-15-G2> In-Reply-To: <20201207195244.ewtype67spf7bw4l@tomti.i.net-space.pl> References: <20201207195244.ewtype67spf7bw4l@tomti.i.net-space.pl> Reply-To: development@efficientek.com X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::243; envelope-from=development@efficientek.com; helo=mail-oi1-x243.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Dec 2020 17:45:45 -0000 On Mon, 7 Dec 2020 20:52:44 +0100 Daniel Kiper wrote: > On Fri, Dec 04, 2020 at 10:43:32AM -0600, Glenn Washburn wrote: > > Reviewed-by: Daniel Kiper > > Signed-off-by: Glenn Washburn > > Nit, my RB should be after your SOB. I will fix it. > > Daniel This is annoying to do with how my git is setup, which is to automatically append my SOB when doing format-patch. Do you just do SOBs and RBs by hand, or have a way to do this more automatically? Glenn