From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB5D7C4361B for ; Tue, 8 Dec 2020 11:12:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0244523A1D for ; Tue, 8 Dec 2020 11:12:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0244523A1D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40728 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmaub-0008LJ-Hu for qemu-devel@archiver.kernel.org; Tue, 08 Dec 2020 06:12:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39166) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmatj-0007vb-V5 for qemu-devel@nongnu.org; Tue, 08 Dec 2020 06:11:11 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:23011) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kmati-0004ZO-2t for qemu-devel@nongnu.org; Tue, 08 Dec 2020 06:11:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607425869; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8rtpuf3ahQAFEjgKm+X3ChB4IQrwyFfG2+2TRAgCGuY=; b=HIweCgnMXLKcrMsWCzhAQTEciqqJLRv+0t29hmOgb7Fkcu/fRtevCVDyVnoBZ0xLU4gMHa NlGsa3FiHSBcYWXZZXEbNlqLUeuCPwz6Nmp7da8G2Npr9SO2w25/8OScJJUddzmmC9PeLO lmCk09FKT/0eYOGynCbroAHorXJvNyk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-490-aGywE1xhN3SfGrtvvaCPZA-1; Tue, 08 Dec 2020 06:11:07 -0500 X-MC-Unique: aGywE1xhN3SfGrtvvaCPZA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4CDE7802B45 for ; Tue, 8 Dec 2020 11:11:05 +0000 (UTC) Received: from localhost (unknown [10.40.208.65]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7610519D80; Tue, 8 Dec 2020 11:11:04 +0000 (UTC) Date: Tue, 8 Dec 2020 12:11:02 +0100 From: Igor Mammedov To: Paolo Bonzini Subject: Re: [PATCH 11/15] qtest: add a QOM object for qtest Message-ID: <20201208121102.349b46ca@redhat.com> In-Reply-To: References: <20201202081854.4126071-1-pbonzini@redhat.com> <20201202081854.4126071-12-pbonzini@redhat.com> <20201207172447.77d22d17@redhat.com> <853e64f9-9a37-5214-0111-b489dc82af44@redhat.com> <20201207175739.2f51f87e@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 7 Dec 2020 18:22:55 +0100 Paolo Bonzini wrote: > Il lun 7 dic 2020, 17:57 Igor Mammedov ha scritto: > > > On Mon, 7 Dec 2020 17:43:16 +0100 > > Paolo Bonzini wrote: > > > > > On 07/12/20 17:24, Igor Mammedov wrote: > > > >> +void qtest_server_init(const char *qtest_chrdev, const char > > *qtest_log, Error **errp) > > > >> +{ > > > >> + Chardev *chr; > > > >> + > > > >> + chr = qemu_chr_new("qtest", qtest_chrdev, NULL); > > > >> + > > > >> + if (chr == NULL) { > > > >> + error_setg(errp, "Failed to initialize device for qtest: > > \"%s\"", > > > >> + qtest_chrdev); > > > >> + return; > > > >> + } > > > >> + > > > >> + qtest_server_start(chr, qtest_log, errp); > > > > why not create qtest object here instead of trying to preserve old way, > > > > or create it directly at the place that calls qtest_server_init()? > > > > > > Because I wasn't sure of where to put it in the QOM object tree. So I > > > punted and left it for later. > > > > but you implicitly decided where it should be (with -object qtest), > > it goes to /objects. > > So I'd wouldn't put anywhere else to be consistent. > > > > No, /objects is for stuff created with -object exclusively. I suppose I > could have the "well-known path" be /machine/qtest, and it would be either > a child (for -qtest) or a link to /objects/some-id (for -object qtest). > Should I implement that (as a separate patch on top of this one)? yes > > Paolo > > > > > > > > > Paolo > > > > > > >