From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA4BBC4167B for ; Tue, 8 Dec 2020 16:39:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C135A23A53 for ; Tue, 8 Dec 2020 16:39:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730455AbgLHQi4 (ORCPT ); Tue, 8 Dec 2020 11:38:56 -0500 Received: from mga06.intel.com ([134.134.136.31]:28073 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726810AbgLHQi4 (ORCPT ); Tue, 8 Dec 2020 11:38:56 -0500 IronPort-SDR: GnUxrQ9zHboXsgQzKdFP/C8Y0q/OX5lEarL6nAYAFpS6yc/vWdGBIH9qvYA/pDyymCsOuhggNd hwdE/5SAZRiQ== X-IronPort-AV: E=McAfee;i="6000,8403,9829"; a="235521620" X-IronPort-AV: E=Sophos;i="5.78,402,1599548400"; d="scan'208";a="235521620" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2020 08:38:15 -0800 IronPort-SDR: vPkcZMeeZqXh6vd54T+E2QmFjfZ9AMaNHqWZAt/Wd0xuv0YZVDnmUEugJUuxnLBhX7DJaqzCIo wq1ybT1+EV6g== X-IronPort-AV: E=Sophos;i="5.78,402,1599548400"; d="scan'208";a="437442250" Received: from iweiny-desk2.sc.intel.com (HELO localhost) ([10.3.52.147]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2020 08:38:15 -0800 Date: Tue, 8 Dec 2020 08:38:14 -0800 From: Ira Weiny To: Matthew Wilcox Cc: Thomas Gleixner , Andrew Morton , Dave Hansen , Christoph Hellwig , Dan Williams , Al Viro , Eric Biggers , Joonas Lahtinen , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH V2 2/2] mm/highmem: Lift memcpy_[to|from]_page to core Message-ID: <20201208163814.GN1563847@iweiny-DESK2.sc.intel.com> References: <20201207225703.2033611-1-ira.weiny@intel.com> <20201207225703.2033611-3-ira.weiny@intel.com> <20201208122316.GH7338@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201208122316.GH7338@casper.infradead.org> User-Agent: Mutt/1.11.1 (2018-12-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 08, 2020 at 12:23:16PM +0000, Matthew Wilcox wrote: > On Mon, Dec 07, 2020 at 02:57:03PM -0800, ira.weiny@intel.com wrote: > > Placing these functions in 'highmem.h' is suboptimal especially with the > > changes being proposed in the functionality of kmap. From a caller > > perspective including/using 'highmem.h' implies that the functions > > defined in that header are only required when highmem is in use which is > > increasingly not the case with modern processors. Some headers like > > mm.h or string.h seem ok but don't really portray the functionality > > well. 'pagemap.h', on the other hand, makes sense and is already > > included in many of the places we want to convert. > > pagemap.h is for the page cache. It's not for "random page > functionality". Yes, I know it's badly named. No, I don't want to > rename it. These helpers should go in highmem.h along with zero_user(). I could have sworn you suggested pagemap.h. But I can't find the evidence on lore. :-/ hehehe... In the end the code does not care. I have a distaste for highmem.h because it is no longer for 'high memory'. And I think a number of driver writers who are targeting 64bit platforms just don't care any more. So as we head toward memory not being mapped by the kernel for other reasons I think highmem needs to be 'rebranded' if not renamed. Ira