From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org,
Matthew Auld <matthew.auld@intel.com>,
Chris Wilson <chris@chris-wilson.co.uk>
Subject: [Intel-gfx] [PATCH i-g-t] i915/gem_vm_create: Race vm-destroy against object free
Date: Tue, 8 Dec 2020 17:02:05 +0000 [thread overview]
Message-ID: <20201208170205.2039137-1-chris@chris-wilson.co.uk> (raw)
Matthew postulated that we should be able to hit a race in
__i915_vm_close() between the RCU object free and vma unbind viz
GEM_BUG_ON(!list_empty(&vm->bound_list));
due to the effect of leaving the vma on the list if we are unable to
obtain the kref to the object. Let's try and find that race.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Matthew Auld <matthew.auld@intel.com>
---
tests/i915/gem_vm_create.c | 65 ++++++++++++++++++++++++++++++++++++++
1 file changed, 65 insertions(+)
diff --git a/tests/i915/gem_vm_create.c b/tests/i915/gem_vm_create.c
index 8843b1b3b..8cd168328 100644
--- a/tests/i915/gem_vm_create.c
+++ b/tests/i915/gem_vm_create.c
@@ -24,6 +24,7 @@
#include "i915/gem.h"
#include "i915/gem_vm.h"
#include "igt.h"
+#include "igt_rand.h"
#include "igt_dummyload.h"
static int vm_create_ioctl(int i915, struct drm_i915_gem_vm_control *ctl)
@@ -386,6 +387,67 @@ static void async_destroy(int i915)
igt_spin_free(i915, spin[i]);
}
+static void destroy_race(int i915)
+{
+ const int ncpus = sysconf(_SC_NPROCESSORS_ONLN);
+ uint32_t *vm;
+
+ /* Check we can execute a polling spinner */
+ igt_spin_free(i915, igt_spin_new(i915, .flags = IGT_SPIN_POLL_RUN));
+
+ vm = mmap(NULL, 4096, PROT_WRITE, MAP_SHARED | MAP_ANON, -1, 0);
+ igt_assert(vm != MAP_FAILED);
+
+ for (int child = 0; child < ncpus; child++)
+ vm[child] = gem_vm_create(i915);
+
+ igt_fork(child, ncpus) {
+ uint32_t ctx = gem_context_create(i915);
+ igt_spin_t *spin;
+
+ spin = __igt_spin_new(i915, ctx, .flags = IGT_SPIN_POLL_RUN);
+ while (!READ_ONCE(vm[ncpus])) {
+ struct drm_i915_gem_context_param arg = {
+ .ctx_id = ctx,
+ .param = I915_CONTEXT_PARAM_VM,
+ .value = READ_ONCE(vm[child]),
+ };
+ igt_spin_t *nxt;
+
+ if (__gem_context_set_param(i915, &arg))
+ continue;
+
+ nxt = __igt_spin_new(i915, ctx,
+ .flags = IGT_SPIN_POLL_RUN);
+
+ igt_spin_end(spin);
+ gem_sync(i915, spin->handle);
+ igt_spin_free(i915, spin);
+
+ usleep(1000 + hars_petruska_f54_1_random_unsafe() % 2000);
+
+ spin = nxt;
+ }
+ igt_spin_free(i915, spin);
+ }
+
+ igt_until_timeout(5) {
+ for (int child = 0; child < ncpus; child++) {
+ gem_vm_destroy(i915, vm[child]);
+ vm[child] = gem_vm_create(i915);
+ }
+ usleep(1000 + hars_petruska_f54_1_random_unsafe() % 2000);
+ }
+
+ vm[ncpus] = 1;
+ igt_waitchildren();
+
+ for (int child = 0; child < ncpus; child++)
+ gem_vm_destroy(i915, vm[child]);
+
+ munmap(vm, 4096);
+}
+
igt_main
{
int i915 = -1;
@@ -418,6 +480,9 @@ igt_main
igt_subtest("async-destroy")
async_destroy(i915);
+
+ igt_subtest("destroy-race")
+ destroy_race(i915);
}
igt_fixture {
--
2.29.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2020-12-08 17:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 17:02 Chris Wilson [this message]
2020-12-08 17:56 ` [igt-dev] ✓ Fi.CI.BAT: success for i915/gem_vm_create: Race vm-destroy against object free Patchwork
2020-12-08 21:36 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2020-12-14 15:52 ` [Intel-gfx] [PATCH i-g-t] " Matthew Auld
2020-12-14 16:43 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201208170205.2039137-1-chris@chris-wilson.co.uk \
--to=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.