From: Sam Ravnborg <sam@ravnborg.org>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
linux-sh@vger.kernel.org, kernel test robot <lkp@intel.com>,
Lee Jones <lee.jones@linaro.org>, Arnd Bergmann <arnd@arndb.de>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Mike Rapoport <rppt@kernel.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] sh: Fix set but not used warnings with !CONFIG_MMU
Date: Tue, 8 Dec 2020 20:00:41 +0100 [thread overview]
Message-ID: <20201208190041.GA167310@ravnborg.org> (raw)
In-Reply-To: <07774d98-ada5-ecc6-229b-d5a2a60f86ee@suse.de>
Hi Thomas.
On Tue, Dec 08, 2020 at 07:52:49PM +0100, Thomas Zimmermann wrote:
>
>
> Am 08.12.20 um 19:21 schrieb Sam Ravnborg:
> > Building fbdev drivers for sh with W=1 produces the following warning:
> >
> > tmiofb.c: In function ‘tmiofb_remove’:
> > tmiofb.c:805:21: warning: variable ‘par’ set but not used
> >
> > This is with allmodconfig and ARCH=sh
> >
> > This boiled down to iounmap() defined as empty for !CONFIG_MMU.
> > Fix this by by adding "(void)addr;" to tell the compiler the
> > argument to iounmap() should be considered used.
> >
> > v4:
> > - Fix build error of ethernet driver (kernel test robot)
> > Added missing () around macro parameter
> >
> > Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> > Cc: kernel test robot <lkp@intel.com>
> > Cc: Thomas Zimmermann <tzimmermann@suse.de>
> > Cc: Lee Jones <lee.jones@linaro.org>
> > Cc: Rich Felker <dalias@libc.org>
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> > Cc: Mike Rapoport <rppt@kernel.org>
> > Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Cc: Sam Ravnborg <sam@ravnborg.org>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
>
> Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
The ack is added in my commit, but I forgot to refresh the patch :-(
Thanks for noticing.
Sam
prev parent reply other threads:[~2020-12-08 20:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 18:21 [PATCH v4 0/1] sh: W=1 warning fixes in fbdev Sam Ravnborg
2020-12-08 18:21 ` [PATCH] sh: Fix set but not used warnings with !CONFIG_MMU Sam Ravnborg
2020-12-08 18:52 ` Thomas Zimmermann
2020-12-08 19:00 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201208190041.GA167310@ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=dalias@libc.org \
--cc=geert+renesas@glider.be \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lee.jones@linaro.org \
--cc=linux-sh@vger.kernel.org \
--cc=lkp@intel.com \
--cc=peterz@infradead.org \
--cc=rppt@kernel.org \
--cc=tzimmermann@suse.de \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.