From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9811C433FE for ; Tue, 8 Dec 2020 22:47:28 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C46A23AFE for ; Tue, 8 Dec 2020 22:47:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C46A23AFE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56504 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmllW-0004uf-VE for qemu-devel@archiver.kernel.org; Tue, 08 Dec 2020 17:47:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56984) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmlFM-0007r5-SN; Tue, 08 Dec 2020 17:14:12 -0500 Received: from mail.kernel.org ([198.145.29.99]:54266) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmlFK-0006Qz-KL; Tue, 08 Dec 2020 17:14:12 -0500 Date: Wed, 9 Dec 2020 07:14:05 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607465648; bh=Z6bKGKjOzobP1unjWY2K5UhTaqpw5zb1YIBIbiapQj4=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=dzAzqRPxh0yVNFog5/vzElJayeqGXLE9KNEtXf9whMzyIYn38tDEpfDCij5rwavqI IcOJ7gO83E6ipmSKP6y6izkObVgDFm6F0Wro5dx2e1gB2NMAdsypQO1anUK365VPGH xYl+7Hm6Q1MaIOn+99kwRH6gd0n+ylMyoVMq4UF4+cOI0d359nllLj+97kWZLdZeU/ O0yj8S6MB3/q1ZbbPgTqm7TUOV1/sWVdFpukcOfeZOC9lbGG+ok8PnWK+WnTuCI9Qv v0p7Wkdbw/8g1nbRloPbNS6n0SCn4BljHgM0itV46iDvVdLz6SOFXMSGhVWrhl3b02 um6zs0KzxOqxg== From: Keith Busch To: Klaus Jensen Subject: Re: [PATCH v2] hw/block/nvme: add compare command Message-ID: <20201208221405.GI27155@redsun51.ssa.fujisawa.hgst.com> References: <20201126185605.539311-1-its@irrelevant.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201126185605.539311-1-its@irrelevant.dk> User-Agent: Mutt/1.12.1 (2019-06-15) Received-SPF: pass client-ip=198.145.29.99; envelope-from=kbusch@kernel.org; helo=mail.kernel.org X-Spam_score_int: -70 X-Spam_score: -7.1 X-Spam_bar: ------- X-Spam_report: (-7.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, Klaus Jensen , Gollu Appalanaidu , qemu-devel@nongnu.org, Max Reitz , Minwoo Im Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Nov 26, 2020 at 07:56:05PM +0100, Klaus Jensen wrote: > From: Gollu Appalanaidu > > Add the Compare command. > > This implementation uses a bounce buffer to read in the data from > storage and then compare with the host supplied buffer. > > Signed-off-by: Gollu Appalanaidu > [k.jensen: rebased] > Signed-off-by: Klaus Jensen Looks good. Reviewed-by: Keith Busch