From: David Miller <davem@davemloft.net>
To: drt@linux.ibm.com
Cc: kuba@kernel.org, dnbanerg@us.ibm.com, ljp@linux.ibm.com,
sukadev@linux.ibm.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] ibmvnic: fix rx buffer tracking and index management in replenish_rx_pool partial success
Date: Wed, 09 Dec 2020 19:07:07 -0800 (PST) [thread overview]
Message-ID: <20201209.190707.1273769613807925702.davem@davemloft.net> (raw)
In-Reply-To: <20201210015331.44966-1-drt@linux.ibm.com>
From: Dany Madden <drt@linux.ibm.com>
Date: Wed, 9 Dec 2020 20:53:31 -0500
> From: "Dwip N. Banerjee" <dnbanerg@us.ibm.com>
>
> We observed that in the error case for batched send_subcrq_indirect() the
> driver does not account for the partial success case. This caused Linux to
> crash when free_map and pool index are inconsistent.
>
> Driver needs to update the rx pools "available" count when some batched
> sends worked but an error was encountered as part of the whole operation.
> Also track replenish_add_buff_failure for statistic purposes.
>
> Fixes: 4f0b6812e9b9a ("ibmvnic: Introduce batched RX buffer descriptor transmission")
> Signed-off-by: Dwip N. Banerjee <dnbanerg@us.ibm.com>
> Reviewed-by: Dany Madden <drt@linux.ibm.com>
Applied, thanks.
prev parent reply other threads:[~2020-12-10 3:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 1:53 [PATCH net-next] ibmvnic: fix rx buffer tracking and index management in replenish_rx_pool partial success Dany Madden
2020-12-10 3:07 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201209.190707.1273769613807925702.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dnbanerg@us.ibm.com \
--cc=drt@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=ljp@linux.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=sukadev@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.