From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BFC7C433FE for ; Wed, 9 Dec 2020 01:25:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1733A23B40 for ; Wed, 9 Dec 2020 01:25:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725804AbgLIBZH (ORCPT ); Tue, 8 Dec 2020 20:25:07 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:58449 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725791AbgLIBZH (ORCPT ); Tue, 8 Dec 2020 20:25:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607477021; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ks3Ply4N96m4k2H0dn1kKwtldUSUQfBTesh+Kzg2SfY=; b=QP4Y65M2xtnSp0GawFA8xDwy/C+Ktg9Gyvi4u3RzO09gbMo7s+t/sllOvjntgJtDWt12Hv 0LDmiuQLCpQJ7YN+YeRzTr9G5wR9CJq/sDWUU1ijJHaBB76YsP75C1TCKlcJILk+URlMHc Ah70duf0R443FCh888ztbbMoYmUzcJw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-15-8a_meGOmMGOcPRAitz_oJQ-1; Tue, 08 Dec 2020 20:23:39 -0500 X-MC-Unique: 8a_meGOmMGOcPRAitz_oJQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 89BB41005513; Wed, 9 Dec 2020 01:23:37 +0000 (UTC) Received: from T590 (ovpn-12-139.pek2.redhat.com [10.72.12.139]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EEBD660BE2; Wed, 9 Dec 2020 01:23:21 +0000 (UTC) Date: Wed, 9 Dec 2020 09:23:17 +0800 From: Ming Lei To: Christoph Hellwig Cc: Jens Axboe , Sagi Grimberg , Mike Snitzer , Oleksii Kurochko , Dongsheng Yang , linux-block@vger.kernel.org, dm-devel@redhat.com, linux-nvme@lists.infradead.org, "Martin K . Petersen" , Ilya Dryomov , ceph-devel@vger.kernel.org Subject: Re: [PATCH 4/6] block: propagate BLKROSET on the whole device to all partitions Message-ID: <20201209012317.GC1217988@T590> References: <20201207131918.2252553-1-hch@lst.de> <20201207131918.2252553-5-hch@lst.de> <20201208102923.GD1202995@T590> <20201208105927.GB21762@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201208105927.GB21762@lst.de> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Dec 08, 2020 at 11:59:27AM +0100, Christoph Hellwig wrote: > On Tue, Dec 08, 2020 at 06:29:23PM +0800, Ming Lei wrote: > > > - test_bit(GD_READ_ONLY, &bdev->bd_disk->state); > > > + return bdev->bd_read_only || get_disk_ro(bdev->bd_disk); > > > } > > > EXPORT_SYMBOL(bdev_read_only); > > > > I think this patch should be folded into previous one, otherwise > > bdev_read_only(part) may return false even though ioctl(BLKROSET) > > has been done on the whole disk. > > The above is the existing behavior going back back very far, and I feel > much more comfortable having a small self-contained patch that changes > this behavior. > OK, then looks fine: Reviewed-by: Ming Lei -- Ming From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0145FC4361B for ; Wed, 9 Dec 2020 01:23:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B5076239E5 for ; Wed, 9 Dec 2020 01:23:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5076239E5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=D05jiq+QTv/ZPytWlvf/TIl/5MJFpwUNPJ04QYlujSM=; b=pMizenxXg8ba32i53a8RizGpg YjUB8NgZrpW9LfEcZ4OB5MYxVnOcF3Z18PysGhUeU2O0635IaF/vZN4fyHIt1xQLG1JPPx4XctoLX 49MK5TlZ5AMB1rXZgwq4U9DqrFmnKLgul/2TEENYuM3CN+mFivbjx1ytYrk7taeHbTUX1mVctqamT 632r51pjreV4rwXnAtfFE9BH7YJQ85xmg7IOei4HMLiVuCqCNtLmPsd/1fKnzWanPAd9vcHeR/m9S Cn8THufi8kWdfbBqSnjsZfo0ZIv3ODMhuNOglq5Tc9Xz7DfhdYrebhsGtpbziZQQGJnLVPo5RSnxD pO+3sdNAw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmoCt-0003Jo-AP; Wed, 09 Dec 2020 01:23:51 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmoCq-0003IK-Bw for linux-nvme@lists.infradead.org; Wed, 09 Dec 2020 01:23:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607477023; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ks3Ply4N96m4k2H0dn1kKwtldUSUQfBTesh+Kzg2SfY=; b=Tw8sM9+hM2f7iJ5KgDLza4WdGVwL6z6GLtQ+ZfI4PoB0DTczEHGZ8sWt0OEwH/zJsFTlbu uEtPUEmYH1x7lK3Dlti6Wq8GzjR5HwyH5guHlhyPFV2oWhqyvMFvxOCpKo3/GsSJscXVsD zPaEwuL58Ka0KYjtet56oO5r5ymqLXo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-15-8a_meGOmMGOcPRAitz_oJQ-1; Tue, 08 Dec 2020 20:23:39 -0500 X-MC-Unique: 8a_meGOmMGOcPRAitz_oJQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 89BB41005513; Wed, 9 Dec 2020 01:23:37 +0000 (UTC) Received: from T590 (ovpn-12-139.pek2.redhat.com [10.72.12.139]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EEBD660BE2; Wed, 9 Dec 2020 01:23:21 +0000 (UTC) Date: Wed, 9 Dec 2020 09:23:17 +0800 From: Ming Lei To: Christoph Hellwig Subject: Re: [PATCH 4/6] block: propagate BLKROSET on the whole device to all partitions Message-ID: <20201209012317.GC1217988@T590> References: <20201207131918.2252553-1-hch@lst.de> <20201207131918.2252553-5-hch@lst.de> <20201208102923.GD1202995@T590> <20201208105927.GB21762@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201208105927.GB21762@lst.de> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201208_202348_467292_2E2325AE X-CRM114-Status: GOOD ( 17.13 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , Sagi Grimberg , Mike Snitzer , Oleksii Kurochko , Dongsheng Yang , linux-block@vger.kernel.org, dm-devel@redhat.com, linux-nvme@lists.infradead.org, "Martin K . Petersen" , Ilya Dryomov , ceph-devel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Tue, Dec 08, 2020 at 11:59:27AM +0100, Christoph Hellwig wrote: > On Tue, Dec 08, 2020 at 06:29:23PM +0800, Ming Lei wrote: > > > - test_bit(GD_READ_ONLY, &bdev->bd_disk->state); > > > + return bdev->bd_read_only || get_disk_ro(bdev->bd_disk); > > > } > > > EXPORT_SYMBOL(bdev_read_only); > > > > I think this patch should be folded into previous one, otherwise > > bdev_read_only(part) may return false even though ioctl(BLKROSET) > > has been done on the whole disk. > > The above is the existing behavior going back back very far, and I feel > much more comfortable having a small self-contained patch that changes > this behavior. > OK, then looks fine: Reviewed-by: Ming Lei -- Ming _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12137C433FE for ; Wed, 9 Dec 2020 01:23:52 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 988C0239E5 for ; Wed, 9 Dec 2020 01:23:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 988C0239E5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=dm-devel-bounces@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607477030; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=zZIckrZDMsPssxDVD/p2HhXGhXFasLkQGFKlzltkScM=; b=Akn9PGRI2QDlO3mo7x3JU7va0KpJ8ec/ar5+IXRTHTH64FcICQZXLsu561rQfq9BJqUexH IqKhqMHZAnShCDG1VblM8q6hElRzTLGZpXfUuKDOTpkZgTrLUBVrt5z72MK7ofDVmHU3/X 53UQqIsjs2/8y2ZZkPHNBA8C9gfk968= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-574-qwebvUjfOkOK0auRpOls8A-1; Tue, 08 Dec 2020 20:23:48 -0500 X-MC-Unique: qwebvUjfOkOK0auRpOls8A-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B999A180A089; Wed, 9 Dec 2020 01:23:43 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C136660BE2; Wed, 9 Dec 2020 01:23:42 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 297D84BB7B; Wed, 9 Dec 2020 01:23:40 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0B91NbVA006106 for ; Tue, 8 Dec 2020 20:23:37 -0500 Received: by smtp.corp.redhat.com (Postfix) id 8894260BF1; Wed, 9 Dec 2020 01:23:37 +0000 (UTC) Received: from T590 (ovpn-12-139.pek2.redhat.com [10.72.12.139]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EEBD660BE2; Wed, 9 Dec 2020 01:23:21 +0000 (UTC) Date: Wed, 9 Dec 2020 09:23:17 +0800 From: Ming Lei To: Christoph Hellwig Message-ID: <20201209012317.GC1217988@T590> References: <20201207131918.2252553-1-hch@lst.de> <20201207131918.2252553-5-hch@lst.de> <20201208102923.GD1202995@T590> <20201208105927.GB21762@lst.de> MIME-Version: 1.0 In-Reply-To: <20201208105927.GB21762@lst.de> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: dm-devel@redhat.com Cc: Jens Axboe , Sagi Grimberg , Mike Snitzer , Oleksii Kurochko , Dongsheng Yang , linux-block@vger.kernel.org, dm-devel@redhat.com, linux-nvme@lists.infradead.org, "Martin K . Petersen" , Ilya Dryomov , ceph-devel@vger.kernel.org Subject: Re: [dm-devel] [PATCH 4/6] block: propagate BLKROSET on the whole device to all partitions X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Dec 08, 2020 at 11:59:27AM +0100, Christoph Hellwig wrote: > On Tue, Dec 08, 2020 at 06:29:23PM +0800, Ming Lei wrote: > > > - test_bit(GD_READ_ONLY, &bdev->bd_disk->state); > > > + return bdev->bd_read_only || get_disk_ro(bdev->bd_disk); > > > } > > > EXPORT_SYMBOL(bdev_read_only); > > > > I think this patch should be folded into previous one, otherwise > > bdev_read_only(part) may return false even though ioctl(BLKROSET) > > has been done on the whole disk. > > The above is the existing behavior going back back very far, and I feel > much more comfortable having a small self-contained patch that changes > this behavior. > OK, then looks fine: Reviewed-by: Ming Lei -- Ming -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel