All of lore.kernel.org
 help / color / mirror / Atom feed
* [RESEND PATCH] PCI: qcom: Fix using uninitialized smmu_sid_base variable
@ 2020-12-09  2:45 Manivannan Sadhasivam
  0 siblings, 0 replies; only message in thread
From: Manivannan Sadhasivam @ 2020-12-09  2:45 UTC (permalink / raw)
  To: lorenzo.pieralisi
  Cc: agross, bjorn.andersson, svarbanov, bhelgaas, linux-arm-msm,
	linux-pci, linux-kernel, mgautam, truong, Manivannan Sadhasivam,
	kernel test robot

From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

smmu_sid_base should hold the base of SMMU SID extracted from the first
entry of iommu-map. This value will be used to extract the successive SMMU
SID values. Fix it by assigning the first SMMU SID base before for loop.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 drivers/pci/controller/dwc/pcie-qcom.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
index 8ba3e6b29196..affa2713bf80 100644
--- a/drivers/pci/controller/dwc/pcie-qcom.c
+++ b/drivers/pci/controller/dwc/pcie-qcom.c
@@ -1297,6 +1297,9 @@ static int qcom_pcie_config_sid_sm8250(struct qcom_pcie *pcie)
 	/* Registers need to be zero out first */
 	memset_io(bdf_to_sid_base, 0, CRC8_TABLE_SIZE * sizeof(u32));
 
+	/* Extract the SMMU SID base from the first entry of iommu-map */
+	smmu_sid_base = map[0].smmu_sid;
+
 	/* Look for an available entry to hold the mapping */
 	for (i = 0; i < nr_map; i++) {
 		u16 bdf_be = cpu_to_be16(map[i].bdf);
-- 
2.25.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2020-12-09  2:47 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-09  2:45 [RESEND PATCH] PCI: qcom: Fix using uninitialized smmu_sid_base variable Manivannan Sadhasivam

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.