All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <eguan@linux.alibaba.com>
To: Xiao Yang <yangx.jy@cn.fujitsu.com>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
	guaneryu@gmail.com, fstests@vger.kernel.org
Subject: Re: [PATCH 2/2] src/dmiperf: Stop using attr_setf
Date: Wed, 9 Dec 2020 12:22:49 +0800	[thread overview]
Message-ID: <20201209042249.GR80581@e18g06458.et15sqa> (raw)
In-Reply-To: <5FD02476.2040909@cn.fujitsu.com>

On Wed, Dec 09, 2020 at 09:12:22AM +0800, Xiao Yang wrote:
> On 2020/12/9 2:24, Darrick J. Wong wrote:
> >On Tue, Dec 08, 2020 at 02:40:05PM +0800, Xiao Yang wrote:
> >>Avoid the following warning by replacing deprecated
> >>attr_setf with fsetxattr:
> >>---------------------------------------------------
> >>dmiperf.c:192:2: warning: 'attr_setf' is deprecated: Use fsetxattr instead [-Wdeprecated-declarations]
> >>---------------------------------------------------
> >I frankly wonder if it's time to kill the DMI tests since I've never
> >seen it and none of the functionality is upstream.
> Hi Darrick,
> 
> Agreed.  I wanted to remove it yesterday but I am not sure if it
> will be used in future.
> 
> I will remove it directly in v2 patch if Eryu or anyone also approves it.

I agree to kill the dmi tests, because even xfs maintain wants to kill
them :)

Thanks,
Eryu

      reply	other threads:[~2020-12-09  4:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-08  6:40 [PATCH 1/2] src/multi_open_unlink: Stop using attr_set Xiao Yang
2020-12-08  6:40 ` [PATCH 2/2] src/dmiperf: Stop using attr_setf Xiao Yang
2020-12-08 18:24   ` Darrick J. Wong
2020-12-09  1:12     ` Xiao Yang
2020-12-09  4:22       ` Eryu Guan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201209042249.GR80581@e18g06458.et15sqa \
    --to=eguan@linux.alibaba.com \
    --cc=darrick.wong@oracle.com \
    --cc=fstests@vger.kernel.org \
    --cc=guaneryu@gmail.com \
    --cc=yangx.jy@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.