From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Gopal Tiwari <gtiwari@redhat.com>,
dmilburn@redhat.com, Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: Added QUIRK for Samsung PM1725a
Date: Wed, 9 Dec 2020 08:33:03 +0100 [thread overview]
Message-ID: <20201209073303.GA10205@lst.de> (raw)
In-Reply-To: <20201208191152.GD27155@redsun51.ssa.fujisawa.hgst.com>
On Wed, Dec 09, 2020 at 04:11:52AM +0900, Keith Busch wrote:
> On Tue, Dec 08, 2020 at 02:54:01PM +0100, Christoph Hellwig wrote:
> > On Tue, Dec 08, 2020 at 08:35:14AM -0500, Gopal Tiwari wrote:
> > > These are two different devices. Only one of the two NVME devices is seen. The other device is rejected due to “Duplicate cntlid”.
> >
> > So two card with one controller each, and both have the same subnqn.
> > Ok. I guess the quirk is exactly right in this case, although I would
> > not have expected this bug from an enterprise drive from a somewhat
> > reputable vendor.
>
> And it has CMIC capabilities! The quirk means we're using driver
> generated nqn's for multipath detection, so it won't work with
> multipath: the fake nqn uses the controller serial number, so all the
> controllers in the subsystem will get different nqn's.
SN is uniqueue for the whole subsystem:
"Contains the serial number for the NVM subsystem that isassigned by the
vendor as an ASCII string."
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-12-09 7:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 16:16 [PATCH] nvme: Added QUIRK for Samsung PM1725a Gopal Tiwari
2020-12-07 14:04 ` Christoph Hellwig
2020-12-08 13:28 ` Gopal Tiwari
2020-12-08 13:29 ` Christoph Hellwig
2020-12-08 13:35 ` Gopal Tiwari
2020-12-08 13:54 ` Christoph Hellwig
2020-12-08 19:11 ` Keith Busch
2020-12-09 7:33 ` Christoph Hellwig [this message]
2020-12-08 14:04 ` Christoph Hellwig
2020-12-08 14:16 ` Gopal Tiwari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201209073303.GA10205@lst.de \
--to=hch@lst.de \
--cc=dmilburn@redhat.com \
--cc=gtiwari@redhat.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.