From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19828C1B0D8 for ; Wed, 9 Dec 2020 09:51:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CC74823B79 for ; Wed, 9 Dec 2020 09:51:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729597AbgLIJvN (ORCPT ); Wed, 9 Dec 2020 04:51:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729571AbgLIJuu (ORCPT ); Wed, 9 Dec 2020 04:50:50 -0500 Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3F9EC061285 for ; Wed, 9 Dec 2020 01:49:37 -0800 (PST) Received: by mail-pj1-x1041.google.com with SMTP id l23so612889pjg.1 for ; Wed, 09 Dec 2020 01:49:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PrCTAg81K8KnVj0cwCcOSdceG5jg9Rol6nxvrFRqC7s=; b=aqQDQl6MRjWwoP2yw4T8/K3BRlu3VlimxLymxRpw6oZ2TIBzSNeg6cCnFH7tWWJMdg 0asBiYxpTxfD/nW01e/qQlpBO25LWiWIA6VbQ5iCmTk75sT85lwAOWo4Y+Zk59CUPxz9 bRhTHfv3Ed+m1BOFXV6Paijjxg2HJtWMz7aaGOtyt4yQ9e+zWwqFacDq2tcWlktp2Y/6 9OE5FEu1uN3nTV5X7m0+jrLNs+NOCpk2SfimO0JSlk0KM6VD3s2LBTHzGanhCAu8LlDQ qnSSWoe6ogW0CCw0pUGaMPenl6ZnVAOhEZIyMMJ/Axb9MlUi8DWqGfrgPSctp7pInxzk fAmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PrCTAg81K8KnVj0cwCcOSdceG5jg9Rol6nxvrFRqC7s=; b=oZnBZMP0XJ2eCdiiBk81WXxOv4888wz9QVDqrviQuK9sGc21/4d9vWXmBaqjAHsMhY NPHsOPAW8lTxi2zMQYxmVrP/5OSYdf9ETDDRSrscnAErl0iwqYPGECoCmwlw2Sg52jNB b9RbaOSz3LPDNAyg1Qv6J4ppabLlGSrgTE21cJCXVRjq+Wcsj/UpCwr7mP50zixysmAk M4OHRKjHgk0q3NVt/mEXqW+g8JRvqcQgUr4A936R7ydYQhfsm18+6RKF4JU+zAFlBxOa /rU9CqOzZ361d3O94ku0z8ZjpMF9lq71dqadix+AJ476jVkgo303/WJ6/C/+QZ7/HPJe rNHQ== X-Gm-Message-State: AOAM5313FaRFVGcm5Pp+6N+8UuKxOOWe0D467fHHrumdC+IFZIc/LXZA re1aw7d1gBHLPUSkR3VZG4B7ew== X-Google-Smtp-Source: ABdhPJyrwB5UR6zn1ToVfsm2FNS047MMOHPkD6Jq+cWszUtiT4M68q2Zgdzn5wo1XzVbdMyoKARRvw== X-Received: by 2002:a17:90b:b0d:: with SMTP id bf13mr1471187pjb.194.1607507377289; Wed, 09 Dec 2020 01:49:37 -0800 (PST) Received: from hsinchu02.internal.sifive.com (114-34-229-221.HINET-IP.hinet.net. [114.34.229.221]) by smtp.gmail.com with ESMTPSA id 129sm1890354pfw.86.2020.12.09.01.49.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Dec 2020 01:49:36 -0800 (PST) From: Zong Li To: paul.walmsley@sifive.com, palmer@dabbelt.com, sboyd@kernel.org, schwab@linux-m68k.org, pragnesh.patel@openfive.com, aou@eecs.berkeley.edu, mturquette@baylibre.com, yash.shah@sifive.com, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-riscv@lists.infradead.org Cc: Zong Li , Pragnesh Patel Subject: [PATCH v7 4/5] clk: sifive: Fix the wrong bit field shift Date: Wed, 9 Dec 2020 17:49:15 +0800 Message-Id: <20201209094916.17383-5-zong.li@sifive.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201209094916.17383-1-zong.li@sifive.com> References: <20201209094916.17383-1-zong.li@sifive.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The clk enable bit should be 31 instead of 24. Signed-off-by: Zong Li Reported-by: Pragnesh Patel --- drivers/clk/sifive/sifive-prci.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/sifive/sifive-prci.h b/drivers/clk/sifive/sifive-prci.h index 7e509dfb72d1..88493f3b9edf 100644 --- a/drivers/clk/sifive/sifive-prci.h +++ b/drivers/clk/sifive/sifive-prci.h @@ -59,7 +59,7 @@ /* DDRPLLCFG1 */ #define PRCI_DDRPLLCFG1_OFFSET 0x10 -#define PRCI_DDRPLLCFG1_CKE_SHIFT 24 +#define PRCI_DDRPLLCFG1_CKE_SHIFT 31 #define PRCI_DDRPLLCFG1_CKE_MASK (0x1 << PRCI_DDRPLLCFG1_CKE_SHIFT) /* GEMGXLPLLCFG0 */ @@ -81,7 +81,7 @@ /* GEMGXLPLLCFG1 */ #define PRCI_GEMGXLPLLCFG1_OFFSET 0x20 -#define PRCI_GEMGXLPLLCFG1_CKE_SHIFT 24 +#define PRCI_GEMGXLPLLCFG1_CKE_SHIFT 31 #define PRCI_GEMGXLPLLCFG1_CKE_MASK (0x1 << PRCI_GEMGXLPLLCFG1_CKE_SHIFT) /* CORECLKSEL */ -- 2.29.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92ABEC433FE for ; Wed, 9 Dec 2020 09:49:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3861423B7D for ; Wed, 9 Dec 2020 09:49:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3861423B7D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WyxgudMpNNuw7KopipeTuqUHWX4OLx5VBDyQBlXY3o0=; b=HRaDNbHYFDOkgrQF0kEBjkuR+ gSZBT8kN0fvogqmnPCZfPFshrygg2Mrp8GKGMM54kLtzTqmXcoF0txhoYYcJxUnBqYDefGddGSXMQ aLluv725f+LBVQxHicN9pu1DlFUjL/82r/mEigGCveISuuE1NEgv0O/uiGc0h5MouB5+yWDBRQx4n 0IGew6iJxR8zEPUbD6h8walKTiJ8erGwF7HtIDhbvjV2X/0iKRME9YP4NtnV4SvaQw1T+9UXpgWzn WRqxoh0v39c/o51pBqkInpyCiT3JVX8OaYDckI5/eV2OlGHg+ut8bXeIGDYr8DFkQR3Gc5EdSy928 QxuAPBfhA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmw6O-0005t9-Qu; Wed, 09 Dec 2020 09:49:40 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmw6M-0005rz-Sj for linux-riscv@lists.infradead.org; Wed, 09 Dec 2020 09:49:39 +0000 Received: by mail-pl1-x641.google.com with SMTP id t18so663725plo.0 for ; Wed, 09 Dec 2020 01:49:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PrCTAg81K8KnVj0cwCcOSdceG5jg9Rol6nxvrFRqC7s=; b=aqQDQl6MRjWwoP2yw4T8/K3BRlu3VlimxLymxRpw6oZ2TIBzSNeg6cCnFH7tWWJMdg 0asBiYxpTxfD/nW01e/qQlpBO25LWiWIA6VbQ5iCmTk75sT85lwAOWo4Y+Zk59CUPxz9 bRhTHfv3Ed+m1BOFXV6Paijjxg2HJtWMz7aaGOtyt4yQ9e+zWwqFacDq2tcWlktp2Y/6 9OE5FEu1uN3nTV5X7m0+jrLNs+NOCpk2SfimO0JSlk0KM6VD3s2LBTHzGanhCAu8LlDQ qnSSWoe6ogW0CCw0pUGaMPenl6ZnVAOhEZIyMMJ/Axb9MlUi8DWqGfrgPSctp7pInxzk fAmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PrCTAg81K8KnVj0cwCcOSdceG5jg9Rol6nxvrFRqC7s=; b=e/GGqIRe3+d+BSwI2cbL9/ekuKEsHV0mVkPy9nuLMy/1y3JhydYpuWXrTyxkNtUvp5 qdRQwhlLvwVSFTlQ3d3SXmWU4LdALTuLtaKHQ4vzaWqfXva6qHnWKOVHzkASWvgjq2H7 PqbbctNKxea0lrspdpR/l0FgLVN9se0PDlsA4yGDOSsLcNJYmWwE3gMy3nTSsMn7dRAZ ChzM4lvpAqpw1dULK+5VKTLnrQ+PoQ44f2gy186Im+8DebC4ApVtTnrcn5Uvno0jj9H6 U85HnkvL4f9ZvyC9FM4j3lk+D46o7KTxiQG55wF1JgO5YMvkSVJ4/nS7LMXWKXXaVrKV SDqA== X-Gm-Message-State: AOAM530JpcUN7ZCpJ7DqdAgGMa2fWbcO+GHwN5ppMtpLKUId5gjoPCML 5gM2gyJER07cXDcAugAwiX4L5A== X-Google-Smtp-Source: ABdhPJyrwB5UR6zn1ToVfsm2FNS047MMOHPkD6Jq+cWszUtiT4M68q2Zgdzn5wo1XzVbdMyoKARRvw== X-Received: by 2002:a17:90b:b0d:: with SMTP id bf13mr1471187pjb.194.1607507377289; Wed, 09 Dec 2020 01:49:37 -0800 (PST) Received: from hsinchu02.internal.sifive.com (114-34-229-221.HINET-IP.hinet.net. [114.34.229.221]) by smtp.gmail.com with ESMTPSA id 129sm1890354pfw.86.2020.12.09.01.49.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Dec 2020 01:49:36 -0800 (PST) From: Zong Li To: paul.walmsley@sifive.com, palmer@dabbelt.com, sboyd@kernel.org, schwab@linux-m68k.org, pragnesh.patel@openfive.com, aou@eecs.berkeley.edu, mturquette@baylibre.com, yash.shah@sifive.com, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-riscv@lists.infradead.org Subject: [PATCH v7 4/5] clk: sifive: Fix the wrong bit field shift Date: Wed, 9 Dec 2020 17:49:15 +0800 Message-Id: <20201209094916.17383-5-zong.li@sifive.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201209094916.17383-1-zong.li@sifive.com> References: <20201209094916.17383-1-zong.li@sifive.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201209_044939_014333_C37693A6 X-CRM114-Status: GOOD ( 10.30 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pragnesh Patel , Zong Li Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org The clk enable bit should be 31 instead of 24. Signed-off-by: Zong Li Reported-by: Pragnesh Patel --- drivers/clk/sifive/sifive-prci.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/sifive/sifive-prci.h b/drivers/clk/sifive/sifive-prci.h index 7e509dfb72d1..88493f3b9edf 100644 --- a/drivers/clk/sifive/sifive-prci.h +++ b/drivers/clk/sifive/sifive-prci.h @@ -59,7 +59,7 @@ /* DDRPLLCFG1 */ #define PRCI_DDRPLLCFG1_OFFSET 0x10 -#define PRCI_DDRPLLCFG1_CKE_SHIFT 24 +#define PRCI_DDRPLLCFG1_CKE_SHIFT 31 #define PRCI_DDRPLLCFG1_CKE_MASK (0x1 << PRCI_DDRPLLCFG1_CKE_SHIFT) /* GEMGXLPLLCFG0 */ @@ -81,7 +81,7 @@ /* GEMGXLPLLCFG1 */ #define PRCI_GEMGXLPLLCFG1_OFFSET 0x20 -#define PRCI_GEMGXLPLLCFG1_CKE_SHIFT 24 +#define PRCI_GEMGXLPLLCFG1_CKE_SHIFT 31 #define PRCI_GEMGXLPLLCFG1_CKE_MASK (0x1 << PRCI_GEMGXLPLLCFG1_CKE_SHIFT) /* CORECLKSEL */ -- 2.29.2 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv