From: Christoph Hellwig <hch@infradead.org>
To: Pavel Begunkov <asml.silence@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Jens Axboe <axboe@kernel.dk>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Matthew Wilcox <willy@infradead.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Ming Lei <ming.lei@redhat.com>
Subject: Re: [PATCH 2/2] block: no-copy bvec for direct IO
Date: Wed, 9 Dec 2020 12:05:31 +0000 [thread overview]
Message-ID: <20201209120531.GA9598@infradead.org> (raw)
In-Reply-To: <63057f61-85e5-4720-3532-1a1ba05ab41a@gmail.com>
On Wed, Dec 09, 2020 at 12:01:27PM +0000, Pavel Begunkov wrote:
> On 09/12/2020 08:40, Christoph Hellwig wrote:
> >> + /*
> >> + * In practice groups of pages tend to be accessed/reclaimed/refaulted
> >> + * together. To not go over bvec for those who didn't set BIO_WORKINGSET
> >> + * approximate it by looking at the first page and inducing it to the
> >> + * whole bio
> >> + */
> >> + if (unlikely(PageWorkingset(iter->bvec->bv_page)))
> >> + bio_set_flag(bio, BIO_WORKINGSET);
> >
> > IIRC the feedback was that we do not need to deal with BIO_WORKINGSET
> > at all for direct I/O.
>
> I was waiting for the conversation to unfold, i.e. for Johannes to
> answer. BTW, would the same (skipping BIO_WORKINGSET) stand true for
> iomap?
iomap direct I/O: yes.
next prev parent reply other threads:[~2020-12-09 12:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 2:19 [RFC 0/2] nocopy bvec for direct IO Pavel Begunkov
2020-12-09 2:19 ` [PATCH 1/2] iov: introduce ITER_BVEC_FLAG_FIXED Pavel Begunkov
2020-12-09 8:36 ` Christoph Hellwig
2020-12-09 9:06 ` Christoph Hellwig
2020-12-09 11:54 ` Pavel Begunkov
2020-12-09 13:07 ` Al Viro
2020-12-09 13:37 ` Pavel Begunkov
2020-12-09 17:55 ` Christoph Hellwig
2020-12-09 18:24 ` Matthew Wilcox
2020-12-13 22:09 ` Pavel Begunkov
2020-12-09 2:19 ` [PATCH 2/2] block: no-copy bvec for direct IO Pavel Begunkov
2020-12-09 8:40 ` Christoph Hellwig
2020-12-09 12:01 ` Pavel Begunkov
2020-12-09 12:05 ` Christoph Hellwig [this message]
2020-12-09 12:03 ` Pavel Begunkov
2020-12-11 14:06 ` Johannes Weiner
2020-12-11 14:20 ` Pavel Begunkov
2020-12-11 15:38 ` Johannes Weiner
2020-12-11 15:47 ` Pavel Begunkov
2020-12-11 16:13 ` Johannes Weiner
2020-12-09 21:13 ` David Laight
2020-12-09 6:50 ` [RFC 0/2] nocopy " Christoph Hellwig
2020-12-09 11:54 ` Pavel Begunkov
2020-12-09 16:53 ` Jens Axboe
2020-12-13 22:03 ` Pavel Begunkov
2020-12-09 17:06 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201209120531.GA9598@infradead.org \
--to=hch@infradead.org \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=hannes@cmpxchg.org \
--cc=io-uring@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.