From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D2EBC4361B for ; Wed, 9 Dec 2020 16:40:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1653123BDF for ; Wed, 9 Dec 2020 16:40:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729635AbgLIQk3 (ORCPT ); Wed, 9 Dec 2020 11:40:29 -0500 Received: from mail-oi1-f194.google.com ([209.85.167.194]:36413 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726227AbgLIQk3 (ORCPT ); Wed, 9 Dec 2020 11:40:29 -0500 Received: by mail-oi1-f194.google.com with SMTP id x16so2365990oic.3; Wed, 09 Dec 2020 08:40:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FocGLexWGAbPIltwYbZRe/myrDdStcHxJvLxzUzr35E=; b=OToxeQqSANfULIjF8Q5omwuqFh//7incHl9BsFByt4gdzibXue8LWmK74e7OCUCuRZ T4OwltqsTrif2eOyk9vx3Ycof9XT8+Uw6NEA54P0S/6cVqRjJRGXYsfLaYZX97caIGq7 jPqUn27pIkIH6TB0igpAoo4DBNCbRxeVxvFuk7VrPCfqaRwJ2OrU63RHY5uPdvA+DsSJ xE8/GO7lhylRw5/Bmra43vr+lLTKt4GfW95gjKBR8rU0CSVYgvNraLqTRVB584ThMItx 89liumN++R2qQ9BfkrnVzoUTHRUjjFNDyPsr5pg5hAeQCK/E/ypDmkQrihXZptN0mAqj vtzg== X-Gm-Message-State: AOAM532VmtgINNke2XvpciZoWdzFFgAV5kRbL218sPKZZGVx3eON14C4 mjTHaPWtFFzlv+cT3C5+wA== X-Google-Smtp-Source: ABdhPJz4cfCCgnE1x+yTrKorMizmKZCIJU5rV5EqmIQdFKa8GGCmyCcCeXu8B4SZzCSeoqvaPbPCzA== X-Received: by 2002:aca:504e:: with SMTP id e75mr2436452oib.170.1607531988076; Wed, 09 Dec 2020 08:39:48 -0800 (PST) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id y18sm414349ooj.20.2020.12.09.08.39.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Dec 2020 08:39:47 -0800 (PST) Received: (nullmailer pid 575032 invoked by uid 1000); Wed, 09 Dec 2020 16:39:45 -0000 Date: Wed, 9 Dec 2020 10:39:45 -0600 From: Rob Herring To: Punit Agrawal Cc: Nobuhiro Iwamatsu , Linus Walleij , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, yuji2.ishikawa@toshiba.co.jp, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 1/4] dt-bindings: gpio: Add bindings for Toshiba Visconti GPIO Controller Message-ID: <20201209163945.GA570905@robh.at.kernel.org> References: <20201201181406.2371881-1-nobuhiro1.iwamatsu@toshiba.co.jp> <20201201181406.2371881-2-nobuhiro1.iwamatsu@toshiba.co.jp> <87sg8n483w.fsf@kokedama.swc.toshiba.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87sg8n483w.fsf@kokedama.swc.toshiba.co.jp> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, Dec 03, 2020 at 05:16:51PM +0900, Punit Agrawal wrote: > Iwamatsu-san, > > Nobuhiro Iwamatsu writes: > > > Add bindings for the Toshiba Visconti GPIO Controller. > > > > Signed-off-by: Nobuhiro Iwamatsu > > --- > > .../bindings/gpio/toshiba,gpio-visconti.yaml | 85 +++++++++++++++++++ > > 1 file changed, 85 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml > > > > diff --git a/Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml b/Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml > > new file mode 100644 > > index 000000000000..5168a15b90e1 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml > > @@ -0,0 +1,85 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/gpio/toshiba,gpio-visconti.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Toshiba Visconti ARM SoCs GPIO controller > > + > > +maintainers: > > + - Nobuhiro Iwamatsu > > + > > +properties: > > + compatible: > > + items: > > + - const: toshiba,gpio-tmpv7708 > > + > > + reg: > > + maxItems: 1 > > + > > + "#gpio-cells": > > + const: 2 > > + > > + gpio-ranges: true > > I am not sure I have a good handle on the yaml schema definitions but > "gpio-ranges" feels like it should be a list of ranges not a boolean. > > Something like - > > gpio-ranges: > maxItems: 1 > > feels more appropriate. > > I see both the usages in gpio bindings and for other range properties so > maybe it's OK. I hope Rob or somebody more knowledgeable on this can > clarify the usage. If you know how many (or a range) entries there are for gpio-ranges, then maxItems is good. If you don't, then 'gpio-ranges: true' is fine. That doesn't make the property a boolean, but just says the property can be present. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5982AC4361B for ; Wed, 9 Dec 2020 16:41:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0CC0123BE0 for ; Wed, 9 Dec 2020 16:41:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0CC0123BE0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WG3JVLdd11BKm6YIwrqXrGrG+cRfVvQOdXTetRMXa2o=; b=GM/s1WlgyHn3nO68XZAFwvBST hdk8EPNITxmXK6zluw/k0Kjd1gEZ2FSDfTl50NHYkOvPQw5f8DKBs8JxI1gepPmpMnpNMBVwuOaBe 2Qf7ixIaqhBSpHuWP0IBZs2B5/baAN4aieT333jsoZ8Hyelj7V1cYVDIXmBj2U/uQXHj6d0NwjPHo y45JjCzPsV5FP33LnHLGJCWoRrdbQNFDXQLPcyIuKUtUt/temwbrm7pI0C1/HFowRaOIizxsdQtB8 GYBQg5x6/eRQg5fsPUxLAFSw+4hCnmegmL5SomQ1BhO7eoCrwb2/ZMF+4PwNGo9tvhjAQ6GMOH5yf g0QjKq7ag==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kn2VS-0000ZR-FV; Wed, 09 Dec 2020 16:39:58 +0000 Received: from mail-oi1-f194.google.com ([209.85.167.194]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kn2VM-0000Xr-Hr for linux-arm-kernel@lists.infradead.org; Wed, 09 Dec 2020 16:39:56 +0000 Received: by mail-oi1-f194.google.com with SMTP id l200so2338517oig.9 for ; Wed, 09 Dec 2020 08:39:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FocGLexWGAbPIltwYbZRe/myrDdStcHxJvLxzUzr35E=; b=CjSlXy8XMEiNS7fU4xXTHH7iZFDD1BAiwgqJ39VZxXXNwkw6HRgv5axe7kiwNRA94Y qiwyNP1jMgU7dOC5B4rQOSO4axZJ5+ESqAt/25s6SGNDPFZHaJs1yr9cC2gP4BGusxIt MIZlwXQGAQx6ivdutdXLKPIAjRFhyp1bAm9ywGpK66OkTffiJ8h9IiDANc/1l8zI3d5i hiAh4yNShfjLAXKevko9whyTBItiSZiays17MUg+Xuefi3UgrMZtrK12W+gwxOgQv024 MwyuHXEBAC+I/c+ntgfihfqiL65DrGmI84AFX9PyROiFBbL19QKUqTOMV6d4KJQSE1jU 2PdA== X-Gm-Message-State: AOAM533EWo8bAKQGY8ii1tfkNKUlb1lRjs24a16gTb0DZT+/V/gFcj2O lK6y+wmQe0wSZb4G7W03KRMGlsvKVA== X-Google-Smtp-Source: ABdhPJz4cfCCgnE1x+yTrKorMizmKZCIJU5rV5EqmIQdFKa8GGCmyCcCeXu8B4SZzCSeoqvaPbPCzA== X-Received: by 2002:aca:504e:: with SMTP id e75mr2436452oib.170.1607531988076; Wed, 09 Dec 2020 08:39:48 -0800 (PST) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id y18sm414349ooj.20.2020.12.09.08.39.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Dec 2020 08:39:47 -0800 (PST) Received: (nullmailer pid 575032 invoked by uid 1000); Wed, 09 Dec 2020 16:39:45 -0000 Date: Wed, 9 Dec 2020 10:39:45 -0600 From: Rob Herring To: Punit Agrawal Subject: Re: [PATCH v3 1/4] dt-bindings: gpio: Add bindings for Toshiba Visconti GPIO Controller Message-ID: <20201209163945.GA570905@robh.at.kernel.org> References: <20201201181406.2371881-1-nobuhiro1.iwamatsu@toshiba.co.jp> <20201201181406.2371881-2-nobuhiro1.iwamatsu@toshiba.co.jp> <87sg8n483w.fsf@kokedama.swc.toshiba.co.jp> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87sg8n483w.fsf@kokedama.swc.toshiba.co.jp> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201209_113952_610388_1DF069A3 X-CRM114-Status: GOOD ( 21.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Linus Walleij , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Nobuhiro Iwamatsu , yuji2.ishikawa@toshiba.co.jp, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Dec 03, 2020 at 05:16:51PM +0900, Punit Agrawal wrote: > Iwamatsu-san, > > Nobuhiro Iwamatsu writes: > > > Add bindings for the Toshiba Visconti GPIO Controller. > > > > Signed-off-by: Nobuhiro Iwamatsu > > --- > > .../bindings/gpio/toshiba,gpio-visconti.yaml | 85 +++++++++++++++++++ > > 1 file changed, 85 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml > > > > diff --git a/Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml b/Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml > > new file mode 100644 > > index 000000000000..5168a15b90e1 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml > > @@ -0,0 +1,85 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/gpio/toshiba,gpio-visconti.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Toshiba Visconti ARM SoCs GPIO controller > > + > > +maintainers: > > + - Nobuhiro Iwamatsu > > + > > +properties: > > + compatible: > > + items: > > + - const: toshiba,gpio-tmpv7708 > > + > > + reg: > > + maxItems: 1 > > + > > + "#gpio-cells": > > + const: 2 > > + > > + gpio-ranges: true > > I am not sure I have a good handle on the yaml schema definitions but > "gpio-ranges" feels like it should be a list of ranges not a boolean. > > Something like - > > gpio-ranges: > maxItems: 1 > > feels more appropriate. > > I see both the usages in gpio bindings and for other range properties so > maybe it's OK. I hope Rob or somebody more knowledgeable on this can > clarify the usage. If you know how many (or a range) entries there are for gpio-ranges, then maxItems is good. If you don't, then 'gpio-ranges: true' is fine. That doesn't make the property a boolean, but just says the property can be present. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel