All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Song Liu <songliubraving@fb.com>
Cc: linux-kernel@vger.kernel.org, kernel-team@fb.com,
	peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com,
	alexander.shishkin@linux.intel.com, jolsa@redhat.com,
	namhyung@kernel.org
Subject: Re: [PATCH v3 0/2] Introduce perf-stat -b for BPF programs
Date: Wed, 9 Dec 2020 14:36:23 -0300	[thread overview]
Message-ID: <20201209173623.GA185686@kernel.org> (raw)
In-Reply-To: <20201208181646.3044417-1-songliubraving@fb.com>

Em Tue, Dec 08, 2020 at 10:16:44AM -0800, Song Liu escreveu:
> This set introduces perf-stat -b option to count events for BPF programs.
> This is similar to bpftool-prog-profile. But perf-stat makes it much more
> flexible.
> 
> Changes v2 => v3:
>   1. Small fixes in Makefile.perf and bpf_counter.c (Jiri)
>   2. Rebased on top of bpf-next. This is because 1/2 conflicts with some
>      patches in bpftool/Makefile.

Can't you split that up so that I can process the perf part and the
bpftool goes via the bpf-next tree?

- Arnaldo
 
> Changes PATCH v1 => PATCH v2:
>   1. Various fixes in Makefiles. (Jiri)
>   2. Fix an build warning/error with gcc-10. (Jiri)
> 
> Changes RFC v2 => PATCH v1:
>   1. Support counting on multiple BPF programs.
>   2. Add BPF handling to target__validate().
>   3. Improve Makefile. (Jiri)
> 
> Changes RFC v1 => RFC v2:
>   1. Use bootstrap version of bpftool. (Jiri)
>   2. Set default to not building bpf skeletons. (Jiri)
>   3. Remove util/bpf_skel/Makefile, keep all the logic in Makefile.perf.
>      (Jiri)
>   4. Remove dependency to vmlinux.h in the two skeletons. The goal here is
>      to enable building perf without building kernel (vmlinux) first.
>      Note: I also removed the logic that build vmlinux.h. We can add that
>      back when we have to use it (to access big kernel structures).
> 
> Song Liu (2):
>   perf: support build BPF skeletons with perf
>   perf-stat: enable counting events for BPF programs
> 
>  tools/bpf/bpftool/Makefile                    |   3 +
>  tools/build/Makefile.feature                  |   4 +-
>  tools/perf/Makefile.config                    |   9 +
>  tools/perf/Makefile.perf                      |  48 ++-
>  tools/perf/builtin-stat.c                     |  77 ++++-
>  tools/perf/util/Build                         |   1 +
>  tools/perf/util/bpf_counter.c                 | 297 ++++++++++++++++++
>  tools/perf/util/bpf_counter.h                 |  73 +++++
>  tools/perf/util/bpf_skel/.gitignore           |   3 +
>  .../util/bpf_skel/bpf_prog_profiler.bpf.c     |  93 ++++++
>  tools/perf/util/evsel.c                       |  11 +
>  tools/perf/util/evsel.h                       |   6 +
>  tools/perf/util/stat-display.c                |   4 +-
>  tools/perf/util/target.c                      |  34 +-
>  tools/perf/util/target.h                      |  10 +
>  tools/scripts/Makefile.include                |   1 +
>  16 files changed, 655 insertions(+), 19 deletions(-)
>  create mode 100644 tools/perf/util/bpf_counter.c
>  create mode 100644 tools/perf/util/bpf_counter.h
>  create mode 100644 tools/perf/util/bpf_skel/.gitignore
>  create mode 100644 tools/perf/util/bpf_skel/bpf_prog_profiler.bpf.c
> 
> --
> 2.24.1

-- 

- Arnaldo

  parent reply	other threads:[~2020-12-09 17:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-08 18:16 [PATCH v3 0/2] Introduce perf-stat -b for BPF programs Song Liu
2020-12-08 18:16 ` [PATCH v3 1/2] perf: support build BPF skeletons with perf Song Liu
2020-12-09 17:03   ` Jiri Olsa
2020-12-09 23:32     ` Song Liu
2020-12-08 18:16 ` [PATCH v3 2/2] perf-stat: enable counting events for BPF programs Song Liu
2020-12-09 17:03   ` Jiri Olsa
2020-12-10  0:15     ` Song Liu
2020-12-13 22:34       ` Jiri Olsa
2020-12-09 17:36 ` Arnaldo Carvalho de Melo [this message]
2020-12-09 23:30   ` [PATCH v3 0/2] Introduce perf-stat -b " Song Liu
2020-12-10  0:32     ` Song Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201209173623.GA185686@kernel.org \
    --to=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@redhat.com \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=songliubraving@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.