From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1kn3RU-0008Nr-Vt
	for mharc-grub-devel@gnu.org; Wed, 09 Dec 2020 12:39:56 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:45138)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <dkiper@net-space.pl>)
 id 1kn3RS-0008Gj-7N
 for grub-devel@gnu.org; Wed, 09 Dec 2020 12:39:54 -0500
Received: from dibed.net-space.pl ([84.10.22.86]:47366)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_3DES_EDE_CBC_SHA1:192)
 (Exim 4.90_1) (envelope-from <dkiper@net-space.pl>)
 id 1kn3RQ-0006SV-DT
 for grub-devel@gnu.org; Wed, 09 Dec 2020 12:39:53 -0500
Received: from router-fw.i.net-space.pl ([192.168.52.1]:59334 "EHLO
 tomti.i.net-space.pl") by router-fw-old.i.net-space.pl with ESMTP
 id S171334AbgLIRjm (ORCPT <rfc822;grub-devel@gnu.org>);
 Wed, 9 Dec 2020 18:39:42 +0100
X-Comment: RFC 2476 MSA function at dibed.net-space.pl logged sender identity
 as: dkiper
Date: Wed, 9 Dec 2020 18:39:34 +0100
From: Daniel Kiper <dkiper@net-space.pl>
To: Glenn Washburn <development@efficientek.com>
Cc: grub-devel@gnu.org, Patrick Steinhardt <ps@pks.im>
Subject: Re: [PATCH v8 01/18] disk: Rename grub_disk_get_size to
 grub_disk_native_sectors
Message-ID: <20201209173934.uelja2qhmabva7oo@tomti.i.net-space.pl>
References: <cover.1604723348.git.development@efficientek.com>
 <cover.1607466704.git.development@efficientek.com>
 <f4062e4f6cd05c2cae84257a0ebd34fa2c413ce3.1607466704.git.development@efficientek.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f4062e4f6cd05c2cae84257a0ebd34fa2c413ce3.1607466704.git.development@efficientek.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Received-SPF: pass client-ip=84.10.22.86; envelope-from=dkiper@net-space.pl;
 helo=dibed.net-space.pl
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: The development of GNU GRUB <grub-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/grub-devel>,
 <mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/grub-devel>,
 <mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Dec 2020 17:39:54 -0000

On Tue, Dec 08, 2020 at 04:45:32PM -0600, Glenn Washburn wrote:
> The function grub_disk_get_size is confusingly named because it actually
> returns a sector count where the sectors are sized in the grub native sector
> size. Rename to something more appropriate.
>
> Signed-off-by: Glenn Washburn <development@efficientek.com>
> Suggested-by: Daniel Kiper <daniel.kiper@oracle.com>
> Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
> Reviewed-by: Patrick Steinhardt <ps@pks.im>

The proper order is:

Suggested-by: Daniel Kiper <daniel.kiper@oracle.com>
Signed-off-by: Glenn Washburn <development@efficientek.com>
Reviewed-by: Patrick Steinhardt <ps@pks.im>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

First I suggested the patch, you wrote it, Patrick reviewed the patch
and finally I did it.

I will fix it before committing.

Daniel