From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F49DC4361B for ; Thu, 10 Dec 2020 02:37:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C261D23B77 for ; Thu, 10 Dec 2020 02:37:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729022AbgLJChF (ORCPT ); Wed, 9 Dec 2020 21:37:05 -0500 Received: from mail.kernel.org ([198.145.29.99]:41792 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726534AbgLJChF (ORCPT ); Wed, 9 Dec 2020 21:37:05 -0500 Date: Wed, 9 Dec 2020 18:36:23 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1607567785; bh=XvfNSBjtRQDwTQaWQYMVMSpT8H8nutp1mjAcQR7vP6Q=; h=From:To:Cc:Subject:In-Reply-To:References:From; b=Z9i631HDe1R5jmoeOhXA3++25nKEC+BRYA5F0FDi7zEdV8m6hVveolSt2t+AYiDeb BrIfrbaAFU1attLpFoEnDkLbBp9A5TZCZpr0T6wTmAKOx7vq23trf36rOisG3LCu4g Iiw2tgeTCsbq69cGwJD84zvIoGWxj+a2L59ElcS4= From: Andrew Morton To: Anton Altaparmakov Cc: "linux-ntfs-dev@lists.sourceforge.net" , LKML , Zheng Zengkai Subject: Re: [PATCH -next] fs/ntfs: fix set but not used variable 'log_page_mask' Message-Id: <20201209183623.b26e90de3d0aa92a72010ff0@linux-foundation.org> In-Reply-To: <94ED375C-C57C-464B-A1CA-BFB1EEF71BB2@tuxera.com> References: <20200312041353.19877-1-zhengzengkai@huawei.com> <94ED375C-C57C-464B-A1CA-BFB1EEF71BB2@tuxera.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 8 Dec 2020 08:24:02 +0000 Anton Altaparmakov wrote: > Can you please apply this? > > ... > > > --- a/fs/ntfs/logfile.c > > +++ b/fs/ntfs/logfile.c > > @@ -507,7 +507,7 @@ bool ntfs_check_logfile(struct inode *log_vi, RESTART_PAGE_HEADER **rp) > > * optimize log_page_size and log_page_bits into constants. > > */ > > log_page_bits = ntfs_ffs(log_page_size) - 1; > > - size &= ~(s64)(log_page_size - 1); > > + size &= ~(s64)(log_page_mask); > > /* > > * Ensure the log file is big enough to store at least the two restart > > * pages and the minimum number of log record pages. https://lore.kernel.org/lkml/1604821092-54631-1-git-send-email-alex.shi@linux.alibaba.com/ addressed this?