Re: [PATCH v3 4/8] drm/gem: Create infrastructure for GEM vmap_local

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2791 bytes --]

Hi Thomas,

I love your patch! Perhaps something to improve:

[auto build test WARNING on next-20201209]
[cannot apply to linus/master anholt/for-next v5.10-rc7 v5.10-rc6 v5.10-rc5 v5.10-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-Support-short-term-vmap-via-vmap_local/20201209-222628
base:    2f1d5c77f13fe64497c2e2601605f7d7ec4da9b1
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/7e45591797810a937bff58af4db651833ef72abe
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Thomas-Zimmermann/drm-Support-short-term-vmap-via-vmap_local/20201209-222628
        git checkout 7e45591797810a937bff58af4db651833ef72abe
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/virtio/virtgpu_prime.c:57:11: warning: initialized field overwritten [-Woverride-init]
      57 |   .vmap = drm_gem_dmabuf_vmap_local,
         |           ^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/virtio/virtgpu_prime.c:57:11: note: (near initialization for 'virtgpu_dmabuf_ops.ops.vmap')
   drivers/gpu/drm/virtio/virtgpu_prime.c:58:13: warning: initialized field overwritten [-Woverride-init]
      58 |   .vunmap = drm_gem_dmabuf_vunmap_local,
         |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/virtio/virtgpu_prime.c:58:13: note: (near initialization for 'virtgpu_dmabuf_ops.ops.vunmap')

vim +57 drivers/gpu/drm/virtio/virtgpu_prime.c

    45	
    46	static const struct virtio_dma_buf_ops virtgpu_dmabuf_ops =  {
    47		.ops = {
    48			.cache_sgt_mapping = true,
    49			.attach = virtio_dma_buf_attach,
    50			.detach = drm_gem_map_detach,
    51			.map_dma_buf = drm_gem_map_dma_buf,
    52			.unmap_dma_buf = drm_gem_unmap_dma_buf,
    53			.release = drm_gem_dmabuf_release,
    54			.mmap = drm_gem_dmabuf_mmap,
    55			.vmap = drm_gem_dmabuf_vmap,
    56			.vunmap = drm_gem_dmabuf_vunmap,
  > 57			.vmap = drm_gem_dmabuf_vmap_local,
    58			.vunmap = drm_gem_dmabuf_vunmap_local,
    59		},
    60		.device_attach = drm_gem_map_attach,
    61		.get_uuid = virtgpu_virtio_get_uuid,
    62	};
    63	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 76664 bytes --]