From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============5845608823206675985==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] of: property: fix returnvar.cocci warnings Date: Thu, 10 Dec 2020 10:39:14 +0800 Message-ID: <20201210023914.GA29723@d77c63856d78> In-Reply-To: <202012101059.2noUZgz7-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============5845608823206675985== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org CC: devel(a)driverdev.osuosl.org TO: Saravana Kannan CC: "Greg Kroah-Hartman" CC: Rob Herring CC: Frank Rowand CC: devicetree(a)vger.kernel.org CC: linux-kernel(a)vger.kernel.org From: kernel test robot drivers/of/property.c:1331:5-8: Unneeded variable: "ret". Return "0" on lin= e 1343 Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci Fixes: 8a06d1ea0617 ("of: property: Update implementation of add_links() to= create fwnode links") CC: Saravana Kannan Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.= git driver-core-testing head: 3577afb0052fca65e67efdfc8e0859bb7bac87a6 commit: 8a06d1ea061739dd2e60aff3d64a58892e4031cf [22/33] of: property: Upda= te implementation of add_links() to create fwnode links :::::: branch date: 7 hours ago :::::: commit date: 8 hours ago Please take the patch only if it's a positive warning. Thanks! property.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/of/property.c +++ b/drivers/of/property.c @@ -1328,7 +1328,6 @@ static int of_link_property(struct devic const struct supplier_bindings *s =3D of_supplier_bindings; unsigned int i =3D 0; bool matched =3D false; - int ret =3D 0; = /* Do not stop at first failed link, link all available suppliers. */ while (!matched && s->parse_prop) { @@ -1340,7 +1339,7 @@ static int of_link_property(struct devic } s++; } - return ret; + return 0; } = static int of_fwnode_add_links(struct fwnode_handle *fwnode) --===============5845608823206675985==--