From: kernel test robot <lkp@intel.com> To: alardam@gmail.com, magnus.karlsson@intel.com, bjorn.topel@intel.com, andrii.nakryiko@gmail.com, kuba@kernel.org, ast@kernel.org, daniel@iogearbox.net, netdev@vger.kernel.org, davem@davemloft.net, john.fastabend@gmail.com, hawk@kernel.org Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com Subject: Re: [Intel-wired-lan] [PATCH v2 bpf 2/5] drivers/net: turn XDP properties on Date: Thu, 10 Dec 2020 03:05:35 +0800 [thread overview] Message-ID: <202012100251.PjG2mXqJ-lkp@intel.com> (raw) In-Reply-To: <20201204102901.109709-3-marekx.majtyka@intel.com> [-- Attachment #1: Type: text/plain, Size: 4330 bytes --] Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on eceae70bdeaeb6b8ceb662983cf663ff352fbc96] url: https://github.com/0day-ci/linux/commits/alardam-gmail-com/New-netdev-feature-flags-for-XDP/20201204-183428 base: eceae70bdeaeb6b8ceb662983cf663ff352fbc96 config: x86_64-randconfig-a003-20201209 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 1968804ac726e7674d5de22bc2204b45857da344) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://github.com/0day-ci/linux/commit/34e23fdbb761e9296101b14dc8c523d574ce6f74 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review alardam-gmail-com/New-netdev-feature-flags-for-XDP/20201204-183428 git checkout 34e23fdbb761e9296101b14dc8c523d574ce6f74 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): >> drivers/net/ethernet/intel/ice/ice_main.c:2984:2: error: implicit declaration of function 'xsk_set_zc_properties' [-Werror,-Wimplicit-function-declaration] xsk_set_zc_properties(&netdev->xdp_properties); ^ drivers/net/ethernet/intel/ice/ice_main.c:2984:2: note: did you mean 'xsk_set_zc_property'? include/net/xdp_sock_drv.h:251:20: note: 'xsk_set_zc_property' declared here static inline void xsk_set_zc_property(xdp_properties_t *properties) ^ 1 error generated. vim +/xsk_set_zc_properties +2984 drivers/net/ethernet/intel/ice/ice_main.c 2951 2952 /** 2953 * ice_cfg_netdev - Allocate, configure and register a netdev 2954 * @vsi: the VSI associated with the new netdev 2955 * 2956 * Returns 0 on success, negative value on failure 2957 */ 2958 static int ice_cfg_netdev(struct ice_vsi *vsi) 2959 { 2960 struct ice_pf *pf = vsi->back; 2961 struct ice_netdev_priv *np; 2962 struct net_device *netdev; 2963 u8 mac_addr[ETH_ALEN]; 2964 int err; 2965 2966 err = ice_devlink_create_port(vsi); 2967 if (err) 2968 return err; 2969 2970 netdev = alloc_etherdev_mqs(sizeof(*np), vsi->alloc_txq, 2971 vsi->alloc_rxq); 2972 if (!netdev) { 2973 err = -ENOMEM; 2974 goto err_destroy_devlink_port; 2975 } 2976 2977 vsi->netdev = netdev; 2978 np = netdev_priv(netdev); 2979 np->vsi = vsi; 2980 2981 ice_set_netdev_features(netdev); 2982 2983 xdp_set_full_properties(&netdev->xdp_properties); > 2984 xsk_set_zc_properties(&netdev->xdp_properties); 2985 2986 ice_set_ops(netdev); 2987 2988 if (vsi->type == ICE_VSI_PF) { 2989 SET_NETDEV_DEV(netdev, ice_pf_to_dev(pf)); 2990 ether_addr_copy(mac_addr, vsi->port_info->mac.perm_addr); 2991 ether_addr_copy(netdev->dev_addr, mac_addr); 2992 ether_addr_copy(netdev->perm_addr, mac_addr); 2993 } 2994 2995 netdev->priv_flags |= IFF_UNICAST_FLT; 2996 2997 /* Setup netdev TC information */ 2998 ice_vsi_cfg_netdev_tc(vsi, vsi->tc_cfg.ena_tc); 2999 3000 /* setup watchdog timeout value to be 5 second */ 3001 netdev->watchdog_timeo = 5 * HZ; 3002 3003 netdev->min_mtu = ETH_MIN_MTU; 3004 netdev->max_mtu = ICE_MAX_MTU; 3005 3006 err = register_netdev(vsi->netdev); 3007 if (err) 3008 goto err_free_netdev; 3009 3010 devlink_port_type_eth_set(&vsi->devlink_port, vsi->netdev); 3011 3012 netif_carrier_off(vsi->netdev); 3013 3014 /* make sure transmit queues start off as stopped */ 3015 netif_tx_stop_all_queues(vsi->netdev); 3016 3017 return 0; 3018 3019 err_free_netdev: 3020 free_netdev(vsi->netdev); 3021 vsi->netdev = NULL; 3022 err_destroy_devlink_port: 3023 ice_devlink_destroy_port(vsi); 3024 return err; 3025 } 3026 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 36972 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: kbuild-all@lists.01.org Subject: Re: [Intel-wired-lan] [PATCH v2 bpf 2/5] drivers/net: turn XDP properties on Date: Thu, 10 Dec 2020 03:05:35 +0800 [thread overview] Message-ID: <202012100251.PjG2mXqJ-lkp@intel.com> (raw) In-Reply-To: <20201204102901.109709-3-marekx.majtyka@intel.com> [-- Attachment #1: Type: text/plain, Size: 4450 bytes --] Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on eceae70bdeaeb6b8ceb662983cf663ff352fbc96] url: https://github.com/0day-ci/linux/commits/alardam-gmail-com/New-netdev-feature-flags-for-XDP/20201204-183428 base: eceae70bdeaeb6b8ceb662983cf663ff352fbc96 config: x86_64-randconfig-a003-20201209 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 1968804ac726e7674d5de22bc2204b45857da344) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://github.com/0day-ci/linux/commit/34e23fdbb761e9296101b14dc8c523d574ce6f74 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review alardam-gmail-com/New-netdev-feature-flags-for-XDP/20201204-183428 git checkout 34e23fdbb761e9296101b14dc8c523d574ce6f74 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): >> drivers/net/ethernet/intel/ice/ice_main.c:2984:2: error: implicit declaration of function 'xsk_set_zc_properties' [-Werror,-Wimplicit-function-declaration] xsk_set_zc_properties(&netdev->xdp_properties); ^ drivers/net/ethernet/intel/ice/ice_main.c:2984:2: note: did you mean 'xsk_set_zc_property'? include/net/xdp_sock_drv.h:251:20: note: 'xsk_set_zc_property' declared here static inline void xsk_set_zc_property(xdp_properties_t *properties) ^ 1 error generated. vim +/xsk_set_zc_properties +2984 drivers/net/ethernet/intel/ice/ice_main.c 2951 2952 /** 2953 * ice_cfg_netdev - Allocate, configure and register a netdev 2954 * @vsi: the VSI associated with the new netdev 2955 * 2956 * Returns 0 on success, negative value on failure 2957 */ 2958 static int ice_cfg_netdev(struct ice_vsi *vsi) 2959 { 2960 struct ice_pf *pf = vsi->back; 2961 struct ice_netdev_priv *np; 2962 struct net_device *netdev; 2963 u8 mac_addr[ETH_ALEN]; 2964 int err; 2965 2966 err = ice_devlink_create_port(vsi); 2967 if (err) 2968 return err; 2969 2970 netdev = alloc_etherdev_mqs(sizeof(*np), vsi->alloc_txq, 2971 vsi->alloc_rxq); 2972 if (!netdev) { 2973 err = -ENOMEM; 2974 goto err_destroy_devlink_port; 2975 } 2976 2977 vsi->netdev = netdev; 2978 np = netdev_priv(netdev); 2979 np->vsi = vsi; 2980 2981 ice_set_netdev_features(netdev); 2982 2983 xdp_set_full_properties(&netdev->xdp_properties); > 2984 xsk_set_zc_properties(&netdev->xdp_properties); 2985 2986 ice_set_ops(netdev); 2987 2988 if (vsi->type == ICE_VSI_PF) { 2989 SET_NETDEV_DEV(netdev, ice_pf_to_dev(pf)); 2990 ether_addr_copy(mac_addr, vsi->port_info->mac.perm_addr); 2991 ether_addr_copy(netdev->dev_addr, mac_addr); 2992 ether_addr_copy(netdev->perm_addr, mac_addr); 2993 } 2994 2995 netdev->priv_flags |= IFF_UNICAST_FLT; 2996 2997 /* Setup netdev TC information */ 2998 ice_vsi_cfg_netdev_tc(vsi, vsi->tc_cfg.ena_tc); 2999 3000 /* setup watchdog timeout value to be 5 second */ 3001 netdev->watchdog_timeo = 5 * HZ; 3002 3003 netdev->min_mtu = ETH_MIN_MTU; 3004 netdev->max_mtu = ICE_MAX_MTU; 3005 3006 err = register_netdev(vsi->netdev); 3007 if (err) 3008 goto err_free_netdev; 3009 3010 devlink_port_type_eth_set(&vsi->devlink_port, vsi->netdev); 3011 3012 netif_carrier_off(vsi->netdev); 3013 3014 /* make sure transmit queues start off as stopped */ 3015 netif_tx_stop_all_queues(vsi->netdev); 3016 3017 return 0; 3018 3019 err_free_netdev: 3020 free_netdev(vsi->netdev); 3021 vsi->netdev = NULL; 3022 err_destroy_devlink_port: 3023 ice_devlink_destroy_port(vsi); 3024 return err; 3025 } 3026 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 36972 bytes --]
next prev parent reply other threads:[~2020-12-09 19:07 UTC|newest] Thread overview: 120+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-04 10:28 [PATCH v2 bpf 0/5] New netdev feature flags for XDP alardam 2020-12-04 10:28 ` [Intel-wired-lan] " alardam 2020-12-04 10:28 ` [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set alardam 2020-12-04 10:28 ` [Intel-wired-lan] " alardam 2020-12-04 12:18 ` Toke Høiland-Jørgensen 2020-12-04 12:18 ` [Intel-wired-lan] " Toke =?unknown-8bit?q?H=C3=B8iland-J=C3=B8rgensen?= 2020-12-04 12:46 ` Maciej Fijalkowski 2020-12-04 12:46 ` [Intel-wired-lan] " Maciej Fijalkowski 2020-12-04 15:21 ` Daniel Borkmann 2020-12-04 15:21 ` [Intel-wired-lan] " Daniel Borkmann 2020-12-04 17:20 ` Toke Høiland-Jørgensen 2020-12-04 17:20 ` [Intel-wired-lan] " Toke =?unknown-8bit?q?H=C3=B8iland-J=C3=B8rgensen?= 2020-12-04 22:19 ` Daniel Borkmann 2020-12-04 22:19 ` [Intel-wired-lan] " Daniel Borkmann 2020-12-07 11:54 ` Jesper Dangaard Brouer 2020-12-07 11:54 ` [Intel-wired-lan] " Jesper Dangaard Brouer 2020-12-07 12:08 ` Toke Høiland-Jørgensen 2020-12-07 12:08 ` [Intel-wired-lan] " Toke =?unknown-8bit?q?H=C3=B8iland-J=C3=B8rgensen?= 2020-12-07 12:03 ` Toke Høiland-Jørgensen 2020-12-07 12:03 ` [Intel-wired-lan] " Toke =?unknown-8bit?q?H=C3=B8iland-J=C3=B8rgensen?= 2020-12-07 12:54 ` Jesper Dangaard Brouer 2020-12-07 12:54 ` [Intel-wired-lan] " Jesper Dangaard Brouer 2020-12-07 20:52 ` John Fastabend 2020-12-07 20:52 ` [Intel-wired-lan] " John Fastabend 2020-12-07 22:38 ` Saeed Mahameed 2020-12-07 22:38 ` [Intel-wired-lan] " Saeed Mahameed 2020-12-07 23:07 ` Maciej Fijalkowski 2020-12-07 23:07 ` [Intel-wired-lan] " Maciej Fijalkowski 2020-12-09 6:03 ` John Fastabend 2020-12-09 6:03 ` [Intel-wired-lan] " John Fastabend 2020-12-09 9:54 ` Maciej Fijalkowski 2020-12-09 9:54 ` [Intel-wired-lan] " Maciej Fijalkowski 2020-12-09 11:52 ` Jesper Dangaard Brouer 2020-12-09 11:52 ` [Intel-wired-lan] " Jesper Dangaard Brouer 2020-12-09 15:41 ` David Ahern 2020-12-09 15:41 ` [Intel-wired-lan] " David Ahern 2020-12-09 17:15 ` Saeed Mahameed 2020-12-09 17:15 ` [Intel-wired-lan] " Saeed Mahameed 2020-12-10 3:34 ` David Ahern 2020-12-10 3:34 ` [Intel-wired-lan] " David Ahern 2020-12-10 6:48 ` Saeed Mahameed 2020-12-10 6:48 ` [Intel-wired-lan] " Saeed Mahameed 2020-12-10 15:30 ` David Ahern 2020-12-10 15:30 ` [Intel-wired-lan] " David Ahern 2020-12-10 18:58 ` Saeed Mahameed 2020-12-10 18:58 ` [Intel-wired-lan] " Saeed Mahameed 2021-01-05 11:56 ` Marek Majtyka 2021-01-05 11:56 ` [Intel-wired-lan] " Marek Majtyka 2021-02-01 16:16 ` Toke Høiland-Jørgensen 2021-02-01 16:16 ` [Intel-wired-lan] " Toke =?unknown-8bit?q?H=C3=B8iland-J=C3=B8rgensen?= 2021-02-02 11:26 ` Marek Majtyka 2021-02-02 11:26 ` [Intel-wired-lan] " Marek Majtyka 2021-02-02 12:05 ` Toke Høiland-Jørgensen 2021-02-02 12:05 ` [Intel-wired-lan] " Toke =?unknown-8bit?q?H=C3=B8iland-J=C3=B8rgensen?= 2021-02-02 19:34 ` Jakub Kicinski 2021-02-02 19:34 ` [Intel-wired-lan] " Jakub Kicinski 2021-02-03 12:50 ` Marek Majtyka 2021-02-03 12:50 ` [Intel-wired-lan] " Marek Majtyka 2021-02-03 17:02 ` Jakub Kicinski 2021-02-03 17:02 ` [Intel-wired-lan] " Jakub Kicinski 2021-02-10 10:53 ` Toke Høiland-Jørgensen 2021-02-10 10:53 ` [Intel-wired-lan] " Toke =?unknown-8bit?q?H=C3=B8iland-J=C3=B8rgensen?= 2021-02-10 18:31 ` Jakub Kicinski 2021-02-10 18:31 ` [Intel-wired-lan] " Jakub Kicinski 2021-02-10 22:52 ` Toke Høiland-Jørgensen 2021-02-10 22:52 ` [Intel-wired-lan] " Toke =?unknown-8bit?q?H=C3=B8iland-J=C3=B8rgensen?= 2021-02-12 1:26 ` Jakub Kicinski 2021-02-12 1:26 ` [Intel-wired-lan] " Jakub Kicinski 2021-02-12 2:05 ` Alexei Starovoitov 2021-02-12 2:05 ` [Intel-wired-lan] " Alexei Starovoitov 2021-02-12 7:02 ` Marek Majtyka 2021-02-12 7:02 ` [Intel-wired-lan] " Marek Majtyka 2021-02-16 14:30 ` Toke Høiland-Jørgensen 2021-02-16 14:30 ` [Intel-wired-lan] " Toke =?unknown-8bit?q?H=C3=B8iland-J=C3=B8rgensen?= 2020-12-09 15:44 ` David Ahern 2020-12-09 15:44 ` [Intel-wired-lan] " David Ahern 2020-12-10 13:32 ` Explaining XDP redirect bulk size design (Was: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set) Jesper Dangaard Brouer 2020-12-10 13:32 ` [Intel-wired-lan] " Jesper Dangaard Brouer 2020-12-10 14:14 ` Magnus Karlsson 2020-12-10 14:14 ` Magnus Karlsson 2020-12-10 17:30 ` Jesper Dangaard Brouer 2020-12-10 17:30 ` Jesper Dangaard Brouer 2020-12-10 19:20 ` Saeed Mahameed 2020-12-10 19:20 ` [Intel-wired-lan] " Saeed Mahameed 2020-12-08 1:01 ` [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set David Ahern 2020-12-08 1:01 ` [Intel-wired-lan] " David Ahern 2020-12-08 8:28 ` Jesper Dangaard Brouer 2020-12-08 8:28 ` [Intel-wired-lan] " Jesper Dangaard Brouer 2020-12-08 11:58 ` Toke Høiland-Jørgensen 2020-12-08 11:58 ` [Intel-wired-lan] " Toke =?unknown-8bit?q?H=C3=B8iland-J=C3=B8rgensen?= 2020-12-09 5:50 ` John Fastabend 2020-12-09 5:50 ` [Intel-wired-lan] " John Fastabend 2020-12-09 10:26 ` Toke Høiland-Jørgensen 2020-12-09 10:26 ` [Intel-wired-lan] " Toke =?unknown-8bit?q?H=C3=B8iland-J=C3=B8rgensen?= 2020-12-08 9:00 ` Jesper Dangaard Brouer 2020-12-08 9:00 ` [Intel-wired-lan] " Jesper Dangaard Brouer 2020-12-08 9:42 ` Daniel Borkmann 2020-12-08 9:42 ` [Intel-wired-lan] " Daniel Borkmann 2020-12-04 12:57 ` Maciej Fijalkowski 2020-12-04 12:57 ` [Intel-wired-lan] " Maciej Fijalkowski 2020-12-04 10:28 ` [PATCH v2 bpf 2/5] drivers/net: turn XDP properties on alardam 2020-12-04 10:28 ` [Intel-wired-lan] " alardam 2020-12-04 12:19 ` Toke Høiland-Jørgensen 2020-12-04 12:19 ` [Intel-wired-lan] " Toke =?unknown-8bit?q?H=C3=B8iland-J=C3=B8rgensen?= 2020-12-09 19:05 ` kernel test robot [this message] 2020-12-09 19:05 ` kernel test robot 2020-12-04 10:28 ` [PATCH v2 bpf 3/5] xsk: add usage of xdp properties flags alardam 2020-12-04 10:28 ` [Intel-wired-lan] " alardam 2020-12-04 10:29 ` [PATCH v2 bpf 4/5] xsk: add check for full support of XDP in bind alardam 2020-12-04 10:29 ` [Intel-wired-lan] " alardam 2020-12-04 10:29 ` [PATCH v2 bpf 5/5] ethtool: provide xdp info with XDP_PROPERTIES_GET alardam 2020-12-04 10:29 ` [Intel-wired-lan] " alardam 2020-12-04 17:20 ` [PATCH v2 bpf 0/5] New netdev feature flags for XDP Jakub Kicinski 2020-12-04 17:20 ` [Intel-wired-lan] " Jakub Kicinski 2020-12-04 17:26 ` Toke Høiland-Jørgensen 2020-12-04 17:26 ` [Intel-wired-lan] " Toke =?unknown-8bit?q?H=C3=B8iland-J=C3=B8rgensen?= 2020-12-04 19:22 ` Jakub Kicinski 2020-12-04 19:22 ` [Intel-wired-lan] " Jakub Kicinski 2020-12-07 12:04 ` Toke Høiland-Jørgensen 2020-12-07 12:04 ` [Intel-wired-lan] " Toke =?unknown-8bit?q?H=C3=B8iland-J=C3=B8rgensen?=
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202012100251.PjG2mXqJ-lkp@intel.com \ --to=lkp@intel.com \ --cc=alardam@gmail.com \ --cc=andrii.nakryiko@gmail.com \ --cc=ast@kernel.org \ --cc=bjorn.topel@intel.com \ --cc=clang-built-linux@googlegroups.com \ --cc=daniel@iogearbox.net \ --cc=davem@davemloft.net \ --cc=hawk@kernel.org \ --cc=john.fastabend@gmail.com \ --cc=kbuild-all@lists.01.org \ --cc=kuba@kernel.org \ --cc=magnus.karlsson@intel.com \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.