All of lore.kernel.org
 help / color / mirror / Atom feed
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Zhen Lei <thunder.leizhen@huawei.com>
Cc: Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
	Rob Herring <robh+dt@kernel.org>,
	linux-leds <linux-leds@vger.kernel.org>,
	devicetree <devicetree@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Darshak Patel <darshak.patel@einfochips.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Dong Aisheng <aisheng.dong@nxp.com>,
	Guodong Xu <guodong.xu@linaro.org>, Wei Xu <xuwei5@hisilicon.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	Marian-Cristian Rotariu 
	<marian-cristian.rotariu.rb@bp.renesas.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Heiko Stuebner <heiko@sntech.de>
Subject: Re: [PATCH 1/1] dt-bindings: leds: add onboard LED triggers of 96Boards
Date: Thu, 10 Dec 2020 09:01:57 +0530	[thread overview]
Message-ID: <20201210033157.GA6466@thinkpad> (raw)
In-Reply-To: <20201210031203.1901-1-thunder.leizhen@huawei.com>

Hi,

On Thu, Dec 10, 2020 at 11:12:03AM +0800, Zhen Lei wrote:
> For all 96Boards, the following standard is used for onboard LEDs.
> 
> green:user1  default-trigger: heartbeat
> green:user2  default-trigger: mmc0/disk-activity(onboard-storage)
> green:user3  default-trigger: mmc1 (SD-card)
> green:user4  default-trigger: none, panic-indicator
> yellow:wlan  default-trigger: phy0tx
> blue:bt      default-trigger: hci0-power
> 
> Link to 96Boards CE Specification: https://linaro.co/ce-specification
> 

This is just a board configuration and there is absolutely no need to document
this in common LED binding. But if your intention is to document the missing
triggers, then you should look at the patch I submitted long ago.

https://lore.kernel.org/patchwork/patch/1146359/

Maybe I should resubmit it again in YAML format. (thanks for reminding me :P)

Thanks,
Mani

> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> Cc: Darshak Patel <darshak.patel@einfochips.com>
> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Dong Aisheng <aisheng.dong@nxp.com>
> Cc: Guodong Xu <guodong.xu@linaro.org>
> Cc: Wei Xu <xuwei5@hisilicon.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Cc: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Heiko Stuebner <heiko@sntech.de>
> ---
>  Documentation/devicetree/bindings/leds/common.yaml | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
> index f1211e7045f12f3..525752d6c5c84fd 100644
> --- a/Documentation/devicetree/bindings/leds/common.yaml
> +++ b/Documentation/devicetree/bindings/leds/common.yaml
> @@ -97,6 +97,16 @@ properties:
>          # LED alters the brightness for the specified duration with one software
>          # timer (requires "led-pattern" property)
>        - pattern
> +        #For all 96Boards, Green, disk-activity(onboard-storage)
> +      - mmc0
> +        #For all 96Boards, Green, SD-card
> +      - mmc1
> +        #For all 96Boards, Green, panic-indicator
> +      - none
> +        #For all 96Boards, Yellow, WiFi activity LED
> +      - phy0tx
> +        #For all 96Boards, Blue, Bluetooth activity LED
> +      - hci0-power
>  
>    led-pattern:
>      description: |
> -- 
> 1.8.3
> 
> 

  reply	other threads:[~2020-12-10  3:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-10  3:12 [PATCH 1/1] dt-bindings: leds: add onboard LED triggers of 96Boards Zhen Lei
2020-12-10  3:31 ` Manivannan Sadhasivam [this message]
2020-12-10  6:14   ` Leizhen (ThunderTown)
2020-12-10  6:21     ` Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201210033157.GA6466@thinkpad \
    --to=manivannan.sadhasivam@linaro.org \
    --cc=aisheng.dong@nxp.com \
    --cc=darshak.patel@einfochips.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmurphy@ti.com \
    --cc=geert+renesas@glider.be \
    --cc=guodong.xu@linaro.org \
    --cc=heiko@sntech.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=marian-cristian.rotariu.rb@bp.renesas.com \
    --cc=pavel@ucw.cz \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=thunder.leizhen@huawei.com \
    --cc=xuwei5@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.