From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0451BC4361B for ; Thu, 10 Dec 2020 06:48:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8501722D0A for ; Thu, 10 Dec 2020 06:48:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731974AbgLJGsI (ORCPT ); Thu, 10 Dec 2020 01:48:08 -0500 Received: from nautica.notk.org ([91.121.71.147]:58908 "EHLO nautica.notk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726158AbgLJGsI (ORCPT ); Thu, 10 Dec 2020 01:48:08 -0500 Received: by nautica.notk.org (Postfix, from userid 1001) id 2C95AC009; Thu, 10 Dec 2020 07:47:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codewreck.org; s=2; t=1607582846; bh=CeXoCUKMON5YU5rHxPI+L+5A1EbCCf8M0F43PjWAz8Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=X3TWBjHK4dE4RDjYtxHWJ/3/LGEiPaX+nS+SahytVl312G2LMxkMZQ+ygTusu21EI IIDfhBOvFIz96VMlBOg3anlHGl+N5JVK3XpRL3a51NggI8LcBk1hIQIOz8zCjd2Mlf 1dbVGh8QTr6rm+gylBELiIJyt3MkmzNf6fAaP/XOj97SslE/fs9lwChh3yo4a0tjRz IWRF9SUv7vlJaGShz9xmI7j5oJBnm6FKx62usvLpvuEhJz3HqVjrbSUav4dhTTLhHa Gq7kohW4ar5Xqn0XrnzYOFyxTJG9Qpp5ZdlRvzE7FrfZy1uzDI0EGvcYh2N76IEqY+ B06UjBBnAEFKw== Date: Thu, 10 Dec 2020 07:47:11 +0100 From: Dominique Martinet To: Stephen Rothwell Cc: Masahiro Yamada , Linux Kernel Mailing List , Linux Next Mailing List Subject: Re: linux-next: build warning after merge of the kbuild tree Message-ID: <20201210064711.GA10169@nautica> References: <20201209203029.7f2a8db2@canb.auug.org.au> <20201209130130.GA15469@nautica> <20201210075645.234a735d@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201210075645.234a735d@canb.auug.org.au> User-Agent: Mutt/1.5.21 (2010-09-15) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Stephen Rothwell wrote on Thu, Dec 10, 2020: > On Wed, 9 Dec 2020 14:01:30 +0100 Dominique Martinet wrote: > > > > I guess it's possible to make kbuild check both sbin and PATH, would > > that be acceptable? > > I guess so. But, have you actually found any setup where depmod is not > /sbin/depmod? i.e. what problem are you trying to solve. As far as I > can see all this change does is (ever so slightly) slow down the build > for no gain. On nixos, depmod is in /run/current-system/sw/bin/depmod (as a link to /nix/store/r3r39rzsrikdsv68rvswn3hhank706gj-kmod-27/bin/depmod or wherever the current version wants to be). developers on guix probably face the same problem. There is no sbin, the only things in /bin is sh, and in /usr/bin env as I think is mandated by posix. For their official builds they just modify the build scripts in place before starting the build, but for dev as I keep rebasing it's annoying to keep a couple of local patches just for this. I could obviously manually create a link from /sbin/depmod to the current system's but that doesn't solve the problem for all other nixos users. I'll send an updated patch later today.. -- Dominique