From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0A59C4361B for ; Thu, 10 Dec 2020 14:28:10 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 71F3323D57 for ; Thu, 10 Dec 2020 14:28:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 71F3323D57 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FBbUmpAPB3e6BD/Tw074I2pnsxkjDtiw9udmdnXSd6Y=; b=XQ1OJZk+MVYsOR+PfN5tens7/ Yb2pVvMTFOUpZiIfeMxZzRaEhwLS1yJxot7SMwFf1yOl/yXA0X9hKKArg7R/AcG11cq8+z1kHav9s XEnZiz035u5jmljmfzMlkEyr+NcbELCGsyAGQi6bc2tGe6uVTBgODmFo7twuE4zoxgo9uFQ25mv+b 3UyCdkIjFMfgPzq7Q6xv9vNpW7QPC5VQoTguHgCFYqrCATj02gSdW1VaVMVq3ZkwK9zWhMK/5SaTc oZhkU2EEmq9Yz4rDzme7PscWwAbltf8tPzeYRXy4sZWGfD6q5K/V6zDweuDWyJyWhkFN4X0pA9Pnw LTiioIRig==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1knMu9-0005JZ-FL; Thu, 10 Dec 2020 14:26:49 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1knMtw-0005DO-FV; Thu, 10 Dec 2020 14:26:41 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 69369F7F; Thu, 10 Dec 2020 09:26:32 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 10 Dec 2020 09:26:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=/1h7IULFlgMYvyUbP2+Uxu6AyhC gpN9jIorI6el9bxk=; b=cqLBGqbAw0TIplqtVaJ3y9WrJyXuuDK5/0QMBKi9PjF x/ANJ71MDBUN/efYb0VaBwZ/gf4wSPRAEzhVaDuxhWY51KsJFm/IYnAN6hLZCull Uk43dc7YrnOW8/EW0fR4J+D0yN4TidkTP1SwMB18LCqgIOH9IVjrBrxws6gec/yK JJbzXOt0O1qDegDS4h02/v2qsPIcYygxcwdl4get3ubpbgH6J08duiVy7zztf9l0 gIUq66bnbffrKAMcxYp2EYlkYYpBENGJ2nzSriVzTh9p2o0EP9YhLqQvV2/+jp+e gbJB6bf2HXz5C4JX6hGOZIqHyuJgRo49bQPkFoBjhNg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=/1h7IU LFlgMYvyUbP2+Uxu6AyhCgpN9jIorI6el9bxk=; b=T3ErwnkwISMnn4gUfHWnni XigWtMuYcvm3gxCDbHpB+D+yhdgeyd1NrV9tVhPssLmdAUqh+jy1lcpajAKnUtkd dt5JQaEBGECramHBNKGHAjYMIKAEhZ1vdMg4SpHU9/SFz8yFUg+Nw3F/FZWT0tZM JrPnhABcwRNaf8p+E/aIwLQEjZV61EnwJxY6P3aTYxf9fMjf7xEn9e/xgNuLlgGV phMoGNVAA+BSaTiOh3LsJJL14w9o2SuSkS+Y05RnfqxzUFnr6n5bE+EMVNfb1ILO gzTtdIwPIdX8ow7TBuLiXCXp8ZJ9XSyNlA2JDb+LRRZuS58UayZvbsboWqZ0+nGg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudektddgieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 3116924005A; Thu, 10 Dec 2020 09:26:30 -0500 (EST) Date: Thu, 10 Dec 2020 15:26:29 +0100 From: Maxime Ripard To: Maarten Lankhorst , Thomas Zimmermann , Daniel Vetter , David Airlie , Eric Anholt Subject: Re: [PATCH v6 5/9] drm/vc4: hdmi: Create a custom connector state Message-ID: <20201210142629.yyllydmegbhr3lom@gilmour> References: <20201210142329.10640-1-maxime@cerno.tech> <20201210142329.10640-6-maxime@cerno.tech> MIME-Version: 1.0 In-Reply-To: <20201210142329.10640-6-maxime@cerno.tech> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201210_092636_859460_5F80F1C2 X-CRM114-Status: GOOD ( 18.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Dave Stevenson Content-Type: multipart/mixed; boundary="===============8372911213271063052==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8372911213271063052== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cwongxt7lcmqbz6p" Content-Disposition: inline --cwongxt7lcmqbz6p Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 10, 2020 at 03:23:25PM +0100, Maxime Ripard wrote: > When run with a higher bpc than 8, the clock of the HDMI controller needs > to be adjusted. Let's create a connector state that will be used at > atomic_check and atomic_enable to compute and store the clock rate > associated to the state. >=20 > Acked-by: Thomas Zimmermann > Reviewed-by: Dave Stevenson > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/vc4/vc4_hdmi.c | 33 ++++++++++++++++++++++++++++++--- > drivers/gpu/drm/vc4/vc4_hdmi.h | 10 ++++++++++ > 2 files changed, 40 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdm= i.c > index 61039cc89d9d..8978df3f0ca4 100644 > --- a/drivers/gpu/drm/vc4/vc4_hdmi.c > +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c > @@ -170,10 +170,37 @@ static int vc4_hdmi_connector_get_modes(struct drm_= connector *connector) > =20 > static void vc4_hdmi_connector_reset(struct drm_connector *connector) > { > - drm_atomic_helper_connector_reset(connector); > + struct vc4_hdmi_connector_state *old_state =3D > + conn_state_to_vc4_hdmi_conn_state(connector->state); > + struct vc4_hdmi_connector_state *new_state =3D > + kzalloc(sizeof(*conn_state), GFP_KERNEL); This should be sizeof(*new_state). I'll fix it up when applying if there's = no other comments Maxime --cwongxt7lcmqbz6p Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX9IwFQAKCRDj7w1vZxhR xRGIAP9ARZbhRFSMU/0hdseePpsBel+12XBk2VNiNiO5OyHXfgEAn6kg1acwvb3R EHSHPv5dlNeZFccf4ICtOa2uS6+mLw8= =oXJp -----END PGP SIGNATURE----- --cwongxt7lcmqbz6p-- --===============8372911213271063052== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8372911213271063052==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D95DC4167B for ; Thu, 10 Dec 2020 14:48:42 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ECE5E22D74 for ; Thu, 10 Dec 2020 14:48:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ECE5E22D74 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4207F6EA70; Thu, 10 Dec 2020 14:48:12 +0000 (UTC) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 648C66E42A for ; Thu, 10 Dec 2020 14:26:33 +0000 (UTC) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 69369F7F; Thu, 10 Dec 2020 09:26:32 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 10 Dec 2020 09:26:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=/1h7IULFlgMYvyUbP2+Uxu6AyhC gpN9jIorI6el9bxk=; b=cqLBGqbAw0TIplqtVaJ3y9WrJyXuuDK5/0QMBKi9PjF x/ANJ71MDBUN/efYb0VaBwZ/gf4wSPRAEzhVaDuxhWY51KsJFm/IYnAN6hLZCull Uk43dc7YrnOW8/EW0fR4J+D0yN4TidkTP1SwMB18LCqgIOH9IVjrBrxws6gec/yK JJbzXOt0O1qDegDS4h02/v2qsPIcYygxcwdl4get3ubpbgH6J08duiVy7zztf9l0 gIUq66bnbffrKAMcxYp2EYlkYYpBENGJ2nzSriVzTh9p2o0EP9YhLqQvV2/+jp+e gbJB6bf2HXz5C4JX6hGOZIqHyuJgRo49bQPkFoBjhNg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=/1h7IU LFlgMYvyUbP2+Uxu6AyhCgpN9jIorI6el9bxk=; b=T3ErwnkwISMnn4gUfHWnni XigWtMuYcvm3gxCDbHpB+D+yhdgeyd1NrV9tVhPssLmdAUqh+jy1lcpajAKnUtkd dt5JQaEBGECramHBNKGHAjYMIKAEhZ1vdMg4SpHU9/SFz8yFUg+Nw3F/FZWT0tZM JrPnhABcwRNaf8p+E/aIwLQEjZV61EnwJxY6P3aTYxf9fMjf7xEn9e/xgNuLlgGV phMoGNVAA+BSaTiOh3LsJJL14w9o2SuSkS+Y05RnfqxzUFnr6n5bE+EMVNfb1ILO gzTtdIwPIdX8ow7TBuLiXCXp8ZJ9XSyNlA2JDb+LRRZuS58UayZvbsboWqZ0+nGg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudektddgieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 3116924005A; Thu, 10 Dec 2020 09:26:30 -0500 (EST) Date: Thu, 10 Dec 2020 15:26:29 +0100 From: Maxime Ripard To: Maarten Lankhorst , Thomas Zimmermann , Daniel Vetter , David Airlie , Eric Anholt Subject: Re: [PATCH v6 5/9] drm/vc4: hdmi: Create a custom connector state Message-ID: <20201210142629.yyllydmegbhr3lom@gilmour> References: <20201210142329.10640-1-maxime@cerno.tech> <20201210142329.10640-6-maxime@cerno.tech> MIME-Version: 1.0 In-Reply-To: <20201210142329.10640-6-maxime@cerno.tech> X-Mailman-Approved-At: Thu, 10 Dec 2020 14:48:10 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Dave Stevenson Content-Type: multipart/mixed; boundary="===============0629832292==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --===============0629832292== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cwongxt7lcmqbz6p" Content-Disposition: inline --cwongxt7lcmqbz6p Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 10, 2020 at 03:23:25PM +0100, Maxime Ripard wrote: > When run with a higher bpc than 8, the clock of the HDMI controller needs > to be adjusted. Let's create a connector state that will be used at > atomic_check and atomic_enable to compute and store the clock rate > associated to the state. >=20 > Acked-by: Thomas Zimmermann > Reviewed-by: Dave Stevenson > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/vc4/vc4_hdmi.c | 33 ++++++++++++++++++++++++++++++--- > drivers/gpu/drm/vc4/vc4_hdmi.h | 10 ++++++++++ > 2 files changed, 40 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdm= i.c > index 61039cc89d9d..8978df3f0ca4 100644 > --- a/drivers/gpu/drm/vc4/vc4_hdmi.c > +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c > @@ -170,10 +170,37 @@ static int vc4_hdmi_connector_get_modes(struct drm_= connector *connector) > =20 > static void vc4_hdmi_connector_reset(struct drm_connector *connector) > { > - drm_atomic_helper_connector_reset(connector); > + struct vc4_hdmi_connector_state *old_state =3D > + conn_state_to_vc4_hdmi_conn_state(connector->state); > + struct vc4_hdmi_connector_state *new_state =3D > + kzalloc(sizeof(*conn_state), GFP_KERNEL); This should be sizeof(*new_state). I'll fix it up when applying if there's = no other comments Maxime --cwongxt7lcmqbz6p Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX9IwFQAKCRDj7w1vZxhR xRGIAP9ARZbhRFSMU/0hdseePpsBel+12XBk2VNiNiO5OyHXfgEAn6kg1acwvb3R EHSHPv5dlNeZFccf4ICtOa2uS6+mLw8= =oXJp -----END PGP SIGNATURE----- --cwongxt7lcmqbz6p-- --===============0629832292== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0629832292==--