All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Foster <bfoster@redhat.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH 0/2] xfs: don't drain buffer lru on freeze
Date: Thu, 10 Dec 2020 09:46:05 -0500	[thread overview]
Message-ID: <20201210144607.1922026-1-bfoster@redhat.com> (raw)

Hi all,

This series tweaks the xfs_log_quiesce() codepath to lift out the
explicit buffer target LRU draining and isolate it to the unmount path.
It's unnecessary to reclaim all buffers on filesystem freeze or
read-only remount, and this also causes such operations to stall if a
read heavy workload is running in parallel.

Patch 1 is a simple rename and patch 2 implements the functional change.
Thoughts, reviews, flames appreciated.

Brian

Brian Foster (2):
  xfs: rename xfs_wait_buftarg() to xfs_buftarg_drain()
  xfs: don't drain buffer lru on freeze and read-only remount

 fs/xfs/xfs_buf.c   | 30 ++++++++++++++++++++----------
 fs/xfs/xfs_buf.h   | 11 ++++++-----
 fs/xfs/xfs_log.c   |  8 +++++---
 fs/xfs/xfs_mount.c |  4 ++--
 fs/xfs/xfs_trace.h |  2 +-
 5 files changed, 34 insertions(+), 21 deletions(-)

-- 
2.26.2


             reply	other threads:[~2020-12-10 15:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-10 14:46 Brian Foster [this message]
2020-12-10 14:46 ` [PATCH 1/2] xfs: rename xfs_wait_buftarg() to xfs_buftarg_drain() Brian Foster
2020-12-11  9:22   ` Chandan Babu R
2021-02-02 20:23   ` Darrick J. Wong
2020-12-10 14:46 ` [PATCH 2/2] xfs: don't drain buffer lru on freeze and read-only remount Brian Foster
2020-12-11  9:28   ` Chandan Babu R
2020-12-11 13:42     ` Brian Foster
2021-02-02 20:24   ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201210144607.1922026-1-bfoster@redhat.com \
    --to=bfoster@redhat.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.