From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: syzbot <syzbot+345b75652b1d24227443@syzkaller.appspotmail.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
clang-built-linux <clang-built-linux@googlegroups.com>,
linux-ext4@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Nathan Chancellor <natechancellor@gmail.com>,
Nick Desaulniers <ndesaulniers@google.com>,
syzkaller-bugs <syzkaller-bugs@googlegroups.com>
Subject: Re: UBSAN: shift-out-of-bounds in ext4_fill_super
Date: Thu, 10 Dec 2020 13:28:21 -0500 [thread overview]
Message-ID: <20201210182821.GS52960@mit.edu> (raw)
In-Reply-To: <CACT4Y+bkaVq1RzONGuPJxu-pSyCSRrEs7xV0sa2n0oLNkicHQQ@mail.gmail.com>
On Thu, Dec 10, 2020 at 09:09:51AM +0100, Dmitry Vyukov wrote:
> > * [new tag] ext4-for-linus-5.8-rc1-2 -> ext4-for-linus-5.8-rc1-2
> > ! [rejected] ext4_for_linus -> ext4_for_linus (would clobber existing tag)
>
> Interesting. First time I see this. Should syzkaller use 'git fetch
> --tags --force"?...
> StackOverflow suggests it should help:
> https://stackoverflow.com/questions/58031165/how-to-get-rid-of-would-clobber-existing-tag
Yeah, sorry, ext4_for_linus is a signed tag which is only used to
authenticate my pull request to Linus. After Linus accepts the pull,
the digital signature is going to be upstream, and so I end up
deleting and the reusing that tag for the next merge window.
I guess I could just start always using ext4_for_linus-<VERSION> and
just delete the tags once they have been accepted, to keep my list of
tags clean.
It's going to make everyone else's tags who pull from ext4.git messy,
though, with gobs of tags that probably won't be of use to them. It
does avoid the need to use git fetch --tags --force, and I guess
people are used to the need to GC tags with the linux-repo. So maybe
that's the right thing to do going forward.
- Ted
next prev parent reply other threads:[~2020-12-10 18:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 7:33 UBSAN: shift-out-of-bounds in ext4_fill_super syzbot
2020-12-10 2:36 ` Theodore Y. Ts'o
2020-12-10 3:50 ` syzbot
2020-12-10 8:09 ` Dmitry Vyukov
2020-12-10 13:56 ` Dmitry Vyukov
2020-12-10 19:24 ` syzbot
2020-12-10 18:28 ` Theodore Y. Ts'o [this message]
2020-12-14 14:37 ` Dmitry Vyukov
2020-12-14 20:36 ` Theodore Y. Ts'o
2020-12-15 10:09 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201210182821.GS52960@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=clang-built-linux@googlegroups.com \
--cc=dvyukov@google.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=syzbot+345b75652b1d24227443@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.