From: Tom Parkin <tparkin@katalix.com>
To: David Miller <davem@davemloft.net>
Cc: gnault@redhat.com, netdev@vger.kernel.org, jchapman@katalix.com
Subject: Re: [PATCH v4 net-next 0/2] add ppp_generic ioctl(s) to bridge channels
Date: Fri, 11 Dec 2020 09:36:09 +0000 [thread overview]
Message-ID: <20201211093609.GA5112@katalix.com> (raw)
In-Reply-To: <20201210.142134.777780809639324675.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]
On Thu, Dec 10, 2020 at 14:21:34 -0800, David Miller wrote:
> From: Tom Parkin <tparkin@katalix.com>
> Date: Thu, 10 Dec 2020 17:16:45 +0000
>
> > On Thu, Dec 10, 2020 at 18:13:09 +0100, Guillaume Nault wrote:
> >> On Thu, Dec 10, 2020 at 03:50:56PM +0000, Tom Parkin wrote:
> >> > Following on from my previous RFC[1], this series adds two ioctl calls
> >> > to the ppp code to implement "channel bridging".
> >> >
> >> > When two ppp channels are bridged, frames presented to ppp_input() on
> >> > one channel are passed to the other channel's ->start_xmit function for
> >> > transmission.
> >> >
> >> > The primary use-case for this functionality is in an L2TP Access
> >> > Concentrator where PPP frames are typically presented in a PPPoE session
> >> > (e.g. from a home broadband user) and are forwarded to the ISP network in
> >> > a PPPoL2TP session.
> >>
> >> Looks good to me now. Thanks Tom!
> >>
> >> Reviewed-by: Guillaume Nault <gnault@redhat.com>
> >>
> >
> > Thanks again for your review and help with the series :-)
>
> Series applied.
Thanks Dave. Nice to see you back :-)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-12-11 9:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 15:50 [PATCH v4 net-next 0/2] add ppp_generic ioctl(s) to bridge channels Tom Parkin
2020-12-10 15:50 ` [PATCH v4 net-next 1/2] ppp: add PPPIOCBRIDGECHAN and PPPIOCUNBRIDGECHAN ioctls Tom Parkin
2021-01-11 13:17 ` Simon Chopin
2021-01-11 14:26 ` Guillaume Nault
2020-12-10 15:50 ` [PATCH v4 net-next 2/2] docs: update ppp_generic.rst to document new ioctls Tom Parkin
2020-12-10 17:13 ` [PATCH v4 net-next 0/2] add ppp_generic ioctl(s) to bridge channels Guillaume Nault
2020-12-10 17:16 ` Tom Parkin
2020-12-10 22:21 ` David Miller
2020-12-11 9:36 ` Tom Parkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201211093609.GA5112@katalix.com \
--to=tparkin@katalix.com \
--cc=davem@davemloft.net \
--cc=gnault@redhat.com \
--cc=jchapman@katalix.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.