From: Lee Jones <lee.jones@linaro.org>
To: Zheng Yongjun <zhengyongjun3@huawei.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] mfd: rave-sp: convert comma to semicolon
Date: Fri, 11 Dec 2020 10:05:58 +0000 [thread overview]
Message-ID: <20201211100558.GD5029@dell> (raw)
In-Reply-To: <20201211084404.2151-1-zhengyongjun3@huawei.com>
On Fri, 11 Dec 2020, Zheng Yongjun wrote:
> Replace a comma between expression statements by a semicolon.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
> drivers/mfd/rave-sp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/rave-sp.c b/drivers/mfd/rave-sp.c
> index 545196c85b5c..abb9cbdabaa9 100644
> --- a/drivers/mfd/rave-sp.c
> +++ b/drivers/mfd/rave-sp.c
> @@ -358,7 +358,7 @@ int rave_sp_exec(struct rave_sp *sp,
>
> ackid = atomic_inc_return(&sp->ackid);
> reply.ackid = ackid;
> - reply.code = rave_sp_reply_code((u8)command),
> + reply.code = rave_sp_reply_code((u8)command);
How did the original code not create a build error?
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2020-12-11 10:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 8:44 [PATCH -next] mfd: rave-sp: convert comma to semicolon Zheng Yongjun
2020-12-11 10:05 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201211100558.GD5029@dell \
--to=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhengyongjun3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.