From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2079AC433FE for ; Fri, 11 Dec 2020 16:32:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A3FAA23D3C for ; Fri, 11 Dec 2020 16:32:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390041AbgLKPfG (ORCPT ); Fri, 11 Dec 2020 10:35:06 -0500 Received: from mail-eopbgr130052.outbound.protection.outlook.com ([40.107.13.52]:29857 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728933AbgLKPeq (ORCPT ); Fri, 11 Dec 2020 10:34:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M03DEdjmlCMQHLuGnBWpmQguDLRH/JE9YKLvUgpRPPk=; b=g7+GBUPqRrlOla5lmXYz1A2zCQSbOG9McZEWTo6zFl1MISgZgHm+294EHthaivNMwX2+CJzCxGidERfrelEwqEvP8BBp7CFsBaP6PttTZTad59KNC1XuBh79LiqI1DVywZFwzBQY1E45DM8ZpAWFyrhkkKAeYcn6YFSnDZwZ6II= Received: from AM6PR10CA0005.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:89::18) by VI1PR0802MB2399.eurprd08.prod.outlook.com (2603:10a6:800:bb::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.13; Fri, 11 Dec 2020 15:33:55 +0000 Received: from AM5EUR03FT025.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:89:cafe::61) by AM6PR10CA0005.outlook.office365.com (2603:10a6:209:89::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12 via Frontend Transport; Fri, 11 Dec 2020 15:33:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; vger.kernel.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;vger.kernel.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT025.mail.protection.outlook.com (10.152.16.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12 via Frontend Transport; Fri, 11 Dec 2020 15:33:54 +0000 Received: ("Tessian outbound fc5cc0046d61:v71"); Fri, 11 Dec 2020 15:33:54 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 1dd39a4dd3283706 X-CR-MTA-TID: 64aa7808 Received: from cc51e005d193.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 59FD4E89-4EA8-4D34-B3D0-DEF1252AA1E8.1; Fri, 11 Dec 2020 15:33:38 +0000 Received: from EUR03-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cc51e005d193.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 11 Dec 2020 15:33:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JU+lj9oRPsYJhtOULEGrI4eLL6PmPJlUrb2ChCNBGy30KYeI83DyvgogeXiL/+L/ZinIfMgPH3GTkBYeqqZ/GGpabVQRIy6rPOt+X/t3xGkdf5sDhc0htU6ASjizgjN1rlyR+5I2SmEtKZ6poPiRjSdBtQwVFitmhKj2keSFpnlPe/Y6Z+tiML7YvFZVKZvb6i8CV3o3te7dfjhXGD4331fGaqXIoI7vX4HNKkkwalbEQ3JpTEQ3wDdxGbshawcxXfg6VzB0DVgbWNgbwJwGXffUUhDsP4172JHrdnq4lrOKmEPtHhdqclhfzij0h2sI0wWmckPu65UurfgQN71ZzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M03DEdjmlCMQHLuGnBWpmQguDLRH/JE9YKLvUgpRPPk=; b=Ht+80JMrYuCDMjtJlAn9I20pFwpBwlAf+9VJkKZHavjgRlvhqVuoYybpgT5EaIO+mv+mtt0yU3+dLxFpikAFcFCGTWY1UpPRIbpjsbYfZx6KG3K26Cp5TDVdJfXBNqe8+XpyT2+8usTixkzLM3DE9F8C89bp50K7vCQuCKhJPNvS7KJtgPamEznMYesxfTGwrjaiyKmA8KdEd3c5t5BCkGx3eoqURORRBOdoEkqDaKIuXWKybuRi9nIw7BLgc7S+5Wq1dKjX/v6tqsBG0YlB90qp50de9A2ioZ0k70OSLSKCJDV8uXXFtCT4dvg3G0Rh4+tMWbpEoyjr6AoHu1+Cgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M03DEdjmlCMQHLuGnBWpmQguDLRH/JE9YKLvUgpRPPk=; b=g7+GBUPqRrlOla5lmXYz1A2zCQSbOG9McZEWTo6zFl1MISgZgHm+294EHthaivNMwX2+CJzCxGidERfrelEwqEvP8BBp7CFsBaP6PttTZTad59KNC1XuBh79LiqI1DVywZFwzBQY1E45DM8ZpAWFyrhkkKAeYcn6YFSnDZwZ6II= Authentication-Results-Original: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=arm.com; Received: from PR3PR08MB5564.eurprd08.prod.outlook.com (2603:10a6:102:87::18) by PR3PR08MB5787.eurprd08.prod.outlook.com (2603:10a6:102:90::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.14; Fri, 11 Dec 2020 15:33:37 +0000 Received: from PR3PR08MB5564.eurprd08.prod.outlook.com ([fe80::ac13:db5:ef4:2dd2]) by PR3PR08MB5564.eurprd08.prod.outlook.com ([fe80::ac13:db5:ef4:2dd2%4]) with mapi id 15.20.3654.013; Fri, 11 Dec 2020 15:33:37 +0000 Date: Fri, 11 Dec 2020 15:33:34 +0000 From: Szabolcs Nagy To: Adhemerval Zanella Cc: libc-alpha@sourceware.org, Mark Rutland , kernel-hardening@lists.openwall.com, Catalin Marinas , linux-kernel@vger.kernel.org, Jeremy Linton , Mark Brown , Topi Miettinen , Will Deacon , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 1/6] aarch64: Fix missing BTI protection from dependencies [BZ #26926] Message-ID: <20201211153334.GF24625@arm.com> References: <8756cc1083eb4cd93d3766cd39b2f34b6623bbcb.1606319495.git.szabolcs.nagy@arm.com> Content-Type: multipart/mixed; boundary="OgqxwSJOaUobr8KG" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [217.140.106.54] X-ClientProxiedBy: LO2P123CA0052.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1::16) To PR3PR08MB5564.eurprd08.prod.outlook.com (2603:10a6:102:87::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from arm.com (217.140.106.54) by LO2P123CA0052.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12 via Frontend Transport; Fri, 11 Dec 2020 15:33:36 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 63389f69-eada-4446-804a-08d89dea2b63 X-MS-TrafficTypeDiagnostic: PR3PR08MB5787:|VI1PR0802MB2399: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: WyBCQ9Z7JYB7OJVKW/W7Mej6Tp1dRTMpXmTn9GlZGXtQrWpbVgqFxWx2Pgb4hWRX/KwegpA9WA1VPeh0NBTc+P3lRNCsenE1JbRKTc5f3ghKO7XkYKeoaCZ3fG7/FbdvfXJIjffW9Gg1gFHA1Qs/zT0zqaY02asHkYOCt4Bss1tQLPISd4wdyClilcX/bcDtoIY7Pxn/nPBHcUjLGIKgafyFcdVksGIEhp6/J19KuKy1GHZ55aT5AiIGVdcOlb3VU7tr1zopBILrsrqMV5NCWCkJgtyDkuZV0Dfwz5MN/bFB+w1Zek8n1t00YWmxo0zjd2QdDWl3pKw/Pdpmb2M3dlRPKbsHIdJqOE4pTX0xnOrMBLEvJPLwHv4oH/OSaRu2 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PR3PR08MB5564.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(376002)(346002)(396003)(39860400002)(366004)(66556008)(86362001)(316002)(66946007)(36756003)(66476007)(66616009)(6916009)(54906003)(33656002)(8886007)(4326008)(44144004)(55016002)(478600001)(2906002)(44832011)(956004)(2616005)(53546011)(33964004)(52116002)(7696005)(1076003)(235185007)(8936002)(5660300002)(8676002)(186003)(16526019)(26005)(2700100001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?Q0FoUTd4WFpPTzR5NTBjejFXbDF4dERXalNnQWVZY1hEcnpxU2gza2dTeVBq?= =?utf-8?B?cTVIYWRKTEVZYklDQ1p6SFhaRG1lZzEzdWoveGY0eDVuamRXR3ZkY1pycE1y?= =?utf-8?B?d2txamU2RXM5UUdlL3grblU0ZnU2RmNFNy9hc2hUa1JNaFhHWEIwd2xJSlM0?= =?utf-8?B?QVR1S1hyZHpzWWRCc0prMVE1NytVdjdaR2NzRUd4d205Y0g3QW1xUzBrcFJp?= =?utf-8?B?MmsvQ1kwY0Z5ck5aeVFRYSt5WEwwc0ozT2QzcWJEeXVTSHhXQkpDMS9oZG5r?= =?utf-8?B?anBjdE5GSE01c08wWHVoaWhwMFh1d3BOS09lSWdobXd6M3NHMEJPQTR2N1VZ?= =?utf-8?B?NFlUZ1RCRVVCZ0g4d0puNWw5amtEVTJvWGlseDNRRXdSeDRKU2pSQ216a0RW?= =?utf-8?B?Ky9WVXVWS3ZjREh0T2NjUnp0SFRMQzhBZHpyOEUra08rN1ZybHNLRk9WTmJX?= =?utf-8?B?OVNIRTFjcWI5NS95OGcxRTlVeWlZK0xuV0VhU1BVR3J5RElhRE1yL0ZaTFAy?= =?utf-8?B?cGc1TTVSWmdRbHgwU3gzd2MzUVFudlcxU3VKV2IwNFpZc1ZkNTR1OENYMVBp?= =?utf-8?B?SnpTUGZDS1U0NURoSllCR254eHd1cXhuYm9MYlBuMEx1NUVpUUlZSXppcXFp?= =?utf-8?B?b0tuam02aHRDMDlWUkdrNzJ5Q1FwSHB3Y2RZdmJyUFBMZ2JsY1drUHZNaENF?= =?utf-8?B?WGVVYWErU1YwTmVRYWVYanpvMU5XUjZWNmQwUjhZdGVDaXdzZzBOZ1BuTm1m?= =?utf-8?B?QktpZ21RNytaRE5wVXk3QlJjVkFORjN4ay9mUThRVVlGWnRSUVV3UllzTHV6?= =?utf-8?B?bkh5Q2U0MmZmcDl5MUFCTTdaS1Q0dTZkQWdrYjEvUENXei8zTUhOdEtCZjU4?= =?utf-8?B?N2ovdU9zSS9vSkR4c2xrN0FGZ0RFSER0cFZnVlFtaG0ra1pHeFF5dm4yTVNI?= =?utf-8?B?eG5OODh2UElRdlp2dmFlOTl3Z3MyQmVXQjZURzhzQzkwcjl0OGVUMUsrd21v?= =?utf-8?B?aFQ3NzQwbnIzdlVyelFYQ1d4d3YvQVhvN2JOV0Q2WUFuOXpFNnZYZzAzT0Fk?= =?utf-8?B?QjFLRDdsYnRmRnk0TTRpM3M5NVVaRHlaRFlSQlMrVEF5dzVkZzFmQ2pUV3Jm?= =?utf-8?B?SEd3SXMzREZEOWMwSTlpanFRcW9OR0YzM2dBTW9kMDNnZGE4cXRkYmRva1Bi?= =?utf-8?B?NGxyNnhRRzRVVVhtYzdlMzhUeFlXZlV1Rm1KVW1wNFU1bXJxR3hwekZHODdo?= =?utf-8?B?WFJ0eUxDNXhWSzMvKzZLVU5QQ2p2M2l0MEN3UmJNOVF0UENrZGM2dWpaZmJw?= =?utf-8?Q?bdaRGF1Nfy2UM1G6eoVx4lLE2W6mc184gi?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5787 Original-Authentication-Results: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: f4c32ce0-4f3a-47c2-ccbc-08d89dea20f3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XOVXROmvSwXL+J1YIcrBb5c4bWkHdEKF/MXq2+IxRnxL2z6DYOn1prAVOleTe14lJM+/NJQfrtyhRKDgWoRMgctj9VnYrEq0SLHFHgV9/ep5iOu2SU24Fpto2IiILJMctRBHqaDZmxpBqBReaeJLJMlqjQ/6O4cv+wV5tSUiN/JgPRJfYe6pPeFyvnKg3zzI1/qLcr30h3TfAVN/n/Ge0ZrNBX8E+nvDiUBAN+eBG8FbnOfIeEGODmV8NNj8imMDbVXV58MioOiJ4O+uP9r7SuS8hw9vQkVPK69c06QkHV13jikugeP+P5xuHVPVXbb0o+I+Lchq6cMyg+gRT4Bpofvf0pSuctrNbReojLqZPDtmh9Q08yqS51/E4yXjdTfoLCX1NoucdMxqGZo+EVd0VUheWu0m3lsYjmUfpjxEczY= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(376002)(396003)(136003)(346002)(39860400002)(46966005)(53546011)(44832011)(4326008)(33964004)(44144004)(54906003)(36756003)(7696005)(316002)(235185007)(1076003)(5660300002)(356005)(336012)(8676002)(82740400003)(478600001)(956004)(82310400003)(26005)(81166007)(70206006)(8886007)(6862004)(86362001)(107886003)(2616005)(33656002)(16526019)(66616009)(8936002)(2906002)(186003)(47076004)(55016002)(70586007)(2700100001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2020 15:33:54.8054 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 63389f69-eada-4446-804a-08d89dea2b63 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2399 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --OgqxwSJOaUobr8KG Content-Type: text/plain; charset=utf-8 Content-Disposition: inline The 12/10/2020 14:51, Adhemerval Zanella wrote: > On 27/11/2020 10:19, Szabolcs Nagy via Libc-alpha wrote: > > The _dl_open_check and _rtld_main_check hooks are not called on the > > dependencies of a loaded module, so BTI protection was missed on > > every module other than the main executable and directly dlopened > > libraries. > > > > The fix just iterates over dependencies to enable BTI. > > > > Fixes bug 26926. > > LGTM, modulus the argument name change. > > I also think it would be better to add a testcase, for both DT_NEEDED > and dlopen case. thanks, i committed this with fixed argument name as attached. i plan to do tests later once i understand the BTI semantics (right now it's not clear if in the presence of some W^X policy BTI may be silently ignored or not). --OgqxwSJOaUobr8KG Content-Type: text/x-diff; charset=utf-8 Content-Disposition: attachment; filename="0001-aarch64-Fix-missing-BTI-protection-from-dependencies.patch" >From 72739c79f61989a76b7dd719f34fcfb7b8eadde9 Mon Sep 17 00:00:00 2001 From: Szabolcs Nagy Date: Fri, 20 Nov 2020 15:27:06 +0000 Subject: [PATCH] aarch64: Fix missing BTI protection from dependencies [BZ #26926] The _dl_open_check and _rtld_main_check hooks are not called on the dependencies of a loaded module, so BTI protection was missed on every module other than the main executable and directly dlopened libraries. The fix just iterates over dependencies to enable BTI. Fixes bug 26926. --- sysdeps/aarch64/dl-bti.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/sysdeps/aarch64/dl-bti.c b/sysdeps/aarch64/dl-bti.c index 196e462520..56c097210a 100644 --- a/sysdeps/aarch64/dl-bti.c +++ b/sysdeps/aarch64/dl-bti.c @@ -51,11 +51,24 @@ enable_bti (struct link_map *map, const char *program) return 0; } -/* Enable BTI for L if required. */ +/* Enable BTI for L and its dependencies. */ void _dl_bti_check (struct link_map *l, const char *program) { - if (GLRO(dl_aarch64_cpu_features).bti && l->l_mach.bti) + if (!GLRO(dl_aarch64_cpu_features).bti) + return; + + if (l->l_mach.bti) enable_bti (l, program); + + unsigned int i = l->l_searchlist.r_nlist; + while (i-- > 0) + { + struct link_map *dep = l->l_initfini[i]; + if (dep->l_init_called) + continue; + if (dep->l_mach.bti) + enable_bti (dep, program); + } } -- 2.17.1 --OgqxwSJOaUobr8KG-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C641C4361B for ; Fri, 11 Dec 2020 15:35:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F14C423117 for ; Fri, 11 Dec 2020 15:35:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F14C423117 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: In-Reply-To:Content-Type:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ljcpFqw/1x1CboImX3k8ytZ8MVpUCzypv45VNxt+pmQ=; b=MFp3KwNAv3m1Eyhsokc/yZ95c v7ULtvv9Jp36f+xgCqJrw0fQp0VZr4oA66nd8kt8UfNOf2lq+E8aUFceCE3xwTcupWtrf6Bdw45s9 q1yBOyX3OtgIllMgpsRjd9VerypQ/GDe9JuFxEPQloeFYcY1eZhtXwdNCCZ4S6AOc7PZFloxUwvJe Vjvvpvhl4fGiux6vycb88YT0iX5Ccmw727nr6SmOJRVSNvt/bce53Y47LQbSNDLW8S+w0E/K6inQ/ h4hQxcC2LK6P7/Zd1nRHuKaJkat1ipqlKfIpbbfEoF1QeBw1DXsmSeHaIp++RNgu6V7bWRg1Tkn/z 9nFrAGKhg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1knkQi-0003fj-CR; Fri, 11 Dec 2020 15:34:00 +0000 Received: from mail-eopbgr20066.outbound.protection.outlook.com ([40.107.2.66] helo=EUR02-VE1-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1knkQf-0003fB-KI for linux-arm-kernel@lists.infradead.org; Fri, 11 Dec 2020 15:33:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M03DEdjmlCMQHLuGnBWpmQguDLRH/JE9YKLvUgpRPPk=; b=g7+GBUPqRrlOla5lmXYz1A2zCQSbOG9McZEWTo6zFl1MISgZgHm+294EHthaivNMwX2+CJzCxGidERfrelEwqEvP8BBp7CFsBaP6PttTZTad59KNC1XuBh79LiqI1DVywZFwzBQY1E45DM8ZpAWFyrhkkKAeYcn6YFSnDZwZ6II= Received: from DU2PR04CA0113.eurprd04.prod.outlook.com (2603:10a6:10:230::28) by AM0PR08MB5025.eurprd08.prod.outlook.com (2603:10a6:208:15e::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.19; Fri, 11 Dec 2020 15:33:54 +0000 Received: from DB5EUR03FT034.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:230:cafe::cd) by DU2PR04CA0113.outlook.office365.com (2603:10a6:10:230::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3611.22 via Frontend Transport; Fri, 11 Dec 2020 15:33:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.infradead.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.infradead.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT034.mail.protection.outlook.com (10.152.20.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12 via Frontend Transport; Fri, 11 Dec 2020 15:33:54 +0000 Received: ("Tessian outbound fc5cc0046d61:v71"); Fri, 11 Dec 2020 15:33:54 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 1dd39a4dd3283706 X-CR-MTA-TID: 64aa7808 Received: from cc51e005d193.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 59FD4E89-4EA8-4D34-B3D0-DEF1252AA1E8.1; Fri, 11 Dec 2020 15:33:38 +0000 Received: from EUR03-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cc51e005d193.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 11 Dec 2020 15:33:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JU+lj9oRPsYJhtOULEGrI4eLL6PmPJlUrb2ChCNBGy30KYeI83DyvgogeXiL/+L/ZinIfMgPH3GTkBYeqqZ/GGpabVQRIy6rPOt+X/t3xGkdf5sDhc0htU6ASjizgjN1rlyR+5I2SmEtKZ6poPiRjSdBtQwVFitmhKj2keSFpnlPe/Y6Z+tiML7YvFZVKZvb6i8CV3o3te7dfjhXGD4331fGaqXIoI7vX4HNKkkwalbEQ3JpTEQ3wDdxGbshawcxXfg6VzB0DVgbWNgbwJwGXffUUhDsP4172JHrdnq4lrOKmEPtHhdqclhfzij0h2sI0wWmckPu65UurfgQN71ZzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M03DEdjmlCMQHLuGnBWpmQguDLRH/JE9YKLvUgpRPPk=; b=Ht+80JMrYuCDMjtJlAn9I20pFwpBwlAf+9VJkKZHavjgRlvhqVuoYybpgT5EaIO+mv+mtt0yU3+dLxFpikAFcFCGTWY1UpPRIbpjsbYfZx6KG3K26Cp5TDVdJfXBNqe8+XpyT2+8usTixkzLM3DE9F8C89bp50K7vCQuCKhJPNvS7KJtgPamEznMYesxfTGwrjaiyKmA8KdEd3c5t5BCkGx3eoqURORRBOdoEkqDaKIuXWKybuRi9nIw7BLgc7S+5Wq1dKjX/v6tqsBG0YlB90qp50de9A2ioZ0k70OSLSKCJDV8uXXFtCT4dvg3G0Rh4+tMWbpEoyjr6AoHu1+Cgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M03DEdjmlCMQHLuGnBWpmQguDLRH/JE9YKLvUgpRPPk=; b=g7+GBUPqRrlOla5lmXYz1A2zCQSbOG9McZEWTo6zFl1MISgZgHm+294EHthaivNMwX2+CJzCxGidERfrelEwqEvP8BBp7CFsBaP6PttTZTad59KNC1XuBh79LiqI1DVywZFwzBQY1E45DM8ZpAWFyrhkkKAeYcn6YFSnDZwZ6II= Authentication-Results-Original: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=arm.com; Received: from PR3PR08MB5564.eurprd08.prod.outlook.com (2603:10a6:102:87::18) by PR3PR08MB5787.eurprd08.prod.outlook.com (2603:10a6:102:90::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.14; Fri, 11 Dec 2020 15:33:37 +0000 Received: from PR3PR08MB5564.eurprd08.prod.outlook.com ([fe80::ac13:db5:ef4:2dd2]) by PR3PR08MB5564.eurprd08.prod.outlook.com ([fe80::ac13:db5:ef4:2dd2%4]) with mapi id 15.20.3654.013; Fri, 11 Dec 2020 15:33:37 +0000 Date: Fri, 11 Dec 2020 15:33:34 +0000 From: Szabolcs Nagy To: Adhemerval Zanella Subject: Re: [PATCH v2 1/6] aarch64: Fix missing BTI protection from dependencies [BZ #26926] Message-ID: <20201211153334.GF24625@arm.com> References: <8756cc1083eb4cd93d3766cd39b2f34b6623bbcb.1606319495.git.szabolcs.nagy@arm.com> Content-Type: multipart/mixed; boundary="OgqxwSJOaUobr8KG" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [217.140.106.54] X-ClientProxiedBy: LO2P123CA0052.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1::16) To PR3PR08MB5564.eurprd08.prod.outlook.com (2603:10a6:102:87::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from arm.com (217.140.106.54) by LO2P123CA0052.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12 via Frontend Transport; Fri, 11 Dec 2020 15:33:36 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 059c138f-0806-4e22-4a23-08d89dea2b16 X-MS-TrafficTypeDiagnostic: PR3PR08MB5787:|AM0PR08MB5025: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: WyBCQ9Z7JYB7OJVKW/W7Mej6Tp1dRTMpXmTn9GlZGXtQrWpbVgqFxWx2Pgb4hWRX/KwegpA9WA1VPeh0NBTc+P3lRNCsenE1JbRKTc5f3ghKO7XkYKeoaCZ3fG7/FbdvfXJIjffW9Gg1gFHA1Qs/zT0zqaY02asHkYOCt4Bss1tQLPISd4wdyClilcX/bcDtoIY7Pxn/nPBHcUjLGIKgafyFcdVksGIEhp6/J19KuKy1GHZ55aT5AiIGVdcOlb3VU7tr1zopBILrsrqMV5NCWCkJgtyDkuZV0Dfwz5MN/bFB+w1Zek8n1t00YWmxo0zjd2QdDWl3pKw/Pdpmb2M3dlRPKbsHIdJqOE4pTX0xnOrMBLEvJPLwHv4oH/OSaRu2 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PR3PR08MB5564.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(376002)(346002)(396003)(39860400002)(366004)(66556008)(86362001)(316002)(66946007)(36756003)(66476007)(66616009)(6916009)(54906003)(33656002)(8886007)(4326008)(44144004)(55016002)(478600001)(2906002)(44832011)(956004)(2616005)(53546011)(33964004)(52116002)(7696005)(1076003)(235185007)(8936002)(5660300002)(8676002)(186003)(16526019)(26005)(2700100001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?Q0FoUTd4WFpPTzR5NTBjejFXbDF4dERXalNnQWVZY1hEcnpxU2gza2dTeVBq?= =?utf-8?B?cTVIYWRKTEVZYklDQ1p6SFhaRG1lZzEzdWoveGY0eDVuamRXR3ZkY1pycE1y?= =?utf-8?B?d2txamU2RXM5UUdlL3grblU0ZnU2RmNFNy9hc2hUa1JNaFhHWEIwd2xJSlM0?= =?utf-8?B?QVR1S1hyZHpzWWRCc0prMVE1NytVdjdaR2NzRUd4d205Y0g3QW1xUzBrcFJp?= =?utf-8?B?MmsvQ1kwY0Z5ck5aeVFRYSt5WEwwc0ozT2QzcWJEeXVTSHhXQkpDMS9oZG5r?= =?utf-8?B?anBjdE5GSE01c08wWHVoaWhwMFh1d3BOS09lSWdobXd6M3NHMEJPQTR2N1VZ?= =?utf-8?B?NFlUZ1RCRVVCZ0g4d0puNWw5amtEVTJvWGlseDNRRXdSeDRKU2pSQ216a0RW?= =?utf-8?B?Ky9WVXVWS3ZjREh0T2NjUnp0SFRMQzhBZHpyOEUra08rN1ZybHNLRk9WTmJX?= =?utf-8?B?OVNIRTFjcWI5NS95OGcxRTlVeWlZK0xuV0VhU1BVR3J5RElhRE1yL0ZaTFAy?= =?utf-8?B?cGc1TTVSWmdRbHgwU3gzd2MzUVFudlcxU3VKV2IwNFpZc1ZkNTR1OENYMVBp?= =?utf-8?B?SnpTUGZDS1U0NURoSllCR254eHd1cXhuYm9MYlBuMEx1NUVpUUlZSXppcXFp?= =?utf-8?B?b0tuam02aHRDMDlWUkdrNzJ5Q1FwSHB3Y2RZdmJyUFBMZ2JsY1drUHZNaENF?= =?utf-8?B?WGVVYWErU1YwTmVRYWVYanpvMU5XUjZWNmQwUjhZdGVDaXdzZzBOZ1BuTm1m?= =?utf-8?B?QktpZ21RNytaRE5wVXk3QlJjVkFORjN4ay9mUThRVVlGWnRSUVV3UllzTHV6?= =?utf-8?B?bkh5Q2U0MmZmcDl5MUFCTTdaS1Q0dTZkQWdrYjEvUENXei8zTUhOdEtCZjU4?= =?utf-8?B?N2ovdU9zSS9vSkR4c2xrN0FGZ0RFSER0cFZnVlFtaG0ra1pHeFF5dm4yTVNI?= =?utf-8?B?eG5OODh2UElRdlp2dmFlOTl3Z3MyQmVXQjZURzhzQzkwcjl0OGVUMUsrd21v?= =?utf-8?B?aFQ3NzQwbnIzdlVyelFYQ1d4d3YvQVhvN2JOV0Q2WUFuOXpFNnZYZzAzT0Fk?= =?utf-8?B?QjFLRDdsYnRmRnk0TTRpM3M5NVVaRHlaRFlSQlMrVEF5dzVkZzFmQ2pUV3Jm?= =?utf-8?B?SEd3SXMzREZEOWMwSTlpanFRcW9OR0YzM2dBTW9kMDNnZGE4cXRkYmRva1Bi?= =?utf-8?B?NGxyNnhRRzRVVVhtYzdlMzhUeFlXZlV1Rm1KVW1wNFU1bXJxR3hwekZHODdo?= =?utf-8?B?WFJ0eUxDNXhWSzMvKzZLVU5QQ2p2M2l0MEN3UmJNOVF0UENrZGM2dWpaZmJw?= =?utf-8?Q?bdaRGF1Nfy2UM1G6eoVx4lLE2W6mc184gi?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5787 Original-Authentication-Results: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT034.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: f4c32ce0-4f3a-47c2-ccbc-08d89dea20f3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Z9oVRivdqXK8fxeph4y6crxQjBaLUzinXFygIddvLMhD6Jf+T2H6/gFvknv1U3OgwLEuRZzZPHT1wDPYf5ghPiEK9N6xo2sptURyocD+LBIzEgLeM+dJPFfKl//VrPmfzmRyL92lKLivYcNCL/mtomPrCDs22ACLCgdRUTTQ+S0DRxM4Rs1h0epeMmRsCEIsDOQH4ohBco548v35m1PXBWudKuxcc9n/OQdNfdjKl2nitHjQfkzUBkx89PVv0CFCNbDmhdyIVVm+6EisAok/7AoTDz0g1ChI9fwE7gqwETe0b4IMnVETOXFfQx2YQ75MRRvf3HxMeitW6UtcejFdLCZI2OIibvfpfLRFk3ZcEau7eJj4rl/etZOeJUhgFTVHXi+9okvbv/eGXknaO+cvn0YMbyDTnmepz2BgjcsRCGE= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(136003)(396003)(346002)(39860400002)(376002)(46966005)(1076003)(956004)(478600001)(336012)(33656002)(235185007)(4326008)(36756003)(82740400003)(54906003)(55016002)(70206006)(82310400003)(5660300002)(70586007)(44832011)(356005)(6862004)(66616009)(86362001)(47076004)(44144004)(33964004)(8886007)(2616005)(7696005)(81166007)(53546011)(8936002)(316002)(16526019)(8676002)(186003)(26005)(2906002)(2700100001); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2020 15:33:54.3644 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 059c138f-0806-4e22-4a23-08d89dea2b16 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT034.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5025 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201211_103357_840219_D324D779 X-CRM114-Status: GOOD ( 21.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , libc-alpha@sourceware.org, kernel-hardening@lists.openwall.com, Catalin Marinas , linux-kernel@vger.kernel.org, Jeremy Linton , Mark Brown , Topi Miettinen , Will Deacon , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --OgqxwSJOaUobr8KG Content-Type: text/plain; charset=utf-8 Content-Disposition: inline The 12/10/2020 14:51, Adhemerval Zanella wrote: > On 27/11/2020 10:19, Szabolcs Nagy via Libc-alpha wrote: > > The _dl_open_check and _rtld_main_check hooks are not called on the > > dependencies of a loaded module, so BTI protection was missed on > > every module other than the main executable and directly dlopened > > libraries. > > > > The fix just iterates over dependencies to enable BTI. > > > > Fixes bug 26926. > > LGTM, modulus the argument name change. > > I also think it would be better to add a testcase, for both DT_NEEDED > and dlopen case. thanks, i committed this with fixed argument name as attached. i plan to do tests later once i understand the BTI semantics (right now it's not clear if in the presence of some W^X policy BTI may be silently ignored or not). --OgqxwSJOaUobr8KG Content-Type: text/x-diff; charset=utf-8 Content-Disposition: attachment; filename="0001-aarch64-Fix-missing-BTI-protection-from-dependencies.patch" >From 72739c79f61989a76b7dd719f34fcfb7b8eadde9 Mon Sep 17 00:00:00 2001 From: Szabolcs Nagy Date: Fri, 20 Nov 2020 15:27:06 +0000 Subject: [PATCH] aarch64: Fix missing BTI protection from dependencies [BZ #26926] The _dl_open_check and _rtld_main_check hooks are not called on the dependencies of a loaded module, so BTI protection was missed on every module other than the main executable and directly dlopened libraries. The fix just iterates over dependencies to enable BTI. Fixes bug 26926. --- sysdeps/aarch64/dl-bti.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/sysdeps/aarch64/dl-bti.c b/sysdeps/aarch64/dl-bti.c index 196e462520..56c097210a 100644 --- a/sysdeps/aarch64/dl-bti.c +++ b/sysdeps/aarch64/dl-bti.c @@ -51,11 +51,24 @@ enable_bti (struct link_map *map, const char *program) return 0; } -/* Enable BTI for L if required. */ +/* Enable BTI for L and its dependencies. */ void _dl_bti_check (struct link_map *l, const char *program) { - if (GLRO(dl_aarch64_cpu_features).bti && l->l_mach.bti) + if (!GLRO(dl_aarch64_cpu_features).bti) + return; + + if (l->l_mach.bti) enable_bti (l, program); + + unsigned int i = l->l_searchlist.r_nlist; + while (i-- > 0) + { + struct link_map *dep = l->l_initfini[i]; + if (dep->l_init_called) + continue; + if (dep->l_mach.bti) + enable_bti (dep, program); + } } -- 2.17.1 --OgqxwSJOaUobr8KG Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --OgqxwSJOaUobr8KG--