All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Vidya Sagar <vidyas@nvidia.com>,
	"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
	Jingoo Han <jingoohan1@gmail.com>,
	"gustavo.pimentel@synopsys.com" <gustavo.pimentel@synopsys.com>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	"amurray@thegoodpenguin.co.uk" <amurray@thegoodpenguin.co.uk>,
	"treding@nvidia.com" <treding@nvidia.com>,
	"jonathanh@nvidia.com" <jonathanh@nvidia.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kthota@nvidia.com" <kthota@nvidia.com>,
	"mmaddireddy@nvidia.com" <mmaddireddy@nvidia.com>,
	"sagar.tv@gmail.com" <sagar.tv@gmail.com>
Subject: Re: [PATCH V2] PCI: dwc: Add support to configure for ECRC
Date: Fri, 11 Dec 2020 10:54:40 -0600	[thread overview]
Message-ID: <20201211165440.GA80431@bjorn-Precision-5520> (raw)
In-Reply-To: <CAL_JsqK7EtRhGhd20P2raj1C4GLOoBQ55ngY+BvygRE-61E+9A@mail.gmail.com>

On Fri, Dec 11, 2020 at 08:49:16AM -0600, Rob Herring wrote:
> On Fri, Dec 11, 2020 at 7:58 AM Vidya Sagar <vidyas@nvidia.com> wrote:
> >
> > Hi Lorenzo,
> > Apologies to bug you, but wondering if you have any further comments on
> > this patch that I need to take care of?
> 
> You can check the status of your patches in Patchwork:
> 
> https://patchwork.kernel.org/project/linux-pci/patch/20201111121145.7015-1-vidyas@nvidia.com/
> 
> If it's in 'New' state and delegated to Lorenzo or Bjorn, it's in
> their queue. You can shorten the queue by reviewing stuff in front of
> you. :)

Thanks for pointing this out, this is exactly right.  I *love* it when
people help review things.  Obviously it saves me time, and often it
raises questions I would have missed.

Even "trivial" things like spelling, grammar, whitespace, subject line
formats, etc. help because they are distractions to me and I will
comment on them or spend time fixing them myself.  That doesn't mean
"repost immediately after somebody points out a typo"; it means
"collect feedback for a week or so, fix everything, *then* repost."

This is an old but still relevant list of some of my OCD tendencies
that take no special expertise to review for:
https://lore.kernel.org/linux-pci/20171026223701.GA25649@bhelgaas-glaptop.roam.corp.google.com/

  parent reply	other threads:[~2020-12-11 18:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-09 19:26 [PATCH] PCI: dwc: Add support to configure for ECRC Vidya Sagar
2020-11-10 20:50 ` Bjorn Helgaas
2020-11-11 12:11 ` [PATCH V2] " Vidya Sagar
2020-11-11 16:27   ` Jingoo Han
2020-11-11 16:51     ` Vidya Sagar
2020-11-11 22:29       ` Bjorn Helgaas
2020-11-12 17:02         ` Vidya Sagar
2020-11-24 10:20           ` Vidya Sagar
2020-11-24 21:02             ` Bjorn Helgaas
2020-12-03 12:10               ` Vidya Sagar
2020-12-11 13:58                 ` Vidya Sagar
2020-12-11 14:49                   ` Rob Herring
2020-12-11 15:15                     ` Lorenzo Pieralisi
2020-12-11 16:54                     ` Bjorn Helgaas [this message]
2020-12-11 17:17                       ` Rob Herring
2020-12-07 14:18 ` [PATCH] " Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201211165440.GA80431@bjorn-Precision-5520 \
    --to=helgaas@kernel.org \
    --cc=amurray@thegoodpenguin.co.uk \
    --cc=bhelgaas@google.com \
    --cc=gustavo.pimentel@synopsys.com \
    --cc=jingoohan1@gmail.com \
    --cc=jonathanh@nvidia.com \
    --cc=kthota@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=mmaddireddy@nvidia.com \
    --cc=robh@kernel.org \
    --cc=sagar.tv@gmail.com \
    --cc=treding@nvidia.com \
    --cc=vidyas@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.