From: Nathan Chancellor <natechancellor@gmail.com>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Anders Roxell <anders.roxell@linaro.org>,
tsbogend@alpha.franken.de, ndesaulniers@google.com,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
clang-built-linux@googlegroups.com
Subject: Re: [PATCH v2] mips: lib: uncached: fix non-standard usage of variable 'sp'
Date: Fri, 11 Dec 2020 22:52:28 -0700 [thread overview]
Message-ID: <20201212055228.GA823758@ubuntu-m3-large-x86> (raw)
In-Reply-To: <alpine.LFD.2.21.2012111950290.2104409@eddie.linux-mips.org>
On Fri, Dec 11, 2020 at 07:54:07PM +0000, Maciej W. Rozycki wrote:
> On Fri, 11 Dec 2020, Anders Roxell wrote:
>
> > diff --git a/arch/mips/lib/uncached.c b/arch/mips/lib/uncached.c
> > index 09d5deea747f..f80a67c092b6 100644
> > --- a/arch/mips/lib/uncached.c
> > +++ b/arch/mips/lib/uncached.c
> > @@ -37,10 +37,12 @@
> > */
> > unsigned long run_uncached(void *func)
> > {
> > - register long sp __asm__("$sp");
> > register long ret __asm__("$2");
> > long lfunc = (long)func, ufunc;
> > long usp;
> > + long sp;
> > +
> > + __asm__("move %0, $sp" : "=r" (sp));
>
> I thought it might be better to make `sp' global instead, so that it's
> the compiler that chooses how to schedule accesses. Have you tried that?
>
> Maciej
This will not work, as the LLVM Mips backend does not support using $sp
as a global register variable:
https://github.com/llvm/llvm-project/commit/1440bb2a26ff13df1b29762658ee122cc0bc47ae
$ make -skj"$(nproc)" ARCH=mips CROSS_COMPILE=mipsel-linux-gnu- LLVM=1 O=out \
distclean malta_kvm_guest_defconfig vmlinux
fatal error: error in backend: Invalid register name global variable
...
Cheers,
Nathan
next prev parent reply other threads:[~2020-12-12 5:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 10:24 [PATCH v2] mips: lib: uncached: fix non-standard usage of variable 'sp' Anders Roxell
2020-12-11 19:15 ` Nick Desaulniers
2020-12-11 19:54 ` Maciej W. Rozycki
2020-12-12 5:52 ` Nathan Chancellor [this message]
2020-12-14 15:24 ` Thomas Bogendoerfer
2020-12-20 4:07 ` Naresh Kamboju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201212055228.GA823758@ubuntu-m3-large-x86 \
--to=natechancellor@gmail.com \
--cc=anders.roxell@linaro.org \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=ndesaulniers@google.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.