From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99984C4361B for ; Sun, 13 Dec 2020 14:12:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6705C22D2C for ; Sun, 13 Dec 2020 14:12:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437034AbgLMOLu (ORCPT ); Sun, 13 Dec 2020 09:11:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:37708 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2395199AbgLMOLL (ORCPT ); Sun, 13 Dec 2020 09:11:11 -0500 Date: Sun, 13 Dec 2020 09:10:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607868630; bh=S0NZCKTHXO1/XgTBibTeHKY2NyaV+jWp9oZjgvuSOZg=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=nFttyLKxDFdTzDqG+uV+ZMYwIDraCwmT1csa8RGjNQtB2KNQuC3CWvsr8XvQHFTkX bOVfEZ3hZGq/q87besC+Bjzp/UHT9BZ6/avesb9g234GUTyQ6mz9ZdKVWLvvWayKcR 5IsZC3of1cWOok1XpWOR2jKmC5sWYP7UWQbjwfCJNcyT1mEousS3/8Iz7qmQngrF+E UBfwNFX/Xim1w8qNAQxV89tayOf16Xozhta7DOpqMYNyp+n+eIU7Y985xkZoMGJ7UI W/Q6SnFz+H4jXIWSjxGFg8FVH/fANHjQkaleEJRhOabM6QD83DoUX7CgAE554wRsQU Zom91bCLKheaA== From: Sasha Levin To: Peter Zijlstra Cc: Heiko Carstens , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Sven Schnelle , Mark Rutland , linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, uclinux-h8-devel@lists.sourceforge.jp, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org Subject: Re: [PATCH AUTOSEL 5.9 27/39] sched/idle: Fix arch_cpu_idle() vs tracing Message-ID: <20201213141029.GQ643756@sasha-vm> References: <20201203132834.930999-1-sashal@kernel.org> <20201203132834.930999-27-sashal@kernel.org> <20201203145442.GC9994@osiris> <20201203171015.GN2414@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20201203171015.GN2414@hirez.programming.kicks-ass.net> Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org On Thu, Dec 03, 2020 at 06:10:15PM +0100, Peter Zijlstra wrote: >On Thu, Dec 03, 2020 at 03:54:42PM +0100, Heiko Carstens wrote: >> On Thu, Dec 03, 2020 at 08:28:21AM -0500, Sasha Levin wrote: >> > From: Peter Zijlstra >> > >> > [ Upstream commit 58c644ba512cfbc2e39b758dd979edd1d6d00e27 ] >> > >> > We call arch_cpu_idle() with RCU disabled, but then use >> > local_irq_{en,dis}able(), which invokes tracing, which relies on RCU. >> > >> > Switch all arch_cpu_idle() implementations to use >> > raw_local_irq_{en,dis}able() and carefully manage the >> > lockdep,rcu,tracing state like we do in entry. >> > >> > (XXX: we really should change arch_cpu_idle() to not return with >> > interrupts enabled) >> > >> > Reported-by: Sven Schnelle >> > Signed-off-by: Peter Zijlstra (Intel) >> > Reviewed-by: Mark Rutland >> > Tested-by: Mark Rutland >> > Link: https://lkml.kernel.org/r/20201120114925.594122626@infradead.org >> > Signed-off-by: Sasha Levin >> >> This patch broke s390 irq state tracing. A patch to fix this is >> scheduled to be merged upstream today (hopefully). >> Therefore I think this patch should not yet go into 5.9 stable. > >Agreed. I'll also grab b1cae1f84a0f ("s390: fix irq state tracing"). Thanks! -- Thanks, Sasha From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Date: Sun, 13 Dec 2020 14:10:29 +0000 Subject: Re: [PATCH AUTOSEL 5.9 27/39] sched/idle: Fix arch_cpu_idle() vs tracing Message-Id: <20201213141029.GQ643756@sasha-vm> List-Id: References: <20201203132834.930999-1-sashal@kernel.org> <20201203132834.930999-27-sashal@kernel.org> <20201203145442.GC9994@osiris> <20201203171015.GN2414@hirez.programming.kicks-ass.net> In-Reply-To: <20201203171015.GN2414@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Peter Zijlstra Cc: Mark Rutland , uclinux-h8-devel@lists.sourceforge.jp, linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org, linux-hexagon@vger.kernel.org, Heiko Carstens , linux-sh@vger.kernel.org, linux-um@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-csky@vger.kernel.org, Sven Schnelle , linux-alpha@vger.kernel.org, sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org On Thu, Dec 03, 2020 at 06:10:15PM +0100, Peter Zijlstra wrote: >On Thu, Dec 03, 2020 at 03:54:42PM +0100, Heiko Carstens wrote: >> On Thu, Dec 03, 2020 at 08:28:21AM -0500, Sasha Levin wrote: >> > From: Peter Zijlstra >> > >> > [ Upstream commit 58c644ba512cfbc2e39b758dd979edd1d6d00e27 ] >> > >> > We call arch_cpu_idle() with RCU disabled, but then use >> > local_irq_{en,dis}able(), which invokes tracing, which relies on RCU. >> > >> > Switch all arch_cpu_idle() implementations to use >> > raw_local_irq_{en,dis}able() and carefully manage the >> > lockdep,rcu,tracing state like we do in entry. >> > >> > (XXX: we really should change arch_cpu_idle() to not return with >> > interrupts enabled) >> > >> > Reported-by: Sven Schnelle >> > Signed-off-by: Peter Zijlstra (Intel) >> > Reviewed-by: Mark Rutland >> > Tested-by: Mark Rutland >> > Link: https://lkml.kernel.org/r/20201120114925.594122626@infradead.org >> > Signed-off-by: Sasha Levin >> >> This patch broke s390 irq state tracing. A patch to fix this is >> scheduled to be merged upstream today (hopefully). >> Therefore I think this patch should not yet go into 5.9 stable. > >Agreed. I'll also grab b1cae1f84a0f ("s390: fix irq state tracing"). Thanks! -- Thanks, Sasha From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18621C433FE for ; Sun, 13 Dec 2020 14:10:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AD04B22D2C for ; Sun, 13 Dec 2020 14:10:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD04B22D2C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KZAmvMM7JxP7sn7KQINptYnNCbsp1o2c0NUu2YK8A1w=; b=R26POXAfWoeH7w4cnouDF/Yha hDZgjYp16roJftTpjlM732uN1xadbdREH3fgogkw7dXDPK4drxr4nPtw1uPXJmYp8AKV5HWCBKw4K HCThFV9D5x9qKT3KL915192D9LweVhb4ypF07Pwr4zcCil5yNO8KOcm1a+a1yw/AhHY5lr3IudJSi UOF3vXudTGTyLVIxo2Y2ENcnDbseOszXNYpWniDt5dEYw9MHissZdhtCmwzr9ss4He03z+4qlXgqg V+guKgnLnHHwQzYSG/BKCgop6PkOiDplXzq7F+5fwbgr7sGsO8rR/QP9gYnorKMolbt30DDHwTOF+ 4k/peP/7A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1koS55-0001xr-Na; Sun, 13 Dec 2020 14:10:35 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1koS51-0001ww-7A; Sun, 13 Dec 2020 14:10:32 +0000 Date: Sun, 13 Dec 2020 09:10:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607868630; bh=S0NZCKTHXO1/XgTBibTeHKY2NyaV+jWp9oZjgvuSOZg=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=nFttyLKxDFdTzDqG+uV+ZMYwIDraCwmT1csa8RGjNQtB2KNQuC3CWvsr8XvQHFTkX bOVfEZ3hZGq/q87besC+Bjzp/UHT9BZ6/avesb9g234GUTyQ6mz9ZdKVWLvvWayKcR 5IsZC3of1cWOok1XpWOR2jKmC5sWYP7UWQbjwfCJNcyT1mEousS3/8Iz7qmQngrF+E UBfwNFX/Xim1w8qNAQxV89tayOf16Xozhta7DOpqMYNyp+n+eIU7Y985xkZoMGJ7UI W/Q6SnFz+H4jXIWSjxGFg8FVH/fANHjQkaleEJRhOabM6QD83DoUX7CgAE554wRsQU Zom91bCLKheaA== From: Sasha Levin To: Peter Zijlstra Subject: Re: [PATCH AUTOSEL 5.9 27/39] sched/idle: Fix arch_cpu_idle() vs tracing Message-ID: <20201213141029.GQ643756@sasha-vm> References: <20201203132834.930999-1-sashal@kernel.org> <20201203132834.930999-27-sashal@kernel.org> <20201203145442.GC9994@osiris> <20201203171015.GN2414@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201203171015.GN2414@hirez.programming.kicks-ass.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201213_091031_388952_6D996A1E X-CRM114-Status: GOOD ( 14.01 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , uclinux-h8-devel@lists.sourceforge.jp, linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org, linux-hexagon@vger.kernel.org, Heiko Carstens , linux-sh@vger.kernel.org, linux-um@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-csky@vger.kernel.org, Sven Schnelle , linux-alpha@vger.kernel.org, sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Thu, Dec 03, 2020 at 06:10:15PM +0100, Peter Zijlstra wrote: >On Thu, Dec 03, 2020 at 03:54:42PM +0100, Heiko Carstens wrote: >> On Thu, Dec 03, 2020 at 08:28:21AM -0500, Sasha Levin wrote: >> > From: Peter Zijlstra >> > >> > [ Upstream commit 58c644ba512cfbc2e39b758dd979edd1d6d00e27 ] >> > >> > We call arch_cpu_idle() with RCU disabled, but then use >> > local_irq_{en,dis}able(), which invokes tracing, which relies on RCU. >> > >> > Switch all arch_cpu_idle() implementations to use >> > raw_local_irq_{en,dis}able() and carefully manage the >> > lockdep,rcu,tracing state like we do in entry. >> > >> > (XXX: we really should change arch_cpu_idle() to not return with >> > interrupts enabled) >> > >> > Reported-by: Sven Schnelle >> > Signed-off-by: Peter Zijlstra (Intel) >> > Reviewed-by: Mark Rutland >> > Tested-by: Mark Rutland >> > Link: https://lkml.kernel.org/r/20201120114925.594122626@infradead.org >> > Signed-off-by: Sasha Levin >> >> This patch broke s390 irq state tracing. A patch to fix this is >> scheduled to be merged upstream today (hopefully). >> Therefore I think this patch should not yet go into 5.9 stable. > >Agreed. I'll also grab b1cae1f84a0f ("s390: fix irq state tracing"). Thanks! -- Thanks, Sasha _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: Re: [PATCH AUTOSEL 5.9 27/39] sched/idle: Fix arch_cpu_idle() vs tracing Date: Sun, 13 Dec 2020 09:10:29 -0500 Message-ID: <20201213141029.GQ643756@sasha-vm> References: <20201203132834.930999-1-sashal@kernel.org> <20201203132834.930999-27-sashal@kernel.org> <20201203145442.GC9994@osiris> <20201203171015.GN2414@hirez.programming.kicks-ass.net> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KZAmvMM7JxP7sn7KQINptYnNCbsp1o2c0NUu2YK8A1w=; b=R26POXAfWoeH7w4cnouDF/Yha hDZgjYp16roJftTpjlM732uN1xadbdREH3fgogkw7dXDPK4drxr4nPtw1uPXJmYp8AKV5HWCBKw4K HCThFV9D5x9qKT3KL915192D9LweVhb4ypF07Pwr4zcCil5yNO8KOcm1a+a1yw/AhHY5lr3IudJSi UOF3vXudTGTyLVIxo2Y2ENcnDbseOszXNYpWniDt5dEYw9MHissZdhtCmwzr9ss4He03z+4qlXgqg V+guKgnLnHHwQzYSG/BKCgop6PkOiDplXzq7F+5fwbgr7sGsO8rR/QP9gYnorKMolbt30DDHwTOF+ 4k/peP/7A==; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607868630; bh=S0NZCKTHXO1/XgTBibTeHKY2NyaV+jWp9oZjgvuSOZg=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=nFttyLKxDFdTzDqG+uV+ZMYwIDraCwmT1csa8RGjNQtB2KNQuC3CWvsr8XvQHFTkX bOVfEZ3hZGq/q87besC+Bjzp/UHT9BZ6/avesb9g234GUTyQ6mz9ZdKVWLvvWayKcR 5IsZC3of1cWOok1XpWOR2jKmC5sWYP7UWQbjwfCJNcyT1mEousS3/8Iz7qmQngrF+E UBfwNFX/Xim1w8qNAQxV89tayOf16Xozhta7DOpqMYNyp+n+eIU7Y985xkZoMGJ7UI W/Q6SnFz+H4jXIWSjxGFg8FVH/fANHjQkaleEJRhOabM6QD83DoUX7CgAE554wRsQU Zom91bCLKheaA== Content-Disposition: inline In-Reply-To: <20201203171015.GN2414@hirez.programming.kicks-ass.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+glpr-linux-riscv=m.gmane-mx.org@lists.infradead.org Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Peter Zijlstra Cc: Mark Rutland , uclinux-h8-devel@lists.sourceforge.jp, linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org, linux-hexagon@vger.kernel.org, Heiko Carstens , linux-sh@vger.kernel.org, linux-um@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-csky@vger.kernel.org, Sven Schnelle , linux-alpha@vger.kernel.org, sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org On Thu, Dec 03, 2020 at 06:10:15PM +0100, Peter Zijlstra wrote: >On Thu, Dec 03, 2020 at 03:54:42PM +0100, Heiko Carstens wrote: >> On Thu, Dec 03, 2020 at 08:28:21AM -0500, Sasha Levin wrote: >> > From: Peter Zijlstra >> > >> > [ Upstream commit 58c644ba512cfbc2e39b758dd979edd1d6d00e27 ] >> > >> > We call arch_cpu_idle() with RCU disabled, but then use >> > local_irq_{en,dis}able(), which invokes tracing, which relies on RCU. >> > >> > Switch all arch_cpu_idle() implementations to use >> > raw_local_irq_{en,dis}able() and carefully manage the >> > lockdep,rcu,tracing state like we do in entry. >> > >> > (XXX: we really should change arch_cpu_idle() to not return with >> > interrupts enabled) >> > >> > Reported-by: Sven Schnelle >> > Signed-off-by: Peter Zijlstra (Intel) >> > Reviewed-by: Mark Rutland >> > Tested-by: Mark Rutland >> > Link: https://lkml.kernel.org/r/20201120114925.594122626@infradead.org >> > Signed-off-by: Sasha Levin >> >> This patch broke s390 irq state tracing. A patch to fix this is >> scheduled to be merged upstream today (hopefully). >> Therefore I think this patch should not yet go into 5.9 stable. > >Agreed. I'll also grab b1cae1f84a0f ("s390: fix irq state tracing"). Thanks! -- Thanks, Sasha From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E152EC433FE for ; Sun, 13 Dec 2020 14:12:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A97422D2B for ; Sun, 13 Dec 2020 14:12:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A97422D2B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vMOFCAX5/z7bhkdtaZFTeZptu9SejahERt9myjCUKF0=; b=LCzMwmAfmp+hFnCT3gk0f/qoY Q/6e0aP/MP/6k4kC9C5QDecSfXCMKhnImnmk88t2Vf+pCyi9QtewVbW4ypw/B6qdKisj0Mnt0Xl7V 390U9WZ3vQnJksNL3GWIUtU2iQdl7s7NYE/0hBibN39J1RUPL8Ysr4H2PkdEAwIYcz0w7b30woY8U MjULMj2ndAdQqfgcXR6155aI7j4X8a6YxbJ7CO1Uzc2enhViqtZ8unQ8ycV6gmbCRzeLg4bT0FRNS zNPbVCxt/R4+GRdTDBqyarXq5GzN5Su3YxBK24Sh/AClcHKb7ABOtRsZmwVVHIoyfRTg2uw8CRCHj ZqPlJfrfA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1koS53-0001xe-Q1; Sun, 13 Dec 2020 14:10:33 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1koS51-0001ww-7A; Sun, 13 Dec 2020 14:10:32 +0000 Date: Sun, 13 Dec 2020 09:10:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607868630; bh=S0NZCKTHXO1/XgTBibTeHKY2NyaV+jWp9oZjgvuSOZg=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=nFttyLKxDFdTzDqG+uV+ZMYwIDraCwmT1csa8RGjNQtB2KNQuC3CWvsr8XvQHFTkX bOVfEZ3hZGq/q87besC+Bjzp/UHT9BZ6/avesb9g234GUTyQ6mz9ZdKVWLvvWayKcR 5IsZC3of1cWOok1XpWOR2jKmC5sWYP7UWQbjwfCJNcyT1mEousS3/8Iz7qmQngrF+E UBfwNFX/Xim1w8qNAQxV89tayOf16Xozhta7DOpqMYNyp+n+eIU7Y985xkZoMGJ7UI W/Q6SnFz+H4jXIWSjxGFg8FVH/fANHjQkaleEJRhOabM6QD83DoUX7CgAE554wRsQU Zom91bCLKheaA== From: Sasha Levin To: Peter Zijlstra Subject: Re: [PATCH AUTOSEL 5.9 27/39] sched/idle: Fix arch_cpu_idle() vs tracing Message-ID: <20201213141029.GQ643756@sasha-vm> References: <20201203132834.930999-1-sashal@kernel.org> <20201203132834.930999-27-sashal@kernel.org> <20201203145442.GC9994@osiris> <20201203171015.GN2414@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201203171015.GN2414@hirez.programming.kicks-ass.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201213_091031_388952_6D996A1E X-CRM114-Status: GOOD ( 14.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , uclinux-h8-devel@lists.sourceforge.jp, linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org, linux-hexagon@vger.kernel.org, Heiko Carstens , linux-sh@vger.kernel.org, linux-um@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-csky@vger.kernel.org, Sven Schnelle , linux-alpha@vger.kernel.org, sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Dec 03, 2020 at 06:10:15PM +0100, Peter Zijlstra wrote: >On Thu, Dec 03, 2020 at 03:54:42PM +0100, Heiko Carstens wrote: >> On Thu, Dec 03, 2020 at 08:28:21AM -0500, Sasha Levin wrote: >> > From: Peter Zijlstra >> > >> > [ Upstream commit 58c644ba512cfbc2e39b758dd979edd1d6d00e27 ] >> > >> > We call arch_cpu_idle() with RCU disabled, but then use >> > local_irq_{en,dis}able(), which invokes tracing, which relies on RCU. >> > >> > Switch all arch_cpu_idle() implementations to use >> > raw_local_irq_{en,dis}able() and carefully manage the >> > lockdep,rcu,tracing state like we do in entry. >> > >> > (XXX: we really should change arch_cpu_idle() to not return with >> > interrupts enabled) >> > >> > Reported-by: Sven Schnelle >> > Signed-off-by: Peter Zijlstra (Intel) >> > Reviewed-by: Mark Rutland >> > Tested-by: Mark Rutland >> > Link: https://lkml.kernel.org/r/20201120114925.594122626@infradead.org >> > Signed-off-by: Sasha Levin >> >> This patch broke s390 irq state tracing. A patch to fix this is >> scheduled to be merged upstream today (hopefully). >> Therefore I think this patch should not yet go into 5.9 stable. > >Agreed. I'll also grab b1cae1f84a0f ("s390: fix irq state tracing"). Thanks! -- Thanks, Sasha _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Date: Sun, 13 Dec 2020 09:10:29 -0500 Subject: [OpenRISC] [PATCH AUTOSEL 5.9 27/39] sched/idle: Fix arch_cpu_idle() vs tracing In-Reply-To: <20201203171015.GN2414@hirez.programming.kicks-ass.net> References: <20201203132834.930999-1-sashal@kernel.org> <20201203132834.930999-27-sashal@kernel.org> <20201203145442.GC9994@osiris> <20201203171015.GN2414@hirez.programming.kicks-ass.net> Message-ID: <20201213141029.GQ643756@sasha-vm> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: openrisc@lists.librecores.org On Thu, Dec 03, 2020 at 06:10:15PM +0100, Peter Zijlstra wrote: >On Thu, Dec 03, 2020 at 03:54:42PM +0100, Heiko Carstens wrote: >> On Thu, Dec 03, 2020 at 08:28:21AM -0500, Sasha Levin wrote: >> > From: Peter Zijlstra >> > >> > [ Upstream commit 58c644ba512cfbc2e39b758dd979edd1d6d00e27 ] >> > >> > We call arch_cpu_idle() with RCU disabled, but then use >> > local_irq_{en,dis}able(), which invokes tracing, which relies on RCU. >> > >> > Switch all arch_cpu_idle() implementations to use >> > raw_local_irq_{en,dis}able() and carefully manage the >> > lockdep,rcu,tracing state like we do in entry. >> > >> > (XXX: we really should change arch_cpu_idle() to not return with >> > interrupts enabled) >> > >> > Reported-by: Sven Schnelle >> > Signed-off-by: Peter Zijlstra (Intel) >> > Reviewed-by: Mark Rutland >> > Tested-by: Mark Rutland >> > Link: https://lkml.kernel.org/r/20201120114925.594122626 at infradead.org >> > Signed-off-by: Sasha Levin >> >> This patch broke s390 irq state tracing. A patch to fix this is >> scheduled to be merged upstream today (hopefully). >> Therefore I think this patch should not yet go into 5.9 stable. > >Agreed. I'll also grab b1cae1f84a0f ("s390: fix irq state tracing"). Thanks! -- Thanks, Sasha From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sun, 13 Dec 2020 09:10:29 -0500 From: Sasha Levin Subject: Re: [PATCH AUTOSEL 5.9 27/39] sched/idle: Fix arch_cpu_idle() vs tracing Message-ID: <20201213141029.GQ643756@sasha-vm> References: <20201203132834.930999-1-sashal@kernel.org> <20201203132834.930999-27-sashal@kernel.org> <20201203145442.GC9994@osiris> <20201203171015.GN2414@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201203171015.GN2414@hirez.programming.kicks-ass.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Peter Zijlstra Cc: Mark Rutland , uclinux-h8-devel@lists.sourceforge.jp, linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org, linux-hexagon@vger.kernel.org, Heiko Carstens , linux-sh@vger.kernel.org, linux-um@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-csky@vger.kernel.org, Sven Schnelle , linux-alpha@vger.kernel.org, sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org On Thu, Dec 03, 2020 at 06:10:15PM +0100, Peter Zijlstra wrote: >On Thu, Dec 03, 2020 at 03:54:42PM +0100, Heiko Carstens wrote: >> On Thu, Dec 03, 2020 at 08:28:21AM -0500, Sasha Levin wrote: >> > From: Peter Zijlstra >> > >> > [ Upstream commit 58c644ba512cfbc2e39b758dd979edd1d6d00e27 ] >> > >> > We call arch_cpu_idle() with RCU disabled, but then use >> > local_irq_{en,dis}able(), which invokes tracing, which relies on RCU. >> > >> > Switch all arch_cpu_idle() implementations to use >> > raw_local_irq_{en,dis}able() and carefully manage the >> > lockdep,rcu,tracing state like we do in entry. >> > >> > (XXX: we really should change arch_cpu_idle() to not return with >> > interrupts enabled) >> > >> > Reported-by: Sven Schnelle >> > Signed-off-by: Peter Zijlstra (Intel) >> > Reviewed-by: Mark Rutland >> > Tested-by: Mark Rutland >> > Link: https://lkml.kernel.org/r/20201120114925.594122626@infradead.org >> > Signed-off-by: Sasha Levin >> >> This patch broke s390 irq state tracing. A patch to fix this is >> scheduled to be merged upstream today (hopefully). >> Therefore I think this patch should not yet go into 5.9 stable. > >Agreed. I'll also grab b1cae1f84a0f ("s390: fix irq state tracing"). Thanks! -- Thanks, Sasha _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Date: Sun, 13 Dec 2020 14:10:29 +0000 Subject: Re: [PATCH AUTOSEL 5.9 27/39] sched/idle: Fix arch_cpu_idle() vs tracing Message-Id: <20201213141029.GQ643756@sasha-vm> List-Id: References: <20201203132834.930999-1-sashal@kernel.org> <20201203132834.930999-27-sashal@kernel.org> <20201203145442.GC9994@osiris> <20201203171015.GN2414@hirez.programming.kicks-ass.net> In-Reply-To: <20201203171015.GN2414@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Peter Zijlstra Cc: Heiko Carstens , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Sven Schnelle , Mark Rutland , linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, uclinux-h8-devel@lists.sourceforge.jp, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org On Thu, Dec 03, 2020 at 06:10:15PM +0100, Peter Zijlstra wrote: >On Thu, Dec 03, 2020 at 03:54:42PM +0100, Heiko Carstens wrote: >> On Thu, Dec 03, 2020 at 08:28:21AM -0500, Sasha Levin wrote: >> > From: Peter Zijlstra >> > >> > [ Upstream commit 58c644ba512cfbc2e39b758dd979edd1d6d00e27 ] >> > >> > We call arch_cpu_idle() with RCU disabled, but then use >> > local_irq_{en,dis}able(), which invokes tracing, which relies on RCU. >> > >> > Switch all arch_cpu_idle() implementations to use >> > raw_local_irq_{en,dis}able() and carefully manage the >> > lockdep,rcu,tracing state like we do in entry. >> > >> > (XXX: we really should change arch_cpu_idle() to not return with >> > interrupts enabled) >> > >> > Reported-by: Sven Schnelle >> > Signed-off-by: Peter Zijlstra (Intel) >> > Reviewed-by: Mark Rutland >> > Tested-by: Mark Rutland >> > Link: https://lkml.kernel.org/r/20201120114925.594122626@infradead.org >> > Signed-off-by: Sasha Levin >> >> This patch broke s390 irq state tracing. A patch to fix this is >> scheduled to be merged upstream today (hopefully). >> Therefore I think this patch should not yet go into 5.9 stable. > >Agreed. I'll also grab b1cae1f84a0f ("s390: fix irq state tracing"). Thanks! -- Thanks, Sasha