All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Wagner <dwagner@suse.de>
To: John Kacur <jkacur@redhat.com>
Cc: RT <linux-rt-users@vger.kernel.org>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	Clark Williams <williams@redhat.com>
Subject: Re: [PATCH 1/3] rt-tests: determine_maximum_mpps.sh: Add a menu to get user settings.
Date: Mon, 14 Dec 2020 10:30:49 +0100	[thread overview]
Message-ID: <20201214093049.pl2guoij4kjw2ifc@beryllium.lan> (raw)
In-Reply-To: <20201209183100.16836-1-jkacur@redhat.com>

Hi John,

On Wed, Dec 09, 2020 at 01:30:58PM -0500, John Kacur wrote:
> Incorporate the functionality of the get_cpuinfo_mhz.sh script into
> determine_maximum_mpps.sh so that get_cpuinfo_mhz.sh can be removed.
> 
> Currently determine_maximum_mpps.sh (part of queuelat) asks the user
> to edit the PREAMBLE in the script to set the environment.
> 
> Get rid of this by creating a menu that allows the user the set these
> variables from a menu when running the script.
> 
> Here is the output from running the script with the -h option
> 
> ./src/queuelat/determine_maximum_mpps.sh -h
> Usage:
> determine_maximum_mpps.sh [OPTIONS]
> 
> -c cpulist
> 	List of processors to run on. The default is processor 0
> 	Numbers are separated by commas and may include ranges. Eg. 0,3,7-11

Does the option also do CPU affinity. In this case I would suggest to
use '-a' to go with the pattern.

What about long options? Long options are propably a bit harder to
implement in shell but it would be good in my opinion to keep all those
tests commands as close as possible.

Thanks,
Daniel


  parent reply	other threads:[~2020-12-14  9:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-09 18:30 [PATCH 1/3] rt-tests: determine_maximum_mpps.sh: Add a menu to get user settings John Kacur
2020-12-09 18:30 ` [PATCH 2/3] rt-tests: queuelat: Remove get_cpuinfo_mhz.sh and old Makefile John Kacur
2020-12-09 18:31 ` [PATCH 3/3] rt-tests: queuelat: Add a manpage for determine_maximum_mpps.sh John Kacur
2020-12-14  9:30 ` Daniel Wagner [this message]
2020-12-16  6:22   ` [PATCH 1/3] rt-tests: determine_maximum_mpps.sh: Add a menu to get user settings John Kacur
2020-12-16  9:39     ` Ahmed S. Darwish

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201214093049.pl2guoij4kjw2ifc@beryllium.lan \
    --to=dwagner@suse.de \
    --cc=jkacur@redhat.com \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=williams@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.