From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B34BC4361B for ; Mon, 14 Dec 2020 09:46:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F0FA20882 for ; Mon, 14 Dec 2020 09:46:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726921AbgLNJpt (ORCPT ); Mon, 14 Dec 2020 04:45:49 -0500 Received: from new2-smtp.messagingengine.com ([66.111.4.224]:57843 "EHLO new2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725915AbgLNJpt (ORCPT ); Mon, 14 Dec 2020 04:45:49 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 23F5A5804ED; Mon, 14 Dec 2020 04:44:43 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 14 Dec 2020 04:44:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=XKcGwNFJ8S2jYlC9CVP6MD9GTEJ SheLjaMSdlnbXVRw=; b=kdr/nac+m4TY+HliojMi6gdQuCKSvWCeDrCHLDMbpgg EV5DwbUuYWYNeKZM3kKOvcFOEeNuQGRpl1qA5O2H6qHIekW7nh5Oxal1W8sdAQA7 2TVFgRK2WluLWnT6mhcCWYp+sX57UaQJcl5f24205OY1SY4Vp64eNonNAmkvgj8E dufOaefCHVFKkFNp/tTYmcZ/SasTtxYiuDmT2rIsff7Hqmr43qgbmx+pGWprx1s/ TccCtl3Lzcun7g3JMnQT9eQxOebC4ugchSyepcozK9i8e6bnhQXb7GRe9qmMPlEO tR9l5baEviT66O9DTasffm0pZ1v1bZkkjiZqPaNE+gg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=XKcGwN FJ8S2jYlC9CVP6MD9GTEJSheLjaMSdlnbXVRw=; b=AXr9SdKAyy8ApuBvKMC7xH gqT/ZNkwPY1fZJCJFF5qGLZb5pWZikbN4wpiFu6f4un3dPMH55s4bnbdd3ULduQn xPDCetDXkHpLLS+RgCWx5ohNgXaPve4Guq/UgHWopX+5YJwVy55j0ObmFsKWuQSi dZuNsJN9WSDRTRCBAq93gQRlVKR/Lv5N2KN4820UDHS8wlQGULqaN/+HpzwJlMDP J4KW3IsblO6cvq1nUl32LmxjovbTOLaEke40zjWQDv/OUlDsl0scLHBqW11PFqIP ZNtVh0JmXzdRaoqJ+ZQBgY9DlFEWdR4pOAs0Y4nFDL1x8e8hB+cGSBE2O+TgQm6Q == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudekkedgtdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id D39F0108006F; Mon, 14 Dec 2020 04:44:41 -0500 (EST) Date: Mon, 14 Dec 2020 10:44:30 +0100 From: Maxime Ripard To: Andre Przywara Cc: Chen-Yu Tsai , Jernej Skrabec , Icenowy Zheng , Linus Walleij , Rob Herring , =?utf-8?B?Q2zDqW1lbnQgUMOpcm9u?= , Shuosheng Huang , Yangtao Li , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, linux-gpio@vger.kernel.org Subject: Re: [PATCH v2 03/21] pinctrl: sunxi: Add support for the Allwinner H616 pin controller Message-ID: <20201214094430.m6h3pzhkm3kjl2cl@gilmour> References: <20201211011934.6171-1-andre.przywara@arm.com> <20201211011934.6171-4-andre.przywara@arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ddy7lofybnowtr2q" Content-Disposition: inline In-Reply-To: <20201211011934.6171-4-andre.przywara@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org --ddy7lofybnowtr2q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Dec 11, 2020 at 01:19:16AM +0000, Andre Przywara wrote: > + SUNXI_PIN(SUNXI_PINCTRL_PIN(G, 10), > + SUNXI_FUNCTION(0x0, "gpio_in"), > + SUNXI_FUNCTION(0x1, "gpio_out"), > + SUNXI_FUNCTION(0x2, "h_i2s2"), /* MCLK */ > + SUNXI_FUNCTION(0x3, "clock"), /* X32KFOUT */ > + SUNXI_FUNCTION_IRQ_BANK(0x6, 5, 10)), /* PG_EINT10 */ It looks like there's no i2s vs h_i2s issue anymore? Maybe we can just do s/h_i2s/i2s > + SUNXI_PIN(SUNXI_PINCTRL_PIN(I, 3), > + SUNXI_FUNCTION(0x0, "gpio_in"), > + SUNXI_FUNCTION(0x1, "gpio_out"), > + SUNXI_FUNCTION(0x2, "emac0"), /* ERXD0 */ > + SUNXI_FUNCTION(0x3, "dmic"), /* DATA2 */ > + SUNXI_FUNCTION(0x4, "h_i2s0"), /* DO0 */ > + SUNXI_FUNCTION(0x5, "h_i2s0_a"), /* DI1 */ > + SUNXI_FUNCTION_IRQ_BANK(0x6, 7, 3)), /* PI_EINT3 */ The way we dealt with this for the A100 is that we put the function as a suffix which is more natural, so h_i2s0_dout0 and h_i2s0_din1 Maxime --ddy7lofybnowtr2q Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX9cz/gAKCRDj7w1vZxhR xZ4mAP0aOwSdv1t8DpTbKvaJdsEXW593SqrJq++ZdvC87hlg9AD/T8ZGrdPoyIW/ FKHiOaYy/KAy7FaHa2u4GVKqxJRKowQ= =wnrZ -----END PGP SIGNATURE----- --ddy7lofybnowtr2q-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4578AC4361B for ; Mon, 14 Dec 2020 09:46:16 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EEE8B20882 for ; Mon, 14 Dec 2020 09:46:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EEE8B20882 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JJSueiRq/wCgrKQAMxu7IS1vkvcd9/YmwLG90CF0r18=; b=fIK7Z8ZmM3BBg+bDYMXHmGeAz g5EOH6i0OWnS2gieUxXRT6ak7kJkCjRdCe1XW3psXcCxZP/t+QvONirXB0YqMc2DeCvll7G/DkHvW AW0CH7OUiu46YfdiWyK68Bz4LCDFmcW7a3edAJOgEXIy6gGJvi0o4uXBui7ETQ9iGYp6xznMehwwy NrSH9v3ObeOF2aqGCDfEcVGHxdH8MHkEavAVe9ypwHXAyYIDpsiJTcun/EoZUBxrhOq1un/LS3At2 0JdNXSjDwWSHUAu8tuJQSyWilhmDQmNJN3fH39VS38qjQ9SHUsVGSd6AKx01HN6BGvv/X2N50pyHC NQtpz3kMQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kokPO-00012X-R8; Mon, 14 Dec 2020 09:44:46 +0000 Received: from new2-smtp.messagingengine.com ([66.111.4.224]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kokPM-00011w-DZ for linux-arm-kernel@lists.infradead.org; Mon, 14 Dec 2020 09:44:45 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 23F5A5804ED; Mon, 14 Dec 2020 04:44:43 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 14 Dec 2020 04:44:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=XKcGwNFJ8S2jYlC9CVP6MD9GTEJ SheLjaMSdlnbXVRw=; b=kdr/nac+m4TY+HliojMi6gdQuCKSvWCeDrCHLDMbpgg EV5DwbUuYWYNeKZM3kKOvcFOEeNuQGRpl1qA5O2H6qHIekW7nh5Oxal1W8sdAQA7 2TVFgRK2WluLWnT6mhcCWYp+sX57UaQJcl5f24205OY1SY4Vp64eNonNAmkvgj8E dufOaefCHVFKkFNp/tTYmcZ/SasTtxYiuDmT2rIsff7Hqmr43qgbmx+pGWprx1s/ TccCtl3Lzcun7g3JMnQT9eQxOebC4ugchSyepcozK9i8e6bnhQXb7GRe9qmMPlEO tR9l5baEviT66O9DTasffm0pZ1v1bZkkjiZqPaNE+gg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=XKcGwN FJ8S2jYlC9CVP6MD9GTEJSheLjaMSdlnbXVRw=; b=AXr9SdKAyy8ApuBvKMC7xH gqT/ZNkwPY1fZJCJFF5qGLZb5pWZikbN4wpiFu6f4un3dPMH55s4bnbdd3ULduQn xPDCetDXkHpLLS+RgCWx5ohNgXaPve4Guq/UgHWopX+5YJwVy55j0ObmFsKWuQSi dZuNsJN9WSDRTRCBAq93gQRlVKR/Lv5N2KN4820UDHS8wlQGULqaN/+HpzwJlMDP J4KW3IsblO6cvq1nUl32LmxjovbTOLaEke40zjWQDv/OUlDsl0scLHBqW11PFqIP ZNtVh0JmXzdRaoqJ+ZQBgY9DlFEWdR4pOAs0Y4nFDL1x8e8hB+cGSBE2O+TgQm6Q == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudekkedgtdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id D39F0108006F; Mon, 14 Dec 2020 04:44:41 -0500 (EST) Date: Mon, 14 Dec 2020 10:44:30 +0100 From: Maxime Ripard To: Andre Przywara Subject: Re: [PATCH v2 03/21] pinctrl: sunxi: Add support for the Allwinner H616 pin controller Message-ID: <20201214094430.m6h3pzhkm3kjl2cl@gilmour> References: <20201211011934.6171-1-andre.przywara@arm.com> <20201211011934.6171-4-andre.przywara@arm.com> MIME-Version: 1.0 In-Reply-To: <20201211011934.6171-4-andre.przywara@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201214_044444_512562_D7D60F05 X-CRM114-Status: GOOD ( 10.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Jernej Skrabec , Yangtao Li , Linus Walleij , linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Chen-Yu Tsai , =?utf-8?B?Q2zDqW1lbnQgUMOpcm9u?= , Icenowy Zheng , Shuosheng Huang , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============1295786892154068756==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1295786892154068756== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ddy7lofybnowtr2q" Content-Disposition: inline --ddy7lofybnowtr2q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Dec 11, 2020 at 01:19:16AM +0000, Andre Przywara wrote: > + SUNXI_PIN(SUNXI_PINCTRL_PIN(G, 10), > + SUNXI_FUNCTION(0x0, "gpio_in"), > + SUNXI_FUNCTION(0x1, "gpio_out"), > + SUNXI_FUNCTION(0x2, "h_i2s2"), /* MCLK */ > + SUNXI_FUNCTION(0x3, "clock"), /* X32KFOUT */ > + SUNXI_FUNCTION_IRQ_BANK(0x6, 5, 10)), /* PG_EINT10 */ It looks like there's no i2s vs h_i2s issue anymore? Maybe we can just do s/h_i2s/i2s > + SUNXI_PIN(SUNXI_PINCTRL_PIN(I, 3), > + SUNXI_FUNCTION(0x0, "gpio_in"), > + SUNXI_FUNCTION(0x1, "gpio_out"), > + SUNXI_FUNCTION(0x2, "emac0"), /* ERXD0 */ > + SUNXI_FUNCTION(0x3, "dmic"), /* DATA2 */ > + SUNXI_FUNCTION(0x4, "h_i2s0"), /* DO0 */ > + SUNXI_FUNCTION(0x5, "h_i2s0_a"), /* DI1 */ > + SUNXI_FUNCTION_IRQ_BANK(0x6, 7, 3)), /* PI_EINT3 */ The way we dealt with this for the A100 is that we put the function as a suffix which is more natural, so h_i2s0_dout0 and h_i2s0_din1 Maxime --ddy7lofybnowtr2q Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX9cz/gAKCRDj7w1vZxhR xZ4mAP0aOwSdv1t8DpTbKvaJdsEXW593SqrJq++ZdvC87hlg9AD/T8ZGrdPoyIW/ FKHiOaYy/KAy7FaHa2u4GVKqxJRKowQ= =wnrZ -----END PGP SIGNATURE----- --ddy7lofybnowtr2q-- --===============1295786892154068756== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1295786892154068756==--