From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A53CC4361B for ; Mon, 14 Dec 2020 10:59:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CEFC122BEF for ; Mon, 14 Dec 2020 10:59:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407508AbgLNK6t (ORCPT ); Mon, 14 Dec 2020 05:58:49 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:60631 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2407504AbgLNK6m (ORCPT ); Mon, 14 Dec 2020 05:58:42 -0500 X-Originating-IP: 95.245.192.76 Received: from uno.localdomain (host-95-245-192-76.retail.telecomitalia.it [95.245.192.76]) (Authenticated sender: jacopo@jmondi.org) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 65E1AE000D; Mon, 14 Dec 2020 10:57:58 +0000 (UTC) Date: Mon, 14 Dec 2020 11:58:08 +0100 From: Jacopo Mondi To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Kieran Bingham , Kuninori Morimoto Subject: Re: [PATCH 7/9] drm: rcar-du: Replace dev_private with container_of Message-ID: <20201214105808.xrjyul6hrjsremli@uno.localdomain> References: <20201204220139.15272-1-laurent.pinchart+renesas@ideasonboard.com> <20201204220139.15272-8-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201204220139.15272-8-laurent.pinchart+renesas@ideasonboard.com> Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Laurent, On Sat, Dec 05, 2020 at 12:01:37AM +0200, Laurent Pinchart wrote: > Now that drm_device is embedded in rcar_du_device, we can use > container_of to get the rcar_du_device pointer from the drm_device, > instead of using the drm_device.dev_private field. > > Signed-off-by: Laurent Pinchart De gustibus non est disputandum Reviewed-by: Jacopo Mondi Thanks j > --- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 -- > drivers/gpu/drm/rcar-du/rcar_du_drv.h | 5 +++++ > drivers/gpu/drm/rcar-du/rcar_du_kms.c | 8 ++++---- > drivers/gpu/drm/rcar-du/rcar_du_plane.c | 2 +- > 4 files changed, 10 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > index 4ab99ac49891..d6a8b7899952 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > @@ -587,8 +587,6 @@ static int rcar_du_probe(struct platform_device *pdev) > return PTR_ERR(rcdu->mmio); > > /* DRM/KMS objects */ > - rcdu->ddev.dev_private = rcdu; > - > ret = rcar_du_modeset_init(rcdu); > if (ret < 0) { > if (ret != -EPROBE_DEFER) > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.h b/drivers/gpu/drm/rcar-du/rcar_du_drv.h > index e5b6f456357e..98d6bac3f2fa 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.h > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.h > @@ -102,6 +102,11 @@ struct rcar_du_device { > unsigned int vspd1_sink; > }; > > +static inline struct rcar_du_device *to_rcar_du_device(struct drm_device *dev) > +{ > + return container_of(dev, struct rcar_du_device, ddev); > +} > + > static inline bool rcar_du_has(struct rcar_du_device *rcdu, > unsigned int feature) > { > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c > index 57bb0dc22807..d6b71a9361ca 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c > @@ -327,7 +327,7 @@ const struct rcar_du_format_info *rcar_du_format_info(u32 fourcc) > int rcar_du_dumb_create(struct drm_file *file, struct drm_device *dev, > struct drm_mode_create_dumb *args) > { > - struct rcar_du_device *rcdu = dev->dev_private; > + struct rcar_du_device *rcdu = to_rcar_du_device(dev); > unsigned int min_pitch = DIV_ROUND_UP(args->width * args->bpp, 8); > unsigned int align; > > @@ -349,7 +349,7 @@ static struct drm_framebuffer * > rcar_du_fb_create(struct drm_device *dev, struct drm_file *file_priv, > const struct drm_mode_fb_cmd2 *mode_cmd) > { > - struct rcar_du_device *rcdu = dev->dev_private; > + struct rcar_du_device *rcdu = to_rcar_du_device(dev); > const struct rcar_du_format_info *format; > unsigned int chroma_pitch; > unsigned int max_pitch; > @@ -421,7 +421,7 @@ rcar_du_fb_create(struct drm_device *dev, struct drm_file *file_priv, > static int rcar_du_atomic_check(struct drm_device *dev, > struct drm_atomic_state *state) > { > - struct rcar_du_device *rcdu = dev->dev_private; > + struct rcar_du_device *rcdu = to_rcar_du_device(dev); > int ret; > > ret = drm_atomic_helper_check(dev, state); > @@ -437,7 +437,7 @@ static int rcar_du_atomic_check(struct drm_device *dev, > static void rcar_du_atomic_commit_tail(struct drm_atomic_state *old_state) > { > struct drm_device *dev = old_state->dev; > - struct rcar_du_device *rcdu = dev->dev_private; > + struct rcar_du_device *rcdu = to_rcar_du_device(dev); > struct drm_crtc_state *crtc_state; > struct drm_crtc *crtc; > unsigned int i; > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_plane.c b/drivers/gpu/drm/rcar-du/rcar_du_plane.c > index 5f69ff4502c1..02e5f11f38eb 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_plane.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_plane.c > @@ -128,7 +128,7 @@ static int rcar_du_plane_hwalloc(struct rcar_du_plane *plane, > int rcar_du_atomic_check_planes(struct drm_device *dev, > struct drm_atomic_state *state) > { > - struct rcar_du_device *rcdu = dev->dev_private; > + struct rcar_du_device *rcdu = to_rcar_du_device(dev); > unsigned int group_freed_planes[RCAR_DU_MAX_GROUPS] = { 0, }; > unsigned int group_free_planes[RCAR_DU_MAX_GROUPS] = { 0, }; > bool needs_realloc = false; > -- > Regards, > > Laurent Pinchart > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD498C4361B for ; Mon, 14 Dec 2020 10:58:04 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C3E422CB2 for ; Mon, 14 Dec 2020 10:58:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C3E422CB2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jmondi.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 502126E13C; Mon, 14 Dec 2020 10:58:03 +0000 (UTC) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by gabe.freedesktop.org (Postfix) with ESMTPS id 758756E13C for ; Mon, 14 Dec 2020 10:58:01 +0000 (UTC) X-Originating-IP: 95.245.192.76 Received: from uno.localdomain (host-95-245-192-76.retail.telecomitalia.it [95.245.192.76]) (Authenticated sender: jacopo@jmondi.org) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 65E1AE000D; Mon, 14 Dec 2020 10:57:58 +0000 (UTC) Date: Mon, 14 Dec 2020 11:58:08 +0100 From: Jacopo Mondi To: Laurent Pinchart Subject: Re: [PATCH 7/9] drm: rcar-du: Replace dev_private with container_of Message-ID: <20201214105808.xrjyul6hrjsremli@uno.localdomain> References: <20201204220139.15272-1-laurent.pinchart+renesas@ideasonboard.com> <20201204220139.15272-8-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201204220139.15272-8-laurent.pinchart+renesas@ideasonboard.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-renesas-soc@vger.kernel.org, Kuninori Morimoto , Kieran Bingham , dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Laurent, On Sat, Dec 05, 2020 at 12:01:37AM +0200, Laurent Pinchart wrote: > Now that drm_device is embedded in rcar_du_device, we can use > container_of to get the rcar_du_device pointer from the drm_device, > instead of using the drm_device.dev_private field. > > Signed-off-by: Laurent Pinchart De gustibus non est disputandum Reviewed-by: Jacopo Mondi Thanks j > --- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 -- > drivers/gpu/drm/rcar-du/rcar_du_drv.h | 5 +++++ > drivers/gpu/drm/rcar-du/rcar_du_kms.c | 8 ++++---- > drivers/gpu/drm/rcar-du/rcar_du_plane.c | 2 +- > 4 files changed, 10 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > index 4ab99ac49891..d6a8b7899952 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > @@ -587,8 +587,6 @@ static int rcar_du_probe(struct platform_device *pdev) > return PTR_ERR(rcdu->mmio); > > /* DRM/KMS objects */ > - rcdu->ddev.dev_private = rcdu; > - > ret = rcar_du_modeset_init(rcdu); > if (ret < 0) { > if (ret != -EPROBE_DEFER) > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.h b/drivers/gpu/drm/rcar-du/rcar_du_drv.h > index e5b6f456357e..98d6bac3f2fa 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.h > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.h > @@ -102,6 +102,11 @@ struct rcar_du_device { > unsigned int vspd1_sink; > }; > > +static inline struct rcar_du_device *to_rcar_du_device(struct drm_device *dev) > +{ > + return container_of(dev, struct rcar_du_device, ddev); > +} > + > static inline bool rcar_du_has(struct rcar_du_device *rcdu, > unsigned int feature) > { > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c > index 57bb0dc22807..d6b71a9361ca 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c > @@ -327,7 +327,7 @@ const struct rcar_du_format_info *rcar_du_format_info(u32 fourcc) > int rcar_du_dumb_create(struct drm_file *file, struct drm_device *dev, > struct drm_mode_create_dumb *args) > { > - struct rcar_du_device *rcdu = dev->dev_private; > + struct rcar_du_device *rcdu = to_rcar_du_device(dev); > unsigned int min_pitch = DIV_ROUND_UP(args->width * args->bpp, 8); > unsigned int align; > > @@ -349,7 +349,7 @@ static struct drm_framebuffer * > rcar_du_fb_create(struct drm_device *dev, struct drm_file *file_priv, > const struct drm_mode_fb_cmd2 *mode_cmd) > { > - struct rcar_du_device *rcdu = dev->dev_private; > + struct rcar_du_device *rcdu = to_rcar_du_device(dev); > const struct rcar_du_format_info *format; > unsigned int chroma_pitch; > unsigned int max_pitch; > @@ -421,7 +421,7 @@ rcar_du_fb_create(struct drm_device *dev, struct drm_file *file_priv, > static int rcar_du_atomic_check(struct drm_device *dev, > struct drm_atomic_state *state) > { > - struct rcar_du_device *rcdu = dev->dev_private; > + struct rcar_du_device *rcdu = to_rcar_du_device(dev); > int ret; > > ret = drm_atomic_helper_check(dev, state); > @@ -437,7 +437,7 @@ static int rcar_du_atomic_check(struct drm_device *dev, > static void rcar_du_atomic_commit_tail(struct drm_atomic_state *old_state) > { > struct drm_device *dev = old_state->dev; > - struct rcar_du_device *rcdu = dev->dev_private; > + struct rcar_du_device *rcdu = to_rcar_du_device(dev); > struct drm_crtc_state *crtc_state; > struct drm_crtc *crtc; > unsigned int i; > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_plane.c b/drivers/gpu/drm/rcar-du/rcar_du_plane.c > index 5f69ff4502c1..02e5f11f38eb 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_plane.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_plane.c > @@ -128,7 +128,7 @@ static int rcar_du_plane_hwalloc(struct rcar_du_plane *plane, > int rcar_du_atomic_check_planes(struct drm_device *dev, > struct drm_atomic_state *state) > { > - struct rcar_du_device *rcdu = dev->dev_private; > + struct rcar_du_device *rcdu = to_rcar_du_device(dev); > unsigned int group_freed_planes[RCAR_DU_MAX_GROUPS] = { 0, }; > unsigned int group_free_planes[RCAR_DU_MAX_GROUPS] = { 0, }; > bool needs_realloc = false; > -- > Regards, > > Laurent Pinchart > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel