All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>
Subject: [PATCH  v1 2/6] configure: gate our use of GDB to 8.3.1 or above
Date: Mon, 14 Dec 2020 15:30:08 +0000	[thread overview]
Message-ID: <20201214153012.12723-3-alex.bennee@linaro.org> (raw)
In-Reply-To: <20201214153012.12723-1-alex.bennee@linaro.org>

Certain earlier versions of GDB have (possibly distro) derived issues
when running against multiarch guests. Also given the problem of
clashing ports it is preferable to use socket comms rather than TCP
ports for testing.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 configure | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/configure b/configure
index 11f5878a59..f6347382e9 100755
--- a/configure
+++ b/configure
@@ -6721,8 +6721,11 @@ if test "$plugins" = "yes" ; then
     fi
 fi
 
-if test -n "$gdb_bin" ; then
-    echo "HAVE_GDB_BIN=$gdb_bin" >> $config_host_mak
+if test -n "$gdb_bin"; then
+    gdb_version=$($gdb_bin --version | head -n 1)
+    if version_ge ${gdb_version##* } 8.3.1; then
+        echo "HAVE_GDB_BIN=$gdb_bin" >> $config_host_mak
+    fi
 fi
 
 if test "$secret_keyring" = "yes" ; then
-- 
2.20.1



  parent reply	other threads:[~2020-12-14 15:35 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-14 15:30 [PATCH v1 0/6] gdbstub (auxv, tests, cleanup) Alex Bennée
2020-12-14 15:30 ` [PATCH v1 1/6] test/guest-debug: echo QEMU command as well Alex Bennée
2020-12-14 15:30 ` Alex Bennée [this message]
2020-12-14 15:47   ` [PATCH v1 2/6] configure: gate our use of GDB to 8.3.1 or above Peter Maydell
2020-12-14 17:05     ` Alex Bennée
2020-12-14 17:14       ` Peter Maydell
2020-12-14 15:30 ` [PATCH v1 3/6] gdbstub: add support to Xfer:auxv:read: packet Alex Bennée
2020-12-16 19:54   ` Richard Henderson
2020-12-14 15:30 ` [PATCH v1 4/6] gdbstub: drop CPUEnv from gdb_exit() Alex Bennée
2020-12-16 19:55   ` Richard Henderson
2020-12-14 15:30 ` [PATCH v1 5/6] gdbstub: drop gdbserver_cleanup in favour of gdb_exit Alex Bennée
2020-12-16 19:56   ` Richard Henderson
2020-12-14 15:30 ` [PATCH v1 6/6] gdbstub: ensure we clean-up when terminated Alex Bennée
2020-12-16 19:56   ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201214153012.12723-3-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.