From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 723F7C4361B for ; Mon, 14 Dec 2020 14:45:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB42A22D05 for ; Mon, 14 Dec 2020 14:45:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB42A22D05 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43740 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kop5v-0007Dn-Mf for qemu-devel@archiver.kernel.org; Mon, 14 Dec 2020 09:44:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44972) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kop46-0005Pu-Mu for qemu-devel@nongnu.org; Mon, 14 Dec 2020 09:43:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:29875) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kop41-0008Px-U1 for qemu-devel@nongnu.org; Mon, 14 Dec 2020 09:43:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607956980; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UYbiSFexLBCJY4eRqVZo8fd3axf7bRj1lF7xJRbj9TU=; b=DyDtb8HTKM8Vm2VHXCeG1YgbtMc960WjnhdTKzDq7T9NS0ek6cF+AdUFGp7zLZ/Q7KQKIA UTw+AEVm9oQcvv4cyRUvqyBPW/AExhTRIU5tKrDslwyx9O9whx1TFaGZw7cQs4ls8mB0IF m3NotJkSHlKw40QBpTB7lRbjntRoxbw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-424-f1Cd4KpTODS2WhrkVLU80Q-1; Mon, 14 Dec 2020 09:42:59 -0500 X-MC-Unique: f1Cd4KpTODS2WhrkVLU80Q-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9E5F5107ACE6; Mon, 14 Dec 2020 14:42:57 +0000 (UTC) Received: from localhost (unknown [10.40.208.9]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4EAB75D9DC; Mon, 14 Dec 2020 14:42:51 +0000 (UTC) Date: Mon, 14 Dec 2020 15:42:48 +0100 From: Igor Mammedov To: Eduardo Habkost Subject: Re: [PATCH v4 17/32] sparc: Use DEFINE_PROP for nwindows property Message-ID: <20201214154248.33e191e4@redhat.com> In-Reply-To: <20201211220529.2290218-18-ehabkost@redhat.com> References: <20201211220529.2290218-1-ehabkost@redhat.com> <20201211220529.2290218-18-ehabkost@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , "Daniel P. Berrange" , Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= , Mark Cave-Ayland , qemu-devel@nongnu.org, Markus Armbruster , =?UTF-8?B?TWFy?= =?UTF-8?B?Yy1BbmRyw6k=?= Lureau , Paolo Bonzini , John Snow , Artyom Tarasenko , Stefan Berger Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 11 Dec 2020 17:05:14 -0500 Eduardo Habkost wrote: > Use the DEFINE_PROP macro (which will set extra fields in the > struct) instead of initializing a Property struct manually. > > Signed-off-by: Eduardo Habkost > --- > This is a new patch added in v2 of the series > --- > Cc: Mark Cave-Ayland > Cc: Artyom Tarasenko > Cc: qemu-devel@nongnu.org > --- > target/sparc/cpu.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/target/sparc/cpu.c b/target/sparc/cpu.c > index 6a3299041f..92534bcd18 100644 > --- a/target/sparc/cpu.c > +++ b/target/sparc/cpu.c > @@ -848,7 +848,8 @@ static Property sparc_cpu_properties[] = { > qdev_prop_uint64, target_ulong), > DEFINE_PROP_UINT32("fpu-version", SPARCCPU, env.def.fpu_version, 0), > DEFINE_PROP_UINT32("mmu-version", SPARCCPU, env.def.mmu_version, 0), > - { .name = "nwindows", .info = &qdev_prop_nwindows }, > + DEFINE_PROP("nwindows", SPARCCPU, env.def.nwindows, ^^^^ stray whitespace > + qdev_prop_nwindows, uint32_t), > DEFINE_PROP_END_OF_LIST() > }; >