From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26836C2BB40 for ; Mon, 14 Dec 2020 15:52:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D9C892251D for ; Mon, 14 Dec 2020 15:52:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439175AbgLNPva (ORCPT ); Mon, 14 Dec 2020 10:51:30 -0500 Received: from mail.kernel.org ([198.145.29.99]:35338 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2439302AbgLNPut (ORCPT ); Mon, 14 Dec 2020 10:50:49 -0500 Date: Mon, 14 Dec 2020 16:50:06 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607961009; bh=Qq101I6HQFjSJ0f8meR5JgRX4pD1pU+G5hTz2A6kqNI=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=n/j4Q+hSaE9EBpsxq2b9yO63g/xJoXi3YUA7rB49Q5bgklSIyH5nPOxpNp0W8yFwE X9cjEpsWxB8riQ1lEhgdq4Lo6CgSB1xYXQAg6gOHMbUkhrZsPPn+HKHBPUVeVgZVPw 75jPz/I5/iE+rLSuOGVZ56RnsWh//uoFDy1Fm3587/DNs1lONaX+u2xaecprpezMfY oTdUPVoaPJ5ScZR6kWRpx5PM0GgrwJDmQwwdJvxYmNr/QKNuMds1J96EOpiND76NiT Km0ZM4xLbztXPSKdj7ELgU7GHmU86qCopuQjGS7g4VDOYV0to+4TIj8vIPrmhWllEB DRP53Nrk0BfIw== From: Sebastian Reichel To: Tomi Valkeinen Cc: Laurent Pinchart , Nikhil Devshatwar , dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org, Sekhar Nori , Tony Lindgren , hns@goldelico.com, Sam Ravnborg Subject: Re: [PATCH v5 13/29] drm/omap: dsi: skip dsi_vc_enable_hs when already in correct mode Message-ID: <20201214155006.7euc4ptnk66erzjz@earth.universe> References: <20201208122855.254819-1-tomi.valkeinen@ti.com> <20201208122855.254819-14-tomi.valkeinen@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vjsk4eal7k7jmjw2" Content-Disposition: inline In-Reply-To: <20201208122855.254819-14-tomi.valkeinen@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org --vjsk4eal7k7jmjw2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, Dec 08, 2020 at 02:28:39PM +0200, Tomi Valkeinen wrote: > Simplify and optimize dsi_vc_enable_hs() so that it can be called > without checking the current HS/LP mode. Make dsi_vc_enable_hs() return > if the VC is already in the correct mode. >=20 > Signed-off-by: Tomi Valkeinen > Reviewed-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/dss/dsi.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/= dss/dsi.c > index a1f3623f45b1..544f5f1eed91 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dsi.c > +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c > @@ -341,7 +341,6 @@ struct dsi_data { > int irq; > =20 > bool is_enabled; > - bool in_lp_mode; > =20 > struct clk *dss_clk; > struct regmap *syscon; > @@ -2441,6 +2440,9 @@ static void dsi_vc_enable_hs(struct omap_dss_device= *dssdev, int vc, > =20 > DSSDBG("dsi_vc_enable_hs(%d, %d)\n", vc, enable); > =20 > + if (REG_GET(dsi, DSI_VC_CTRL(vc), 9, 9) =3D=3D enable) > + return; > + > WARN_ON(!dsi_bus_is_locked(dsi)); > =20 > dsi_vc_enable(dsi, vc, 0); > @@ -2456,8 +2458,6 @@ static void dsi_vc_enable_hs(struct omap_dss_device= *dssdev, int vc, > /* start the DDR clock by sending a NULL packet */ > if (dsi->vm_timings.ddr_clk_always_on && enable) > dsi_vc_send_null(dsi, vc, dsi->dsidev->channel); > - > - dsi->in_lp_mode =3D !enable; > } > =20 > static void dsi_vc_flush_long_data(struct dsi_data *dsi, int vc) > @@ -4891,9 +4891,7 @@ static ssize_t _omap_dsi_host_transfer(struct dsi_d= ata *dsi, int vc, > struct omap_dss_device *dssdev =3D &dsi->output; > int r; > =20 > - if (!!(msg->flags & MIPI_DSI_MSG_USE_LPM) !=3D dsi->in_lp_mode) > - dsi_vc_enable_hs(dssdev, vc, > - !(msg->flags & MIPI_DSI_MSG_USE_LPM)); > + dsi_vc_enable_hs(dssdev, vc, !(msg->flags & MIPI_DSI_MSG_USE_LPM)); > =20 > switch (msg->type) { > case MIPI_DSI_GENERIC_SHORT_WRITE_0_PARAM: > --=20 > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki >=20 --vjsk4eal7k7jmjw2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAl/Xia4ACgkQ2O7X88g7 +poNbA/8DSW6zBL8AM3rWF+1KZKvVAJ14T0P+M7ll+A2ZATuyeWozsiKWqIUnVNq WhHbrewK04ZNna6nwBmq/H2DZeWV6ZFA6aDVT1df0nAaDR0veG1yrj7orftQ7r6b NVYGPgrd6+eCLUzE2SojmiThubbbj7PWblBwB+VA2bZVZF9Nk9kpo7PrL15FuKQR G8VqEF/y4ffyZf8d8ulNEbflZp00azexLX6wrlp4FdHR1iYCkrpf2NVC4te8XflS ugA9G4vYwL9V+RZTqgHHDCsqadrCjimcjp0oRfABOJy0TLHLnWer8+7Nh9wj+l/z kdBSgNHjdCs/8vSWxzYGInN5+S47p5WVGRu8w2EH9AZBfEduNGncjFoL+kaN9eJF pmjP+PNOy8Plb4RabwLY6IUTJYQDQlJRhEnz25Y26MD3mHEY3yLwACyWG0Y2RReB AuDXkboK2RhUl6Rfc34nTogl4dyWtJFJBxdZ9Nik05IaslzghlLZzZmnJN6Cub7S 1rq96acw4tCt4sj2/sRMUe41S9h/oEYzkFsqVapQLhzMfY76l4TneVe2Ik0aGHzM r0rLkuNFFH6/pffQ+ppzWXFbi1rxduPCTSOeZkeE5IruyMcXVsmsZZQ16Nk+sHJf wYDVWDpzquH3eSab3aHT5tmheFWJLq3u6ZaRT1KHau0BBv1bZYM= =YVNv -----END PGP SIGNATURE----- --vjsk4eal7k7jmjw2-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3A67C4361B for ; Mon, 14 Dec 2020 15:50:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7685122518 for ; Mon, 14 Dec 2020 15:50:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7685122518 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0A33B6E213; Mon, 14 Dec 2020 15:50:17 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 425CE6E213 for ; Mon, 14 Dec 2020 15:50:09 +0000 (UTC) Date: Mon, 14 Dec 2020 16:50:06 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607961009; bh=Qq101I6HQFjSJ0f8meR5JgRX4pD1pU+G5hTz2A6kqNI=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=n/j4Q+hSaE9EBpsxq2b9yO63g/xJoXi3YUA7rB49Q5bgklSIyH5nPOxpNp0W8yFwE X9cjEpsWxB8riQ1lEhgdq4Lo6CgSB1xYXQAg6gOHMbUkhrZsPPn+HKHBPUVeVgZVPw 75jPz/I5/iE+rLSuOGVZ56RnsWh//uoFDy1Fm3587/DNs1lONaX+u2xaecprpezMfY oTdUPVoaPJ5ScZR6kWRpx5PM0GgrwJDmQwwdJvxYmNr/QKNuMds1J96EOpiND76NiT Km0ZM4xLbztXPSKdj7ELgU7GHmU86qCopuQjGS7g4VDOYV0to+4TIj8vIPrmhWllEB DRP53Nrk0BfIw== From: Sebastian Reichel To: Tomi Valkeinen Subject: Re: [PATCH v5 13/29] drm/omap: dsi: skip dsi_vc_enable_hs when already in correct mode Message-ID: <20201214155006.7euc4ptnk66erzjz@earth.universe> References: <20201208122855.254819-1-tomi.valkeinen@ti.com> <20201208122855.254819-14-tomi.valkeinen@ti.com> MIME-Version: 1.0 In-Reply-To: <20201208122855.254819-14-tomi.valkeinen@ti.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tony Lindgren , hns@goldelico.com, Sekhar Nori , dri-devel@lists.freedesktop.org, Laurent Pinchart , linux-omap@vger.kernel.org, Sam Ravnborg , Nikhil Devshatwar Content-Type: multipart/mixed; boundary="===============1386161528==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --===============1386161528== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vjsk4eal7k7jmjw2" Content-Disposition: inline --vjsk4eal7k7jmjw2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, Dec 08, 2020 at 02:28:39PM +0200, Tomi Valkeinen wrote: > Simplify and optimize dsi_vc_enable_hs() so that it can be called > without checking the current HS/LP mode. Make dsi_vc_enable_hs() return > if the VC is already in the correct mode. >=20 > Signed-off-by: Tomi Valkeinen > Reviewed-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/dss/dsi.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/= dss/dsi.c > index a1f3623f45b1..544f5f1eed91 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dsi.c > +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c > @@ -341,7 +341,6 @@ struct dsi_data { > int irq; > =20 > bool is_enabled; > - bool in_lp_mode; > =20 > struct clk *dss_clk; > struct regmap *syscon; > @@ -2441,6 +2440,9 @@ static void dsi_vc_enable_hs(struct omap_dss_device= *dssdev, int vc, > =20 > DSSDBG("dsi_vc_enable_hs(%d, %d)\n", vc, enable); > =20 > + if (REG_GET(dsi, DSI_VC_CTRL(vc), 9, 9) =3D=3D enable) > + return; > + > WARN_ON(!dsi_bus_is_locked(dsi)); > =20 > dsi_vc_enable(dsi, vc, 0); > @@ -2456,8 +2458,6 @@ static void dsi_vc_enable_hs(struct omap_dss_device= *dssdev, int vc, > /* start the DDR clock by sending a NULL packet */ > if (dsi->vm_timings.ddr_clk_always_on && enable) > dsi_vc_send_null(dsi, vc, dsi->dsidev->channel); > - > - dsi->in_lp_mode =3D !enable; > } > =20 > static void dsi_vc_flush_long_data(struct dsi_data *dsi, int vc) > @@ -4891,9 +4891,7 @@ static ssize_t _omap_dsi_host_transfer(struct dsi_d= ata *dsi, int vc, > struct omap_dss_device *dssdev =3D &dsi->output; > int r; > =20 > - if (!!(msg->flags & MIPI_DSI_MSG_USE_LPM) !=3D dsi->in_lp_mode) > - dsi_vc_enable_hs(dssdev, vc, > - !(msg->flags & MIPI_DSI_MSG_USE_LPM)); > + dsi_vc_enable_hs(dssdev, vc, !(msg->flags & MIPI_DSI_MSG_USE_LPM)); > =20 > switch (msg->type) { > case MIPI_DSI_GENERIC_SHORT_WRITE_0_PARAM: > --=20 > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki >=20 --vjsk4eal7k7jmjw2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAl/Xia4ACgkQ2O7X88g7 +poNbA/8DSW6zBL8AM3rWF+1KZKvVAJ14T0P+M7ll+A2ZATuyeWozsiKWqIUnVNq WhHbrewK04ZNna6nwBmq/H2DZeWV6ZFA6aDVT1df0nAaDR0veG1yrj7orftQ7r6b NVYGPgrd6+eCLUzE2SojmiThubbbj7PWblBwB+VA2bZVZF9Nk9kpo7PrL15FuKQR G8VqEF/y4ffyZf8d8ulNEbflZp00azexLX6wrlp4FdHR1iYCkrpf2NVC4te8XflS ugA9G4vYwL9V+RZTqgHHDCsqadrCjimcjp0oRfABOJy0TLHLnWer8+7Nh9wj+l/z kdBSgNHjdCs/8vSWxzYGInN5+S47p5WVGRu8w2EH9AZBfEduNGncjFoL+kaN9eJF pmjP+PNOy8Plb4RabwLY6IUTJYQDQlJRhEnz25Y26MD3mHEY3yLwACyWG0Y2RReB AuDXkboK2RhUl6Rfc34nTogl4dyWtJFJBxdZ9Nik05IaslzghlLZzZmnJN6Cub7S 1rq96acw4tCt4sj2/sRMUe41S9h/oEYzkFsqVapQLhzMfY76l4TneVe2Ik0aGHzM r0rLkuNFFH6/pffQ+ppzWXFbi1rxduPCTSOeZkeE5IruyMcXVsmsZZQ16Nk+sHJf wYDVWDpzquH3eSab3aHT5tmheFWJLq3u6ZaRT1KHau0BBv1bZYM= =YVNv -----END PGP SIGNATURE----- --vjsk4eal7k7jmjw2-- --===============1386161528== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1386161528==--