All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Allison <jra@samba.org>
To: Stefan Metzmacher <metze@samba.org>
Cc: Steve French <smfrench@gmail.com>,
	Namjae Jeon <namjae.jeon@samsung.com>,
	CIFS <linux-cifs@vger.kernel.org>,
	samba-technical <samba-technical@lists.samba.org>
Subject: Re: updated ksmbd (cifsd)
Date: Mon, 14 Dec 2020 10:48:20 -0800	[thread overview]
Message-ID: <20201214184820.GB56567@jeremy-acer> (raw)
In-Reply-To: <3bf45223-484a-e86a-279a-619a779ceabd@samba.org>

On Mon, Dec 14, 2020 at 06:45:51PM +0100, Stefan Metzmacher via samba-technical wrote:
>Am 14.12.20 um 02:20 schrieb Steve French via samba-technical:
>> I just rebased https://github.com/smfrench/smb3-kernel/tree/cifsd-for-next
>> ontop of 5.10 kernel. Let me know if you see any problems.   xfstest
>> results (and recent improvements) running Linux cifs.ko->ksmbd look
>> very promising.
>
>I just looked briefly, but I'm wondering about a few things:
>
>1. The xattr's to store additional meta data are not compatible with
>   Samba's way of storing things:
>   https://git.samba.org/?p=samba.git;a=blob;f=librpc/idl/xattr.idl
>
>   In order to make it possible to use the same filesystem with both servers
>   it would be great if the well established way used in Samba would be used
>   as well.

A thousand times this ! If cifs.ko->ksmbd adds a differnt way
of storing the extra meta-data that is incompatible with Samba
this would be a disaster for users.

Please fix this before proposing any merge.

  reply	other threads:[~2020-12-14 19:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-14  1:20 updated ksmbd (cifsd) Steve French
2020-12-14 12:46 ` Namjae Jeon
2020-12-15  2:28   ` Namjae Jeon
2020-12-14 17:45 ` Stefan Metzmacher
2020-12-14 18:48   ` Jeremy Allison [this message]
2020-12-15  2:29     ` Namjae Jeon
2020-12-15  4:13       ` Jeremy Allison
2020-12-15  2:28   ` Namjae Jeon
2020-12-15 14:29     ` Stefan Metzmacher
2020-12-16  3:24       ` Sergey Senozhatsky
2020-12-16  4:21         ` Sergey Senozhatsky
2020-12-17  3:29           ` Sergey Senozhatsky
2020-12-16  8:50       ` Namjae Jeon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201214184820.GB56567@jeremy-acer \
    --to=jra@samba.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=metze@samba.org \
    --cc=namjae.jeon@samsung.com \
    --cc=samba-technical@lists.samba.org \
    --cc=smfrench@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.