From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLACK, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D343AC2BB40 for ; Tue, 15 Dec 2020 03:10:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9A40B2255F for ; Tue, 15 Dec 2020 03:10:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727425AbgLODKT (ORCPT ); Mon, 14 Dec 2020 22:10:19 -0500 Received: from mail.kernel.org ([198.145.29.99]:36468 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727113AbgLODKM (ORCPT ); Mon, 14 Dec 2020 22:10:12 -0500 Date: Mon, 14 Dec 2020 19:08:38 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1608001720; bh=zDajIUIj0ZtUTI3DK8MkA0fs/Bb9OzsR9gkVjb6hKwE=; h=From:To:Subject:In-Reply-To:From; b=TpTWU8nGBzTu8QWKwirIFyCDaR/57Tqb7zSuanP0LpPONGU8hWEoaX8UG6d5E6vr9 IvG9zC/X0Fk5j+c7uKNW+qGMNJF6VcA501DlcuOUr6kudP6VPGVSAfMNaMXmVyinoR d6Jnm0Cv6aT0zdUaAfH0BZTnvVFuR99oMrJ5Fg8A= From: Andrew Morton To: akpm@linux-foundation.org, bigeasy@linutronix.de, cai@lca.pw, christian.koenig@amd.com, cl@linux.com, daniel.vetter@ffwll.ch, daniel.vetter@intel.com, david@fromorbit.com, iamjoonsoo.kim@lge.com, jgg@mellanox.com, jgg@nvidia.com, linux-mm@kvack.org, longman@redhat.com, maarten.lankhorst@linux.intel.com, mathieu.desnoyers@efficios.com, mingo@kernel.org, mingo@redhat.com, mm-commits@vger.kernel.org, paulmck@kernel.org, penberg@kernel.org, peterz@infradead.org, rdunlap@infradead.org, rientjes@google.com, tglx@linutronix.de, thomas_os@shipmail.org, torvalds@linux-foundation.org, vbabka@suse.cz, walken@google.com, will@kernel.org, willy@infradead.org Subject: [patch 092/200] locking/selftests: add testcases for fs_reclaim Message-ID: <20201215030838.ihuhrydKd%akpm@linux-foundation.org> In-Reply-To: <20201214190237.a17b70ae14f129e2dca3d204@linux-foundation.org> User-Agent: s-nail v14.8.16 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org =46rom: Daniel Vetter Subject: locking/selftests: add testcases for fs_reclaim Since I butchered this I figured better to make sure we have testcases for this now. Since we only have a locking context for __GFP_FS that's the only thing we're testing right now. Link: https://lkml.kernel.org/r/20201125162532.1299794-4-daniel.vetter@ffwl= l.ch Signed-off-by: Daniel Vetter Acked-by: Peter Zijlstra (Intel) Cc: Dave Chinner Cc: Qian Cai Cc: Thomas Hellstr=C3=B6m (Intel) Cc: Jason Gunthorpe Cc: Maarten Lankhorst Cc: Christian K=C3=B6nig Cc: "Matthew Wilcox (Oracle)" Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Will Deacon Cc: Christoph Lameter Cc: David Rientjes Cc: Ingo Molnar Cc: Jason Gunthorpe Cc: Joonsoo Kim Cc: Mathieu Desnoyers Cc: Michel Lespinasse Cc: Paul E. McKenney Cc: Pekka Enberg Cc: Randy Dunlap Cc: Sebastian Andrzej Siewior Cc: Thomas Gleixner Cc: Vlastimil Babka Cc: Waiman Long Signed-off-by: Andrew Morton --- lib/locking-selftest.c | 47 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+) --- a/lib/locking-selftest.c~locking-selftests-add-testcases-for-fs_reclaim +++ a/lib/locking-selftest.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include #include @@ -2357,6 +2358,50 @@ static void queued_read_lock_tests(void) pr_cont("\n"); } =20 +static void fs_reclaim_correct_nesting(void) +{ + fs_reclaim_acquire(GFP_KERNEL); + might_alloc(GFP_NOFS); + fs_reclaim_release(GFP_KERNEL); +} + +static void fs_reclaim_wrong_nesting(void) +{ + fs_reclaim_acquire(GFP_KERNEL); + might_alloc(GFP_KERNEL); + fs_reclaim_release(GFP_KERNEL); +} + +static void fs_reclaim_protected_nesting(void) +{ + unsigned int flags; + + fs_reclaim_acquire(GFP_KERNEL); + flags =3D memalloc_nofs_save(); + might_alloc(GFP_KERNEL); + memalloc_nofs_restore(flags); + fs_reclaim_release(GFP_KERNEL); +} + +static void fs_reclaim_tests(void) +{ + printk(" --------------------\n"); + printk(" | fs_reclaim tests |\n"); + printk(" --------------------\n"); + + print_testname("correct nesting"); + dotest(fs_reclaim_correct_nesting, SUCCESS, 0); + pr_cont("\n"); + + print_testname("wrong nesting"); + dotest(fs_reclaim_wrong_nesting, FAILURE, 0); + pr_cont("\n"); + + print_testname("protected nesting"); + dotest(fs_reclaim_protected_nesting, SUCCESS, 0); + pr_cont("\n"); +} + void locking_selftest(void) { /* @@ -2478,6 +2523,8 @@ void locking_selftest(void) if (IS_ENABLED(CONFIG_QUEUED_RWLOCKS)) queued_read_lock_tests(); =20 + fs_reclaim_tests(); + if (unexpected_testcase_failures) { printk("----------------------------------------------------------------= -\n"); debug_locks =3D 0; _