All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Bhaskara Budiredla <bbudiredla@marvell.com>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
	Sunil Kovvuri Goutham <sgoutham@marvell.com>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [EXT] Re: [PATCH 1/2] mmc: Support kmsg dumper based on pstore/blk
Date: Tue, 15 Dec 2020 12:37:12 -0800	[thread overview]
Message-ID: <202012151232.843EB2CB49@keescook> (raw)
In-Reply-To: <CAPDyKFqMsMdqw=Uwzby0tNNvPieRT2i6PAmHu_9XRRVy1MykuQ@mail.gmail.com>

On Tue, Dec 15, 2020 at 12:42:58PM +0100, Ulf Hansson wrote:
> In principle, for non atomic path, I would rather see that the pstore
> file system should be able to be mounted on top of any generic block
> device partition - without requiring the block device driver to
> implement specific pstore ops.
> [...]
> Exactly. That's why I wonder if it's really worth it to support the
> panic writes at all.

pstore/blk already provides the generic hooking -- but it can't do
the panic write part (which that's very device/driver-specific). The
design was for individual backing devices to provide that directly
(which would needed read/write support too). And for those that don't
have panic/read/write support, they could still use the generic hooks
but they wouldn't be able to reliably (or at all?) catch panics (just
console writes, ftrace, pmsg, etc).

-- 
Kees Cook

  parent reply	other threads:[~2020-12-15 20:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-07 11:57 [PATCH v3 0/2] mmc: support crash logging to MMC block devices Bhaskara Budiredla
2020-12-07 11:57 ` [PATCH 1/2] mmc: Support kmsg dumper based on pstore/blk Bhaskara Budiredla
2020-12-11 11:31   ` Ulf Hansson
2020-12-15  6:52     ` [EXT] " Bhaskara Budiredla
2020-12-15 11:42       ` Ulf Hansson
2020-12-15 14:34         ` Bhaskara Budiredla
2020-12-16  9:57           ` Ulf Hansson
2020-12-16 10:42             ` Bhaskara Budiredla
2020-12-16 10:52               ` Ulf Hansson
2020-12-17 11:36                 ` Bhaskara Budiredla
2020-12-17 17:11                   ` Ulf Hansson
2020-12-18  4:02                     ` Bhaskara Budiredla
2020-12-15 20:37         ` Kees Cook [this message]
2020-12-16 10:44           ` Ulf Hansson
2020-12-18 18:50             ` Kees Cook
2020-12-07 11:57 ` [PATCH 2/2] mmc: cavium: Add MMC polling method to support kmsg panic/oops write Bhaskara Budiredla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202012151232.843EB2CB49@keescook \
    --to=keescook@chromium.org \
    --cc=bbudiredla@marvell.com \
    --cc=ccross@android.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=sgoutham@marvell.com \
    --cc=tony.luck@intel.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.