Hi Calvin, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Calvin-Johnson/ACPI-support-for-dpaa2-driver/20201216-010124 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git efd5a1584537698220578227e6467638307c2a0b config: m68k-randconfig-r005-20201215 (attached as .config) compiler: m68k-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/b093f5463658b3a513d5b95ef208ee3264f1db08 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Calvin-Johnson/ACPI-support-for-dpaa2-driver/20201216-010124 git checkout b093f5463658b3a513d5b95ef208ee3264f1db08 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): drivers/base/property.c: In function 'fwnode_get_id': >> drivers/base/property.c:598:12: error: implicit declaration of function 'acpi_evaluate_integer'; did you mean 'acpi_evaluate_object'? [-Werror=implicit-function-declaration] 598 | status = acpi_evaluate_integer(ACPI_HANDLE_FWNODE(fwnode), | ^~~~~~~~~~~~~~~~~~~~~ | acpi_evaluate_object cc1: some warnings being treated as errors vim +598 drivers/base/property.c 582 583 /** 584 * fwnode_get_id - Get the id of a fwnode. 585 * @fwnode: firmware node 586 * @id: id of the fwnode 587 * 588 * Returns 0 on success or a negative errno. 589 */ 590 int fwnode_get_id(struct fwnode_handle *fwnode, u32 *id) 591 { 592 unsigned long long adr; 593 acpi_status status; 594 595 if (is_of_node(fwnode)) { 596 return of_property_read_u32(to_of_node(fwnode), "reg", id); 597 } else if (is_acpi_node(fwnode)) { > 598 status = acpi_evaluate_integer(ACPI_HANDLE_FWNODE(fwnode), 599 METHOD_NAME__ADR, NULL, &adr); 600 if (ACPI_FAILURE(status)) 601 return -ENODATA; 602 *id = (u32)adr; 603 return 0; 604 } 605 return -EINVAL; 606 } 607 EXPORT_SYMBOL_GPL(fwnode_get_id); 608 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org