From: Jakub Kicinski <kuba@kernel.org>
To: trix@redhat.com
Cc: 3chas3@gmail.com, linux-atm-general@lists.sourceforge.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] atm: ambassador: remove h from printk format specifier
Date: Wed, 16 Dec 2020 16:45:10 -0800 [thread overview]
Message-ID: <20201216164510.770454d8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20201215142228.1847161-1-trix@redhat.com>
On Tue, 15 Dec 2020 06:22:28 -0800 trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> See Documentation/core-api/printk-formats.rst.
> h should no longer be used in the format specifier for printk.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
That's for new code I assume?
What's the harm in leaving this ancient code be?
> diff --git a/drivers/atm/ambassador.c b/drivers/atm/ambassador.c
> index c039b8a4fefe..6b0fff8c0141 100644
> --- a/drivers/atm/ambassador.c
> +++ b/drivers/atm/ambassador.c
> @@ -2169,7 +2169,7 @@ static void setup_pci_dev(struct pci_dev *pci_dev)
> pci_lat = (lat < MIN_PCI_LATENCY) ? MIN_PCI_LATENCY : lat;
>
> if (lat != pci_lat) {
> - PRINTK (KERN_INFO, "Changing PCI latency timer from %hu to %hu",
> + PRINTK (KERN_INFO, "Changing PCI latency timer from %u to %u",
> lat, pci_lat);
> pci_write_config_byte(pci_dev, PCI_LATENCY_TIMER, pci_lat);
> }
> @@ -2300,7 +2300,7 @@ static void __init amb_check_args (void) {
> unsigned int max_rx_size;
>
> #ifdef DEBUG_AMBASSADOR
> - PRINTK (KERN_NOTICE, "debug bitmap is %hx", debug &= DBG_MASK);
> + PRINTK (KERN_NOTICE, "debug bitmap is %x", debug &= DBG_MASK);
> #else
> if (debug)
> PRINTK (KERN_NOTICE, "no debugging support");
next prev parent reply other threads:[~2020-12-17 0:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 14:22 [PATCH] atm: ambassador: remove h from printk format specifier trix
2020-12-17 0:45 ` Jakub Kicinski [this message]
2020-12-17 13:17 ` Tom Rix
2020-12-17 17:28 ` Jakub Kicinski
2020-12-17 22:03 ` Tom Rix
2020-12-18 18:02 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201216164510.770454d8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=3chas3@gmail.com \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.