From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C166C352A6 for ; Wed, 16 Dec 2020 18:26:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C3F324B9C for ; Wed, 16 Dec 2020 18:26:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730551AbgLPSZx (ORCPT ); Wed, 16 Dec 2020 13:25:53 -0500 Received: from honk.sigxcpu.org ([24.134.29.49]:45208 "EHLO honk.sigxcpu.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730503AbgLPSZv (ORCPT ); Wed, 16 Dec 2020 13:25:51 -0500 Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id CE92FFB03; Wed, 16 Dec 2020 19:25:07 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cqkJ8AbYKf6s; Wed, 16 Dec 2020 19:25:06 +0100 (CET) Received: by bogon.sigxcpu.org (Postfix, from userid 1000) id F0ED143FDC; Wed, 16 Dec 2020 19:25:05 +0100 (CET) Date: Wed, 16 Dec 2020 19:25:05 +0100 From: Guido =?iso-8859-1?Q?G=FCnther?= To: Lucas Stach Cc: Kishon Vijay Abraham I , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Robert Chiras , Sam Ravnborg , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 1/1] phy: fsl-imx8-mipi-dphy: Hook into runtime pm Message-ID: <20201216182505.GA51879@bogon.m.sigxcpu.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lucas, On Wed, Dec 16, 2020 at 01:05:36PM +0100, Lucas Stach wrote: > Hi Guido, > > this time hopefully with less broken quoting. My mailer is driving me > mad right now... > > Am Mittwoch, dem 16.12.2020 um 12:27 +0100 schrieb Guido Günther: > > This allows us to shut down the mipi power domain on the imx8. The > > alternative would be to drop the dphy from the mipi power domain in the > > SOCs device tree and only have the DSI host controller visible there but > > since the PD is mostly about the PHY that would defeat it's purpose. > > Adding RPM support is exactly the right course of action. Thanks for confirming! > > > This allows to shut off the power domain hen blanking the LCD panel: > > > > pm_genpd_summary before: > > > > domain status slaves > >     /device runtime status > > ---------------------------------------------------------------------- > > mipi on > >     /devices/platform/soc@0/soc@0:bus@30800000/30a00300.dphy unsupported > >     /devices/platform/soc@0/soc@0:bus@30800000/30a00000.mipi_dsi suspended > > > > after: > > > > mipi off-0 > >     /devices/platform/soc@0/soc@0:bus@30800000/30a00300.dphy suspended > >     /devices/platform/soc@0/soc@0:bus@30800000/30a00000.mipi_dsi suspended > > > > Signed-off-by: Guido Günther > > --- > >  .../phy/freescale/phy-fsl-imx8-mipi-dphy.c | 22 ++++++++++++++++++- > >  1 file changed, 21 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c > > index a95572b397ca..34e2d801e520 100644 > > --- a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c > > +++ b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c > > @@ -14,6 +14,7 @@ > >  #include > >  #include > >  #include > > +#include > >  #include > >   > >  /* DPHY registers */ > > @@ -93,6 +94,7 @@ struct mixel_dphy_cfg { > >  }; > >   > >  struct mixel_dphy_priv { > > + struct device *dev; > >   struct mixel_dphy_cfg cfg; > >   struct regmap *regmap; > >   struct clk *phy_ref_clk; > > @@ -382,6 +384,7 @@ static int mixel_dphy_power_on(struct phy *phy) > >   ret = clk_prepare_enable(priv->phy_ref_clk); > >   if (ret < 0) > >   return ret; > > + pm_runtime_get_sync(priv->dev); > >   > > This call can fail and will leave you with an elevated rpm refcount. > Better use the new pm_runtime_resume_and_get to avoid this issue? pm_runtime_resume_and_get is a nice API addition indeed. I added the error handling but opted to stay with `pm_runtime_get_sync` in this case since the error path already has a pm_runtime_put() hence avoiding another goto target. > > Nitpick: I would add a blank line before the call. Done. Thanks for having a look! -- Guido > > Regards, > Lucas > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7586BC2BBCF for ; Wed, 16 Dec 2020 18:26:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E4A024B9D for ; Wed, 16 Dec 2020 18:26:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E4A024B9D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sigxcpu.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nNIcXuToGOZKK+ehAAaxQrG8tdSDKF0X7scDHBMk0/4=; b=V5dkCsJ9KsI3UmdFE69xYaAzi 3riYcQibjzxGHrF2VB4n3O7SYSA7T+1/iHPyuoYJFOw3lx3MD3fD31K8V9IQAo/XVIf8AI+J8XK3Y Q2THse6OlLyyAOnwluimb1h1wFO/bQ06gC5L4B8dZUxB+vGuAzN9Fiz+oWSkpkPchC5ZjDfZFtUzv NQiRZgvaakhQn/rqKy/nZcOoDUgwgVOofORSRigkKjNzjxK66nXFsMyXbtQIzbB9SxdBJ6w3t1slk GJaq/NeivUwgEpr08KrLrUfBNgzta5ZoxvjSLksuu5/6rYQF7yw8mk8iTnnIKIVKgHXxND6iRQTj+ 8nu72itVA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kpbU7-00012A-Kz; Wed, 16 Dec 2020 18:25:11 +0000 Received: from honk.sigxcpu.org ([24.134.29.49]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kpbU5-00011P-7C for linux-arm-kernel@lists.infradead.org; Wed, 16 Dec 2020 18:25:10 +0000 Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id CE92FFB03; Wed, 16 Dec 2020 19:25:07 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cqkJ8AbYKf6s; Wed, 16 Dec 2020 19:25:06 +0100 (CET) Received: by bogon.sigxcpu.org (Postfix, from userid 1000) id F0ED143FDC; Wed, 16 Dec 2020 19:25:05 +0100 (CET) Date: Wed, 16 Dec 2020 19:25:05 +0100 From: Guido =?iso-8859-1?Q?G=FCnther?= To: Lucas Stach Subject: Re: [PATCH v2 1/1] phy: fsl-imx8-mipi-dphy: Hook into runtime pm Message-ID: <20201216182505.GA51879@bogon.m.sigxcpu.org> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201216_132509_428763_C6834B14 X-CRM114-Status: GOOD ( 24.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sam Ravnborg , Shawn Guo , Sascha Hauer , linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , NXP Linux Team , Pengutronix Kernel Team , Robert Chiras , Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Lucas, On Wed, Dec 16, 2020 at 01:05:36PM +0100, Lucas Stach wrote: > Hi Guido, > = > this time hopefully with less broken quoting. My mailer is driving me > mad right now... > = > Am Mittwoch, dem 16.12.2020 um 12:27 +0100 schrieb Guido G=FCnther: > > This allows us to shut down the mipi power domain on the imx8. The > > alternative would be to drop the dphy from the mipi power domain in the > > SOCs device tree and only have the DSI host controller visible there but > > since the PD is mostly about the PHY that would defeat it's purpose. > = > Adding RPM support is exactly the right course of action. Thanks for confirming! > = > > This allows to shut off the power domain hen blanking the LCD panel: > > = > > pm_genpd_summary before: > > = > > domain status slaves > > =A0=A0=A0=A0/device runtime= status > > ---------------------------------------------------------------------- > > mipi on > > =A0=A0=A0=A0/devices/platform/soc@0/soc@0:bus@30800000/30a00300.dphy u= nsupported > > =A0=A0=A0=A0/devices/platform/soc@0/soc@0:bus@30800000/30a00000.mipi_ds= i suspended > > = > > after: > > = > > mipi off-0 > > =A0=A0=A0=A0/devices/platform/soc@0/soc@0:bus@30800000/30a00300.dphy s= uspended > > =A0=A0=A0=A0/devices/platform/soc@0/soc@0:bus@30800000/30a00000.mipi_ds= i suspended > > = > > Signed-off-by: Guido G=FCnther > > --- > > =A0.../phy/freescale/phy-fsl-imx8-mipi-dphy.c | 22 +++++++++++++++++= +- > > =A01 file changed, 21 insertions(+), 1 deletion(-) > > = > > diff --git a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c b/drivers/p= hy/freescale/phy-fsl-imx8-mipi-dphy.c > > index a95572b397ca..34e2d801e520 100644 > > --- a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c > > +++ b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c > > @@ -14,6 +14,7 @@ > > =A0#include > > =A0#include > > =A0#include > > +#include > > =A0#include > > =A0 > > =A0/* DPHY registers */ > > @@ -93,6 +94,7 @@ struct mixel_dphy_cfg { > > =A0}; > > =A0 > > =A0struct mixel_dphy_priv { > > + struct device *dev; > > =A0 struct mixel_dphy_cfg cfg; > > =A0 struct regmap *regmap; > > =A0 struct clk *phy_ref_clk; > > @@ -382,6 +384,7 @@ static int mixel_dphy_power_on(struct phy *phy) > > =A0 ret =3D clk_prepare_enable(priv->phy_ref_clk); > > =A0 if (ret < 0) > > =A0 return ret; > > + pm_runtime_get_sync(priv->dev); > > =A0 > = > This call can fail and will leave you with an elevated rpm refcount. > Better use the new pm_runtime_resume_and_get to avoid this issue? pm_runtime_resume_and_get is a nice API addition indeed. I added the error handling but opted to stay with `pm_runtime_get_sync` in this case since the error path already has a pm_runtime_put() hence avoiding another goto target. > = > Nitpick: I would add a blank line before the call. Done. Thanks for having a look! -- Guido > = > Regards, > Lucas > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel