From: "Paul E. McKenney" <email@example.com> To: Thomas Gleixner <firstname.lastname@example.org> Cc: Peter Zijlstra <email@example.com>, Marco Elver <firstname.lastname@example.org>, LKML <email@example.com>, kasan-dev <firstname.lastname@example.org>, Ingo Molnar <email@example.com>, Frederic Weisbecker <firstname.lastname@example.org>, Will Deacon <email@example.com>, Naresh Kamboju <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org, email@example.com Subject: Re: [patch 3/3] tick: Annotate tick_do_timer_cpu data races Date: Wed, 16 Dec 2020 13:19:31 -0800 [thread overview] Message-ID: <20201216211931.GL2657@paulmck-ThinkPad-P72> (raw) In-Reply-To: <firstname.lastname@example.org> On Wed, Dec 16, 2020 at 01:27:43AM +0100, Thomas Gleixner wrote: > On Tue, Dec 08 2020 at 07:03, Paul E. McKenney wrote: > > > On Tue, Dec 08, 2020 at 09:11:29AM +0100, Peter Zijlstra wrote: > >> On Mon, Dec 07, 2020 at 11:44:06AM -0800, Paul E. McKenney wrote: > >> > >> > Also, in this particular case, why data_race() rather than READ_ONCE()? > >> > Do we really expect the compiler to be able to optimize this case > >> > significantly without READ_ONCE()? > > There is probably not much optimization potential for the compiler if > data_race() is used vs. READ/WRITE_ONCE() in this code. OK, got it. > >> It's about intent and how the code reads. READ_ONCE() is something > >> completely different from data_race(). data_race() is correct here. > > > > Why? > > Lemme answer that to the extent why _I_ chose data_race() - aside of my > likely confusion over our IRC conversation. > > The code does not really care about the compiler trying to be clever or > not as it is designed to be tolerant of all sorts of concurrency > including competing writes. It does not care about multiple reloads > either. It neither cares about invented stores as long as these > invented stores are not storing phantasy values. > > The only thing it cares about is store/load tearing, but there is no > 'clever' way to use that because of the only valid transitions of > 'cpunr' which comes from smp_processor_id() to TICK_DO_TIMER_NONE which > is the only constant involved or the other way round (which is > intentionally subject to competing stores). > > If the compiler is free to store the 32bit value as 4 seperate bytes or > does invented stores with phantasy values, then there is surely a reason > to switch to READ/WRITE_ONCE(), but that'd be a really daft reason. > > So my intent was to document that this code does not care about anything > else than what I'd consider to be plain compiler bugs. > > My conclusion might be wrong as usual :) Given that there is no optimization potential, then the main reason to use data_race() instead of *_ONCE() is to prevent KCSAN from considering the accesses when looking for data races. But that is mostly for debugging accesses, in cases when these accesses are not really part of the concurrent algorithm. So if I understand the situation correctly, I would be using *ONCE(). Thanx, Paul
next prev parent reply other threads:[~2020-12-16 21:22 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-06 21:12 [patch 0/3] tick: Annotate and document the intentionaly racy tick_do_timer_cpu Thomas Gleixner 2020-12-06 21:12 ` [patch 1/3] tick: Remove pointless cpu valid check in hotplug code Thomas Gleixner 2020-12-07 11:59 ` Peter Zijlstra 2020-12-07 17:44 ` Thomas Gleixner 2020-12-11 22:21 ` Frederic Weisbecker 2020-12-12 0:16 ` Thomas Gleixner 2020-12-12 1:20 ` Frederic Weisbecker 2020-12-11 22:31 ` Frederic Weisbecker 2020-12-16 10:50 ` [tip: timers/urgent] " tip-bot2 for Thomas Gleixner 2020-12-06 21:12 ` [patch 2/3] tick/sched: Remove bogus boot "safety" check Thomas Gleixner 2020-12-11 22:41 ` Frederic Weisbecker 2020-12-16 10:50 ` [tip: timers/urgent] " tip-bot2 for Thomas Gleixner 2020-12-06 21:12 ` [patch 3/3] tick: Annotate tick_do_timer_cpu data races Thomas Gleixner 2020-12-07 12:09 ` Peter Zijlstra 2020-12-07 17:46 ` Thomas Gleixner 2020-12-07 18:19 ` Marco Elver 2020-12-07 19:43 ` Thomas Gleixner 2020-12-07 19:44 ` Paul E. McKenney 2020-12-07 21:46 ` Thomas Gleixner 2020-12-07 22:38 ` Paul E. McKenney 2020-12-07 22:46 ` Thomas Gleixner 2020-12-07 22:55 ` Paul E. McKenney 2020-12-08 8:11 ` Peter Zijlstra 2020-12-08 15:03 ` Paul E. McKenney 2020-12-16 0:27 ` Thomas Gleixner 2020-12-16 21:19 ` Paul E. McKenney [this message] 2020-12-16 21:23 ` Thomas Gleixner 2020-12-16 21:32 ` Paul E. McKenney 2020-12-17 10:48 ` Peter Zijlstra 2020-12-17 14:59 ` Paul E. McKenney 2020-12-08 8:01 ` Peter Zijlstra 2020-12-07 11:05 ` [patch 0/3] tick: Annotate and document the intentionaly racy tick_do_timer_cpu Marco Elver
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201216211931.GL2657@paulmck-ThinkPad-P72 \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [patch 3/3] tick: Annotate tick_do_timer_cpu data races' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.