From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 839F4C0018C for ; Thu, 17 Dec 2020 02:10:13 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 066C323715 for ; Thu, 17 Dec 2020 02:10:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 066C323715 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39232 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpik7-0004dT-RN for qemu-devel@archiver.kernel.org; Wed, 16 Dec 2020 21:10:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53508) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpia2-0002DH-JT for qemu-devel@nongnu.org; Wed, 16 Dec 2020 20:59:46 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:44882) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kpiZt-0007AO-SS for qemu-devel@nongnu.org; Wed, 16 Dec 2020 20:59:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608170377; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=sUSc7bw59ab/8JDm7pBrVUsAKC7Suk2vKmQuj1tO8zQ=; b=fywVGxrW2i6E/0bDaTrfLfHWedQmIx1VjEocPZwbHCqrsCMJd+gmFPICUuMAe+TJgpS8Z5 bQ8J6n3nvH5Do2GrUbPYo6j/rgqG721v0u7W7n+TsxNupB6DZIAcshhdfjQ2WcsQJK9BQc l23BAjo1YSKZGLCe416j0dODX90cJYo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-358-x7cfrtH7Nra2vgdGNZf0uw-1; Wed, 16 Dec 2020 20:59:33 -0500 X-MC-Unique: x7cfrtH7Nra2vgdGNZf0uw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4F76A107ACE3; Thu, 17 Dec 2020 01:59:32 +0000 (UTC) Received: from scv.redhat.com (ovpn-112-131.rdu2.redhat.com [10.10.112.131]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4E5C772163; Thu, 17 Dec 2020 01:59:28 +0000 (UTC) From: John Snow To: qemu-devel@nongnu.org Subject: [PATCH v2 00/12] qapi: static typing conversion, pt1.5 Date: Wed, 16 Dec 2020 20:59:15 -0500 Message-Id: <20201217015927.197287-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=63.128.21.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , Michael Roth , Markus Armbruster , Cleber Rosa , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , John Snow Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi, this patchset enables strict optional checking in mypy for=0D everything we have typed so far.=0D =0D In general, this patchset seeks to eliminate Optional[T] in favor of T=0D wherever possible. Optional types used for object properties,=0D function/method parameters and return values where we expect, in most=0D cases, to be non-None is troublesome as it requires peppering the code=0D with assertions about state. If and whenever possible, prefer using=0D non-Optional types.=0D =0D Ironing out these issues allows us to be even stricter with our type=0D checking, which improves consistency in subclass interface types and=0D should make review a little nicer.=0D =0D This series is based on (but does not require) the 'qapi: sphinx-autodoc=0D for qapi module' series.=0D =0D V2:=0D =0D 001/12:[----] [--] 'qapi/commands: assert arg_type is not None'=0D 002/12:[----] [--] 'qapi/events: fix visit_event typing'=0D 003/12:[0003] [FC] 'qapi/main: handle theoretical None-return from re.match= ()'=0D 004/12:[----] [--] 'qapi/gen: assert that _start_if is not None in _wrap_if= cond'=0D 005/12:[0003] [FC] 'qapi/gen: use './builtin' for the built-in module name'= =0D 006/12:[0004] [FC] 'qapi/source: Add builtin null-object sentinel'=0D 007/12:[0024] [FC] 'qapi/schema: make QAPISourceInfo mandatory'=0D 008/12:[----] [--] 'qapi/gen: write _genc/_genh access shims'=0D 009/12:[----] [--] 'qapi/gen: move write method to QAPIGenC, make fname a s= tr'=0D 010/12:[----] [--] 'tests/qapi-schema: Add quotes to module name in test ou= tput'=0D 011/12:[0004] [FC] 'qapi/schema: Name the builtin module "" instead of None= '=0D 012/12:[----] [--] 'qapi: enable strict-optional checks'=0D =0D - This revision isn't quite complete, but due to deadlines and=0D timezones, opted to send the "revision so far". It keeps some=0D imperfect fixes that Markus is devising better alternatives for.=0D =0D John Snow (12):=0D qapi/commands: assert arg_type is not None=0D qapi/events: fix visit_event typing=0D qapi/main: handle theoretical None-return from re.match()=0D qapi/gen: assert that _start_if is not None in _wrap_ifcond=0D qapi/gen: use './builtin' for the built-in module name=0D qapi/source: Add builtin null-object sentinel=0D qapi/schema: make QAPISourceInfo mandatory=0D qapi/gen: write _genc/_genh access shims=0D qapi/gen: move write method to QAPIGenC, make fname a str=0D tests/qapi-schema: Add quotes to module name in test output=0D qapi/schema: Name the builtin module "" instead of None=0D qapi: enable strict-optional checks=0D =0D scripts/qapi/commands.py | 11 ++-=0D scripts/qapi/events.py | 14 +--=0D scripts/qapi/gen.py | 108 ++++++++++++-----------=0D scripts/qapi/main.py | 2 +=0D scripts/qapi/mypy.ini | 1 -=0D scripts/qapi/schema.py | 35 ++++----=0D scripts/qapi/source.py | 20 ++++-=0D scripts/qapi/types.py | 11 +--=0D scripts/qapi/visit.py | 8 +-=0D tests/qapi-schema/comments.out | 4 +-=0D tests/qapi-schema/doc-good.out | 4 +-=0D tests/qapi-schema/empty.out | 4 +-=0D tests/qapi-schema/event-case.out | 4 +-=0D tests/qapi-schema/include-repetition.out | 8 +-=0D tests/qapi-schema/include-simple.out | 6 +-=0D tests/qapi-schema/indented-expr.out | 4 +-=0D tests/qapi-schema/qapi-schema-test.out | 8 +-=0D tests/qapi-schema/test-qapi.py | 2 +-=0D 18 files changed, 145 insertions(+), 109 deletions(-)=0D =0D --=20=0D 2.26.2=0D =0D